[iOS] Migrate @UIApplicationMain attribute to @main by loic-sharma · Pull Request #146707 · flutter/flutter

loic-sharma · 2024-04-12T23:38:06Z

This migrates Flutter to use the @main attribute introduced in Swift 5.3. The @UIApplicationMain attribute is deprecated and will be removed in Swift 6. See: https://github.com/apple/swift-evolution/blob/main/proposals/0383-deprecate-uiapplicationmain-and-nsapplicationmain.md

This change is split into two commits:

ad18797 - This updates the iOS app template and adds a migration to replace @UIApplicationMain uses with @main.
8ecbb2f - I ran flutter run on each Flutter iOS app in this repository to verify the app migrates and launches successfully.

Part of #143044

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

loic-sharma · 2024-04-15T18:16:05Z

dev/integration_tests/ios_host_app_swift/Host/AppDelegate.swift

 import UIKit

-@UIApplicationMain
+@main


This isn't a Flutter application. I updated this by hand.

loic-sharma · 2024-04-15T18:16:58Z

examples/platform_channel_swift/ios/Runner/AppDelegate.swift

 }

-@UIApplicationMain
+@main


This file contains significant edits from the starter app template. The migration is flexible enough to be able to update this correctly.

jmagman

Minor nits, LGTM! Thank you for doing this!

packages/flutter_tools/lib/src/ios/migrations/uiapplicationmain_deprecation_migration.dart

jmagman · 2024-04-15T20:51:08Z

"Addresses #143044" if you make this "Fixes #143044" GitHub will link them and close the issue when this is merged.

vashworth · 2024-04-15T21:57:13Z

"Addresses #143044" if you make this "Fixes #143044" GitHub will link them and close the issue when this is merged.

@loic-sharma Did you happen to check if NSApplicationMain (the macOS version of this) was also deprecated?

I'm not sure if we want to mark the issue as fixed since it refers to both the iOS and macOS version. If we want to handle them separately, can you file a separate issue to address the macOS one?

hellohuanlin · 2024-04-15T22:53:16Z

How do I trigger this migration for existing projects? Do I run a migration command? Or do I simply do flutter clean and then regenerate these files?

jmagman · 2024-04-16T02:43:08Z

How do I trigger this migration for existing projects? Do I run a migration command? Or do I simply do flutter clean and then regenerate these files?

The migrations run when the app compiles, so every flutter run will do it. It doesn't need to be regenerated, the migration edits the existing file.

loic-sharma · 2024-04-16T14:42:17Z

@vashworth Good point, I'll update the macOS template in a follow-up pull request using the same issue. I'll keep the issue open until then!

EDIT: macOS pull request is here: #146848

…flutter#146707)

This migrates Flutter to use the `@main` attribute introduced in Swift 5.3. The `@NSApplicationMain` attribute is deprecated and will be removed in Swift 6. See: https://github.com/apple/swift-evolution/blob/main/proposals/0383-deprecate-uiapplicationmain-and-nsapplicationmain.md This change is split into two commits: 1. a508d3e - This updates the macOS app template and adds a migration to replace `@NSApplicationMain` uses with `@main`. 2. f434827 - I ran `flutter run -d macos` on each Flutter macOS app in this repository to verify the app migrates and launches successfully. Follow-up to #146707 Fixes #143044

…flutter#146707)

This migrates Flutter to use the `@main` attribute introduced in Swift 5.3. The `@UIApplicationMain` attribute is deprecated and will be removed in Swift 6. See: https://github.com/apple/swift-evolution/blob/main/proposals/0383-deprecate-uiapplicationmain-and-nsapplicationmain.md This change is split into two commits: 1. flutter@ad18797 - This updates the iOS app template and adds a migration to replace `@UIApplicationMain` uses with `@main`. 2. flutter@8ecbb2f - I ran `flutter run` on each Flutter iOS app in this repository to verify the app migrates and launches successfully. Part of flutter#143044

This migrates Flutter to use the `@main` attribute introduced in Swift 5.3. The `@NSApplicationMain` attribute is deprecated and will be removed in Swift 6. See: https://github.com/apple/swift-evolution/blob/main/proposals/0383-deprecate-uiapplicationmain-and-nsapplicationmain.md This change is split into two commits: 1. flutter@a508d3e - This updates the macOS app template and adds a migration to replace `@NSApplicationMain` uses with `@main`. 2. flutter@f434827 - I ran `flutter run -d macos` on each Flutter macOS app in this repository to verify the app migrates and launches successfully. Follow-up to flutter#146707 Fixes flutter#143044

github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Apr 12, 2024

[iOS] Migrate @UIApplicationMain attribute to @main

ad18797

loic-sharma force-pushed the uiapplicationmain_migration branch from 5cc9612 to ad18797 Compare April 15, 2024 17:20

Migrate Swift projects

8ecbb2f

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Apr 15, 2024

loic-sharma commented Apr 15, 2024

View reviewed changes

loic-sharma requested review from hellohuanlin, jmagman and vashworth April 15, 2024 18:31

loic-sharma marked this pull request as ready for review April 15, 2024 18:31

jmagman approved these changes Apr 15, 2024

View reviewed changes

packages/flutter_tools/lib/src/ios/migrations/uiapplicationmain_deprecation_migration.dart Outdated Show resolved Hide resolved

packages/flutter_tools/lib/src/ios/migrations/uiapplicationmain_deprecation_migration.dart Outdated Show resolved Hide resolved

Feedback

839a6b3

Fix tests

5602a94

loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2024

loic-sharma mentioned this pull request Apr 16, 2024

[macOS] Migrate @NSApplicationMain attribute to @main #146848

Merged

9 tasks

auto-submit bot merged commit 194fefa into flutter:master Apr 16, 2024

loic-sharma deleted the uiapplicationmain_migration branch April 16, 2024 22:13

engine-flutter-autoroll mentioned this pull request Apr 17, 2024

Roll Flutter from 3882afbfa997 to 180b77685b31 (24 revisions) flutter/packages#6554

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024

194fefa [iOS] Migrate @UIApplicationMain attribute to @main (flutter/…

919f2ad

…flutter#146707)

engine-flutter-autoroll mentioned this pull request Apr 17, 2024

Roll Flutter from 3882afbfa997 to cd43d06c44aa (25 revisions) flutter/packages#6555

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024

194fefa [iOS] Migrate @UIApplicationMain attribute to @main (flutter/…

848be01

…flutter#146707)

engine-flutter-autoroll mentioned this pull request Apr 17, 2024

Roll Flutter from 3882afbfa997 to cf26b1150f4b (26 revisions) flutter/packages#6558

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024

194fefa [iOS] Migrate @UIApplicationMain attribute to @main (flutter/…

bf4d3c8

…flutter#146707)

engine-flutter-autoroll mentioned this pull request Apr 17, 2024

Roll Flutter from 3882afbfa997 to 0301c8dfa41e (27 revisions) flutter/packages#6559

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024

194fefa [iOS] Migrate @UIApplicationMain attribute to @main (flutter/…

1adb5e8

…flutter#146707)

engine-flutter-autoroll mentioned this pull request Apr 17, 2024

Roll Flutter from 3882afbfa997 to f8c3e52776ae (29 revisions) flutter/packages#6560

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024

194fefa [iOS] Migrate @UIApplicationMain attribute to @main (flutter/…

038cd15

…flutter#146707)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2024

194fefa [iOS] Migrate @UIApplicationMain attribute to @main (flutter/…

08201fa

…flutter#146707)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2024

194fefa [iOS] Migrate @UIApplicationMain attribute to @main (flutter/…

d166bfb

…flutter#146707)

ricardodalarme mentioned this pull request Dec 12, 2025

chore: replace deprecated @UIApplicationMain with @main on iOS templates VeryGoodOpenSource/very_good_templates#404

Closed

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[iOS] Migrate @UIApplicationMain attribute to @main#146707

[iOS] Migrate @UIApplicationMain attribute to @main#146707
auto-submit[bot] merged 4 commits intoflutter:masterfrom
loic-sharma:uiapplicationmain_migration

loic-sharma commented Apr 12, 2024 •

edited

Loading

Uh oh!

loic-sharma Apr 15, 2024

Uh oh!

loic-sharma Apr 15, 2024

Uh oh!

jmagman left a comment

Uh oh!

Uh oh!

Uh oh!

jmagman commented Apr 15, 2024

Uh oh!

vashworth commented Apr 15, 2024

Uh oh!

hellohuanlin commented Apr 15, 2024

Uh oh!

jmagman commented Apr 16, 2024 •

edited

Loading

Uh oh!

loic-sharma commented Apr 16, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

loic-sharma commented Apr 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

loic-sharma Apr 15, 2024

Choose a reason for hiding this comment

Uh oh!

loic-sharma Apr 15, 2024

Choose a reason for hiding this comment

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jmagman commented Apr 15, 2024

Uh oh!

vashworth commented Apr 15, 2024

Uh oh!

hellohuanlin commented Apr 15, 2024

Uh oh!

jmagman commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

loic-sharma commented Apr 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

loic-sharma commented Apr 12, 2024 •

edited

Loading

jmagman commented Apr 16, 2024 •

edited

Loading

loic-sharma commented Apr 16, 2024 •

edited

Loading