Skip to content

Added missing tests for OverflowBar example.#146780

Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom
matthew-carroll:130459_add-test-for-overflow-bar-example
Apr 16, 2024
Merged

Added missing tests for OverflowBar example.#146780
auto-submit[bot] merged 2 commits intoflutter:masterfrom
matthew-carroll:130459_add-test-for-overflow-bar-example

Conversation

@matthew-carroll
Copy link
Contributor

@matthew-carroll matthew-carroll commented Apr 15, 2024

Added missing tests for OverflowBar example. Issue #130459

Pre-launch Checklist

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Apr 15, 2024
@TahaTesser TahaTesser self-requested a review April 15, 2024 20:32
TahaTesser
TahaTesser approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@TahaTesser TahaTesser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TahaTesser
Copy link
Contributor

TahaTesser commented Apr 15, 2024 •
edited
Loading

@matthew-carroll
We need to remove this example class line from missing tests from flutter/dev/bots/check_code_samples.dart in order to land this.

@TahaTesser TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Apr 15, 2024

auto label is removed for flutter/flutter/146780, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Apr 15, 2024
@TahaTesser TahaTesser force-pushed the 130459_add-test-for-overflow-bar-example branch from 79fcc44 to f689516 Compare April 16, 2024 04:05
@TahaTesser TahaTesser force-pushed the 130459_add-test-for-overflow-bar-example branch from f689516 to aac4c65 Compare April 16, 2024 06:50
@matthew-carroll
Copy link
Contributor Author

matthew-carroll commented Apr 16, 2024

@TahaTesser I noticed multiple changes from your end. What's up with this PR? What kinds of things are you needing to change?

@TahaTesser
Copy link
Contributor

TahaTesser commented Apr 16, 2024

@TahaTesser I noticed multiple changes from your end. What's up with this PR? What kinds of things are you needing to change?

I just rebased the PR from GitHub UI for the Google Testing to pass.

@matthew-carroll
Copy link
Contributor Author

matthew-carroll commented Apr 16, 2024

@TahaTesser but what was wrong with the PR? Why did it need to be rebased twice?

@TahaTesser
Copy link
Contributor

TahaTesser commented Apr 16, 2024

@TahaTesser but what was wrong with the PR? Why did it need to be rebased twice?

There isn't an issue with the PR itself. Google testing can fail other reasons. This s good to land whenever the checks are green.

@matthew-carroll
Copy link
Contributor Author

matthew-carroll commented Apr 16, 2024

Looks like we're still broken :(

I think we've spent more time monitoring this PR than we spent implementing it!

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 16, 2024
@auto-submit auto-submit bot merged commit 4daad32 into flutter:master Apr 16, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
@engine-flutter-autoroll
4daad32 Added missing tests for OverflowBar example. (flutter/flutter…
1149750 
…#146780)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
@engine-flutter-autoroll
4daad32 Added missing tests for OverflowBar example. (flutter/flutter…
65212e5 
…#146780)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
@engine-flutter-autoroll
4daad32 Added missing tests for OverflowBar example. (flutter/flutter…
c9cccb3 
…#146780)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
@engine-flutter-autoroll
4daad32 Added missing tests for OverflowBar example. (flutter/flutter…
b1add0e 
…#146780)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024
@engine-flutter-autoroll
4daad32 Added missing tests for OverflowBar example. (flutter/flutter…
c0de951 
…#146780)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2024
@engine-flutter-autoroll
4daad32 Added missing tests for OverflowBar example. (flutter/flutter…
433edb3 
…#146780)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2024
@engine-flutter-autoroll
4daad32 Added missing tests for OverflowBar example. (flutter/flutter…
9e37d72 
…#146780)
gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024
@matthew-carroll @gilnobrega
Added missing tests for OverflowBar example. (flutter#146780)
4a7d73f 
Added missing tests for OverflowBar example. Issue flutter#130459
@HansMuller HansMuller mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@TahaTesser TahaTesser TahaTesser approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TahaTesser TahaTesser

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthew-carroll @TahaTesser @goderbauer