Try to be more consistent about deleting test apps in devicelab logic. by Hixie · Pull Request #146856 · flutter/flutter

Hixie · 2024-04-17T00:00:45Z

Hixie · 2024-04-17T00:01:02Z

I barely understand some of these tests so I've no idea if this will actually work.

reidbaker · 2024-04-17T14:26:08Z

dev/devicelab/bin/tasks/drive_perf_debug_warning.dart

    '-d',
    deviceId,
  ]);
+  await evalFlutter('install', options: <String>['--uninstall-only', '-d', deviceId]);


I don't think this needs to be modified but one difference between this code and the uninstallApp code is that the uninstall app code pauses for 2 seconds then awaits the device to come back available (which can take a minute). This only matters on android because all other device types do nothing on awaitDevice.

yeah... i considered removing the two second await (it violates our style guide as it is likely to introduce flakes) but decided that it'd be best to do that in a separate PR.

…ab logic. (flutter/flutter#146856)

auto-submit · 2024-04-17T17:36:24Z

A reason for requesting a revert of flutter/flutter/146856 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

Hixie · 2024-04-17T17:39:16Z

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8750390039643020449/+/u/run_platform_channels_benchmarks_ios/stdout:

[2024-04-17 10:30:42.372870] [STDOUT] [STDOUT] [   +9 ms] Connected to iPhone 11
[2024-04-17 10:30:42.374585] [STDOUT] [STDOUT] [   +1 ms] Flutter run key commands.
[2024-04-17 10:30:42.375786] [STDOUT] [STDOUT] [   +1 ms] h List all available interactive commands.
[2024-04-17 10:30:42.376091] [STDOUT] [STDOUT] [        ] c Clear the screen
[2024-04-17 10:30:42.376296] [STDOUT] [STDOUT] [        ] q Quit (terminate the application on the device).
[2024-04-17 10:30:42.376988] [STDOUT] [STDOUT] [        ] A Dart VM Service on iPhone 11 is available at: http://127.0.0.1:63808/xctULuXnxwg=/
[2024-04-17 10:30:42.679493] [STDOUT] [STDOUT] [ +302 ms] The Flutter DevTools debugger and profiler on iPhone 11 is available at: http://127.0.0.1:9100/?uri=http://127.0.0.1:63808/xctULuXnxwg=/
[2024-04-17 10:30:42.782171] [STDOUT] [STDOUT] [ +102 ms] flutter: running platform_channel_basic_binary_2host_large
[2024-04-17 10:30:42.947009] [STDOUT] [STDOUT] [ +164 ms] flutter: running platform_channel_basic_binary_2host_1MB
[2024-04-17 10:30:43.368154] [STDOUT] [STDOUT] [ +421 ms] flutter: running platform_channel_basic_standard_2host_small_parallel_3
[2024-04-17 10:30:43.396336] [STDOUT] [STDOUT] [  +28 ms] flutter: running platform_channel_basic_standard_2hostbackground_small
[2024-04-17 10:30:43.555064] [STDOUT] [STDOUT] [ +158 ms] flutter: running platform_channel_basic_standard_2hostbackground_small_parallel_3
[2024-04-17 10:30:43.555105] [STDOUT] [STDOUT] [        ] flutter: ================ RESULTS ================
[2024-04-17 10:30:43.555163] [STDOUT] [STDOUT] [        ] flutter: :::JSON::: {"platform_channel_basic_standard_2host_small":48.124,"platform_channel_basic_standard_2host_large":559.9312,"platform_channel_basic_binary_2host_large":48.9912,"platform_channel_basic_binary_2host_1MB":180.6904,"platform_channel_basic_standard_2host_small_parallel_3":23.7716,"platform_channel_basic_standard_2hostbackground_small":49.8804,"platform_channel_basic_standard_2hostbackground_small_parallel_3":24.406}
[2024-04-17 10:30:43.555185] [STDOUT] [STDOUT] [        ] flutter: ================ FORMATTED ==============
[2024-04-17 10:30:43.567548] [STDOUT] [STDOUT] [  +12 ms] executing: xcrun osascript -l JavaScript /opt/s/w/ir/x/w/recipe_cleanup/tmpi4724x1x/flutter sdk/packages/flutter_tools/bin/xcode_debug.js stop --xcode-path /opt/flutter/xcode/15a240d/XCode.app --project-path /opt/s/w/ir/x/w/recipe_cleanup/tmpi4724x1x/flutter sdk/dev/benchmarks/platform_channels_benchmarks/ios/Runner.xcodeproj --workspace-path /opt/s/w/ir/x/w/recipe_cleanup/tmpi4724x1x/flutter sdk/dev/benchmarks/platform_channels_benchmarks/ios/Runner.xcworkspace --verbose
[2024-04-17 10:30:43.729136] [STDOUT] [STDOUT] [ +161 ms] {"status":true,"errorMessage":null,"debugResult":null}
[2024-04-17 10:30:43.729161] [STDOUT] [STDOUT] 
[2024-04-17 10:30:43.729170] [STDOUT] [STDOUT]            {"command":"stop","xcodePath":"/opt/flutter/xcode/15a240d/XCode.app","projectPath":"/opt/s/w/ir/x/w/recipe_cleanup/tmpi4724x1x/flutter sdk/dev/benchmarks/platform_channels_benchmarks/ios/Runner.xcodeproj","projectName":null,"expectedConfigurationBuildDir":null,"workspacePath":"/opt/s/w/ir/x/w/recipe_cleanup/tmpi4724x1x/flutter sdk/dev/benchmarks/platform_channels_benchmarks/ios/Runner.xcworkspace","targetDestinationId":null,"targetSchemeName":null,"skipBuilding":null,"launchArguments":null,"closeWindowOnStop":false,"promptToSaveBeforeClose":false,"verbose":true}
[2024-04-17 10:30:43.729612] [STDOUT] [STDOUT] [        ] Application finished.
[2024-04-17 10:30:43.733084] [STDOUT] [STDOUT] [   +3 ms] "flutter run" took 80,209ms.
[2024-04-17 10:30:43.736166] [STDOUT] [STDOUT] [   +3 ms] ensureAnalyticsSent: 0ms
[2024-04-17 10:30:43.736283] [STDOUT] [STDOUT] [        ] Running 3 shutdown hooks
[2024-04-17 10:30:43.737211] [STDOUT] [STDOUT] [        ] executing: killall -9 Xcode
[2024-04-17 10:30:43.761920] [STDOUT] [STDOUT] [  +24 ms] Service protocol connection closed.
[2024-04-17 10:30:43.771816] [STDOUT] [STDOUT] [   +9 ms] Shutdown hooks complete
[2024-04-17 10:30:43.771850] [STDOUT] [STDOUT] [        ] exiting with code 0
[2024-04-17 10:30:45.570843] [STDOUT] Executing "/opt/s/w/ir/x/w/recipe_cleanup/tmpi4724x1x/flutter sdk/bin/flutter install --device-timeout 5 --uninstall-only -d 00008030-001439910C2B402E --ci --debug-logs-dir=/opt/s/w/ir/x/w/recipe_cleanup/flutter_logs_dir" in "/opt/s/w/ir/x/w/recipe_cleanup/tmpi4724x1x/flutter sdk/dev/devicelab" with environment {BOT: true, LANG: en_US.UTF-8}
[2024-04-17 10:31:00.502915] [STDOUT] stderr: Could not find or build package
[2024-04-17 10:31:00.514635] [STDERR] Task failed: Executable "/opt/s/w/ir/x/w/recipe_cleanup/tmpi4724x1x/flutter sdk/bin/flutter" failed with exit code 1.
[2024-04-17 10:31:00.514701] [STDERR] 
[2024-04-17 10:31:00.514713] [STDERR] Stack trace:
[2024-04-17 10:31:00.540793] [STDERR] package:flutter_devicelab/framework/utils.dart 110:3       fail
[2024-04-17 10:31:00.540821] [STDERR] package:flutter_devicelab/framework/utils.dart 383:5       _execute
[2024-04-17 10:31:00.540832] [STDERR] ===== asynchronous gap ===========================
[2024-04-17 10:31:00.540842] [STDERR] dart:async                                                 _CustomZone.registerBinaryCallback
[2024-04-17 10:31:00.540854] [STDERR] package:flutter_devicelab/framework/framework.dart 278:26  _TaskRunner._performTask.<fn>
[2024-04-17 10:31:00.540864] [STDERR] package:stack_trace                                        Chain.capture
[2024-04-17 10:31:00.540873] [STDERR] package:flutter_devicelab/framework/framework.dart 277:11  _TaskRunner._performTask
[2024-04-17 10:31:00.540883] [STDERR] package:flutter_devicelab/framework/framework.dart 170:43  _TaskRunner.run
[2024-04-17 10:31:00.540893] [STDERR] 
[2024-04-17 10:31:00.541618] [STDOUT] Checking for reboot
[platform_channels_benchmarks_ios] Process terminated with exit code 0.
Task result:
{
  "success": false,
  "reason": "Task failed: Executable \"/opt/s/w/ir/x/w/recipe_cleanup/tmpi4724x1x/flutter sdk/bin/flutter\" failed with exit code 1."
}

Hixie · 2024-04-17T17:39:34Z

Reason for revert: breaking tree

…ab logic. (#146856)" This reverts commit 0301c8d.

…lab logic. (#146856)" (#146927) Reverts: #146856 Initiated by: Hixie Reason for reverting: breaking tree Original PR Author: Hixie Reviewed By: {reidbaker} This change reverts the following previous change: Fixes #137555.

Hixie · 2024-04-17T17:41:51Z

The two tests that failed were:

Linux_android platform_channels_benchmarks
Mac_ios platform_channels_benchmarks_ios

Hixie · 2024-04-17T17:42:36Z

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8750390036806287329/+/u/run_platform_channels_benchmarks/stdout:

[2024-04-17 10:32:19.438979] [STDOUT] [STDOUT] [ +130 ms] Connected to Moto G 4
[2024-04-17 10:32:19.441255] [STDOUT] [STDOUT] [   +2 ms] Flutter run key commands.
[2024-04-17 10:32:19.442838] [STDOUT] [STDOUT] [   +1 ms] h List all available interactive commands.
[2024-04-17 10:32:19.443163] [STDOUT] [STDOUT] [        ] c Clear the screen
[2024-04-17 10:32:19.443535] [STDOUT] [STDOUT] [        ] q Quit (terminate the application on the device).
[2024-04-17 10:32:19.444458] [STDOUT] [STDOUT] [        ] A Dart VM Service on Moto G 4 is available at: http://127.0.0.1:44535/8sd6tZrUCaE=/
[2024-04-17 10:32:19.547206] [STDOUT] [STDOUT] [ +102 ms] The Flutter DevTools debugger and profiler on Moto G 4 is available at: http://127.0.0.1:9100/?uri=http://127.0.0.1:44535/8sd6tZrUCaE=/
[2024-04-17 10:32:20.097077] [STDOUT] [STDOUT] [ +549 ms] I/flutter (12367): running platform_channel_basic_standard_2host_large
[2024-04-17 10:32:45.300823] [STDOUT] [STDOUT] [+25203 ms] I/flutter (12367): running platform_channel_basic_binary_2host_large
[2024-04-17 10:32:48.109319] [STDOUT] [STDOUT] [+2808 ms] I/flutter (12367): running platform_channel_basic_binary_2host_1MB
[2024-04-17 10:33:02.606903] [STDOUT] [STDOUT] [+14497 ms] I/flutter (12367): running platform_channel_basic_standard_2host_small_parallel_3
[2024-04-17 10:33:03.245352] [STDOUT] [STDOUT] [ +638 ms] I/flutter (12367): running platform_channel_basic_standard_2hostbackground_small
[2024-04-17 10:33:05.204039] [STDOUT] [STDOUT] [+1958 ms] I/flutter (12367): running platform_channel_basic_standard_2hostbackground_small_parallel_3
[2024-04-17 10:33:05.935340] [STDOUT] [STDOUT] [ +731 ms] I/flutter (12367): ================ RESULTS ================
[2024-04-17 10:33:05.939220] [STDOUT] [STDOUT] [   +3 ms] I/flutter (12367): :::JSON::: {"platform_channel_basic_standard_2host_small":460.904,"platform_channel_basic_standard_2host_large":10078.3084,"platform_channel_basic_binary_2host_large":1122.0668,"platform_channel_basic_binary_2host_1MB":5795.018,"platform_channel_basic_standard_2host_small_parallel_3":254.6048,"platform_channel_basic_standard_2hostbackground_small":783.806,"platform_channel_basic_standard_2hostbackground_small_parallel_3":291.13}
[2024-04-17 10:33:05.939283] [STDOUT] [STDOUT] [        ] I/flutter (12367): ================ FORMATTED ==============
[2024-04-17 10:33:05.942283] [STDOUT] [STDOUT] [        ] I/flutter (12367): BasicMessageChannel/StandardMessageCodec/Flutter->Host/Small: 460.9 µs
[2024-04-17 10:33:05.942325] [STDOUT] [STDOUT] [        ] I/flutter (12367): BasicMessageChannel/StandardMessageCodec/Flutter->Host/Large: 10078.3 µs
[2024-04-17 10:33:05.942342] [STDOUT] [STDOUT] [        ] I/flutter (12367): BasicMessageChannel/BinaryCodec/Flutter->Host/Large: 1122.1 µs
[2024-04-17 10:33:05.942360] [STDOUT] [STDOUT] [        ] I/flutter (12367): BasicMessageChannel/BinaryCodec/Flutter->Host/1MB: 5795.0 µs
[2024-04-17 10:33:05.943050] [STDOUT] [STDOUT] [        ] I/flutter (12367): BasicMessageChannel/StandardMessageCodec/Flutter->Host/SmallParallel3: 254.6 µs
[2024-04-17 10:33:05.943087] [STDOUT] [STDOUT] [        ] I/flutter (12367): BasicMessageChannel/StandardMessageCodec/Flutter->Host (background)/Small: 783.8 µs
[2024-04-17 10:33:05.943103] [STDOUT] [STDOUT] [        ] I/flutter (12367): BasicMessageChannel/StandardMessageCodec/Flutter->Host (background)/SmallParallel3: 291.1 µs
[2024-04-17 10:33:05.945498] [STDOUT] [STDOUT] [   +5 ms] executing: /opt/s/w/ir/cache/android/sdk/platform-tools/adb -s ZY223CL8VK shell am force-stop com.example.platform_channels_benchmarks
[2024-04-17 10:33:06.896648] [STDOUT] [STDOUT] [ +951 ms] Service protocol connection closed.
[2024-04-17 10:33:06.915553] [STDOUT] [STDOUT] [  +19 ms] Application finished.
[2024-04-17 10:33:06.919745] [STDOUT] [STDOUT] [   +4 ms] "flutter run" took 67,403ms.
[2024-04-17 10:33:06.922038] [STDOUT] [STDOUT] [   +2 ms] ensureAnalyticsSent: 0ms
[2024-04-17 10:33:06.922072] [STDOUT] [STDOUT] [        ] Running 2 shutdown hooks
[2024-04-17 10:33:06.922663] [STDOUT] [STDOUT] [        ] Shutdown hooks complete
[2024-04-17 10:33:06.923019] [STDOUT] [STDOUT] [        ] exiting with code 0
[2024-04-17 10:33:07.953311] [STDOUT] Executing "/opt/s/w/ir/x/w/recipe_cleanup/tmpux7x2sc2/flutter sdk/bin/flutter install --uninstall-only -d ZY223CL8VK --ci --debug-logs-dir=/opt/s/w/ir/x/w/recipe_cleanup/flutter_logs_dir" in "/opt/s/w/ir/x/w/recipe_cleanup/tmpux7x2sc2/flutter sdk/dev/devicelab" with environment {BOT: true, LANG: en_US.UTF-8}
[2024-04-17 10:33:08.298352] [STDOUT] stderr: AndroidManifest.xml could not be found.
[2024-04-17 10:33:08.298407] [STDOUT] stderr: Please check /opt/s/w/ir/x/w/recipe_cleanup/tmpux7x2sc2/flutter sdk/dev/devicelab/android/AndroidManifest.xml for errors.
[2024-04-17 10:33:08.310998] [STDOUT] stderr: Could not find or build package
[2024-04-17 10:33:08.319266] [STDERR] Task failed: Executable "/opt/s/w/ir/x/w/recipe_cleanup/tmpux7x2sc2/flutter sdk/bin/flutter" failed with exit code 1.
[2024-04-17 10:33:08.319297] [STDERR] 
[2024-04-17 10:33:08.319305] [STDERR] Stack trace:
[2024-04-17 10:33:08.335434] [STDERR] package:flutter_devicelab/framework/utils.dart 110:3       fail
[2024-04-17 10:33:08.335469] [STDERR] package:flutter_devicelab/framework/utils.dart 383:5       _execute
[2024-04-17 10:33:08.335483] [STDERR] ===== asynchronous gap ===========================
[2024-04-17 10:33:08.335495] [STDERR] dart:async                                                 _CustomZone.registerBinaryCallback
[2024-04-17 10:33:08.335513] [STDERR] package:flutter_devicelab/framework/framework.dart 278:26  _TaskRunner._performTask.<fn>
[2024-04-17 10:33:08.335525] [STDERR] package:stack_trace                                        Chain.capture
[2024-04-17 10:33:08.335538] [STDERR] package:flutter_devicelab/framework/framework.dart 277:11  _TaskRunner._performTask
[2024-04-17 10:33:08.335551] [STDERR] package:flutter_devicelab/framework/framework.dart 170:43  _TaskRunner.run
[2024-04-17 10:33:08.335564] [STDERR] 
[2024-04-17 10:33:08.338683] [STDOUT] Checking for reboot
[platform_channels_benchmarks] Process terminated with exit code 0.
Task result:
{
  "success": false,
  "reason": "Task failed: Executable \"/opt/s/w/ir/x/w/recipe_cleanup/tmpux7x2sc2/flutter sdk/bin/flutter\" failed with exit code 1."
}

…ab logic. (flutter/flutter#146856)

Hixie · 2024-04-17T17:48:48Z

Oh I see, I called uninstallApp in the wrong directory.

flutter#146856) Fixes flutter#137555.

…#146931) Fixes #137555. This is an updated version of #146856, which was reverted in #146927. The first commit is identical to the original PR, and subsequent commits are the fixes to address failures detected in devicelab post-commit.

…lab logic (#146931)" (#146947) Reverts: #146931 Initiated by: Hixie Reason for reverting: more failures Original PR Author: Hixie Reviewed By: {reidbaker} This change reverts the following previous change: Fixes #137555. This is an updated version of #146856, which was reverted in #146927. The first commit is identical to the original PR, and subsequent commits are the fixes to address failures detected in devicelab post-commit.

…ab logic. (flutter/flutter#146856)

@main

Roll Flutter from 3882afb to fb110b9 (56 revisions) flutter/flutter@3882afb...fb110b9 2024-04-18 [email protected] Fix memory leaks in `MaterialBanner` (flutter/flutter#146963) 2024-04-18 [email protected] Fix memory leak in data table (flutter/flutter#146892) 2024-04-18 [email protected] Dispose the curved animation in transition test (flutter/flutter#146961) 2024-04-18 [email protected] Roll Flutter Engine from 5687011d5e94 to 2c3e9c8bfce6 (1 revision) (flutter/flutter#146982) 2024-04-18 [email protected] Roll Flutter Engine from 132d364ef373 to 5687011d5e94 (2 revisions) (flutter/flutter#146972) 2024-04-18 [email protected] Roll Flutter Engine from 20638b75c8c4 to 132d364ef373 (1 revision) (flutter/flutter#146969) 2024-04-18 [email protected] [macOS] Migrate @NSApplicationMain attribute to @main (flutter/flutter#146848) 2024-04-18 [email protected] Roll Flutter Engine from 07f7532ecd29 to 20638b75c8c4 (2 revisions) (flutter/flutter#146962) 2024-04-18 [email protected] Roll Flutter Engine from 725ebd708246 to 07f7532ecd29 (1 revision) (flutter/flutter#146960) 2024-04-18 [email protected] Roll Flutter Engine from 624730fb8840 to 725ebd708246 (4 revisions) (flutter/flutter#146959) 2024-04-17 [email protected] Roll Flutter Engine from 9edcb26f5949 to 624730fb8840 (2 revisions) (flutter/flutter#146955) 2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/flutter#146953) 2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.3 to 6.0.4 (flutter/flutter#146954) 2024-04-17 [email protected] Roll Flutter Engine from cc73c5c124c4 to 9edcb26f5949 (4 revisions) (flutter/flutter#146946) 2024-04-17 [email protected] Bump meta to 1.14.0 (flutter/flutter#146925) 2024-04-17 [email protected] Make goldenFileComparator a field instead of a trivial property (flutter/flutter#146800) 2024-04-17 [email protected] Assert that the goldenFileComparator is a LocalFileComparator (flutter/flutter#146802) 2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Try to be more consistent about deleting test apps in devicelab logic (#146931)" (flutter/flutter#146947) 2024-04-17 [email protected] Create web tests suite & runner_utils (flutter/flutter#146592) 2024-04-17 [email protected] Roll Flutter Engine from 376c86e3bbb6 to cc73c5c124c4 (3 revisions) (flutter/flutter#146940) 2024-04-17 [email protected] Try to be more consistent about deleting test apps in devicelab logic (flutter/flutter#146931) 2024-04-17 [email protected] Roll Flutter Engine from bc6382e35365 to 376c86e3bbb6 (2 revisions) (flutter/flutter#146937) 2024-04-17 [email protected] Remove now-redundant tests for isForEnvironment (flutter/flutter#146804) 2024-04-17 [email protected] Roll pub packages (flutter/flutter#146929) 2024-04-17 [email protected] Get rid of _NullElement. (flutter/flutter#146741) 2024-04-17 [email protected] Roll Flutter Engine from 818191d11404 to bc6382e35365 (2 revisions) (flutter/flutter#146930) 2024-04-17 [email protected] Fix memory leak in paginated tables (flutter/flutter#146755) 2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Try to be more consistent about deleting test apps in devicelab logic. (#146856)" (flutter/flutter#146927) 2024-04-17 [email protected] Roll Flutter Engine from 25b09e883dd8 to 818191d11404 (3 revisions) (flutter/flutter#146898) 2024-04-17 [email protected] Try to be more consistent about deleting test apps in devicelab logic. (flutter/flutter#146856) 2024-04-17 [email protected] Unpin frontend_server_client and roll packages (flutter/flutter#146650) 2024-04-17 [email protected] Roll Packages from 90c876d to d39830e (4 revisions) (flutter/flutter#146895) 2024-04-17 [email protected] Roll Flutter Engine from 0e9e2f419225 to 25b09e883dd8 (1 revision) (flutter/flutter#146889) 2024-04-17 [email protected] Reland: Update link branches to `main` (flutter/flutter#146882) 2024-04-17 [email protected] Roll Flutter Engine from 4b949d7d6065 to 0e9e2f419225 (4 revisions) (flutter/flutter#146884) 2024-04-17 [email protected] Revert "Update link branches to `main`" (flutter/flutter#146880) 2024-04-17 [email protected] Fix `Tab` indicator image configuration doesn't inherit device pixel ratio (flutter/flutter#146812) 2024-04-17 [email protected] Roll Flutter Engine from 1ea39b29ce8c to 4b949d7d6065 (1 revision) (flutter/flutter#146865) 2024-04-17 [email protected] Update link branches to `main` (flutter/flutter#146558) 2024-04-17 [email protected] Roll Flutter Engine from 45c86593a09a to 1ea39b29ce8c (1 revision) (flutter/flutter#146863) 2024-04-17 [email protected] Rewrap some lines that are about to get much longer. (flutter/flutter#146803) 2024-04-17 [email protected] Roll Flutter Engine from 0cdbc8a6e463 to 45c86593a09a (1 revision) (flutter/flutter#146862) 2024-04-17 [email protected] Roll Flutter Engine from 31b67985de27 to 0cdbc8a6e463 (1 revision) (flutter/flutter#146861) 2024-04-17 [email protected] Roll Flutter Engine from e7d8c62d291a to 31b67985de27 (1 revision) (flutter/flutter#146859) 2024-04-17 [email protected] Roll Flutter Engine from 4d69c0c95483 to e7d8c62d291a (11 revisions) (flutter/flutter#146857) 2024-04-16 [email protected] Switch to relevant `Remote` constructors (flutter/flutter#146773) ...

flutter#146856) Fixes flutter#137555.

…lab logic. (flutter#146856)" (flutter#146927) Reverts: flutter#146856 Initiated by: Hixie Reason for reverting: breaking tree Original PR Author: Hixie Reviewed By: {reidbaker} This change reverts the following previous change: Fixes flutter#137555.

…flutter#146931) Fixes flutter#137555. This is an updated version of flutter#146856, which was reverted in flutter#146927. The first commit is identical to the original PR, and subsequent commits are the fixes to address failures detected in devicelab post-commit.

…lab logic (flutter#146931)" (flutter#146947) Reverts: flutter#146931 Initiated by: Hixie Reason for reverting: more failures Original PR Author: Hixie Reviewed By: {reidbaker} This change reverts the following previous change: Fixes flutter#137555. This is an updated version of flutter#146856, which was reverted in flutter#146927. The first commit is identical to the original PR, and subsequent commits are the fixes to address failures detected in devicelab post-commit.

flutter#146856) Fixes flutter#137555.

@main

Roll Flutter from 3882afb to fb110b9 (56 revisions) flutter/flutter@3882afb...fb110b9 2024-04-18 [email protected] Fix memory leaks in `MaterialBanner` (flutter/flutter#146963) 2024-04-18 [email protected] Fix memory leak in data table (flutter/flutter#146892) 2024-04-18 [email protected] Dispose the curved animation in transition test (flutter/flutter#146961) 2024-04-18 [email protected] Roll Flutter Engine from 5687011d5e94 to 2c3e9c8bfce6 (1 revision) (flutter/flutter#146982) 2024-04-18 [email protected] Roll Flutter Engine from 132d364ef373 to 5687011d5e94 (2 revisions) (flutter/flutter#146972) 2024-04-18 [email protected] Roll Flutter Engine from 20638b75c8c4 to 132d364ef373 (1 revision) (flutter/flutter#146969) 2024-04-18 [email protected] [macOS] Migrate @NSApplicationMain attribute to @main (flutter/flutter#146848) 2024-04-18 [email protected] Roll Flutter Engine from 07f7532ecd29 to 20638b75c8c4 (2 revisions) (flutter/flutter#146962) 2024-04-18 [email protected] Roll Flutter Engine from 725ebd708246 to 07f7532ecd29 (1 revision) (flutter/flutter#146960) 2024-04-18 [email protected] Roll Flutter Engine from 624730fb8840 to 725ebd708246 (4 revisions) (flutter/flutter#146959) 2024-04-17 [email protected] Roll Flutter Engine from 9edcb26f5949 to 624730fb8840 (2 revisions) (flutter/flutter#146955) 2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.0 to 3.25.1 (flutter/flutter#146953) 2024-04-17 49699333+dependabot[bot]@users.noreply.github.com Bump peter-evans/create-pull-request from 6.0.3 to 6.0.4 (flutter/flutter#146954) 2024-04-17 [email protected] Roll Flutter Engine from cc73c5c124c4 to 9edcb26f5949 (4 revisions) (flutter/flutter#146946) 2024-04-17 [email protected] Bump meta to 1.14.0 (flutter/flutter#146925) 2024-04-17 [email protected] Make goldenFileComparator a field instead of a trivial property (flutter/flutter#146800) 2024-04-17 [email protected] Assert that the goldenFileComparator is a LocalFileComparator (flutter/flutter#146802) 2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Try to be more consistent about deleting test apps in devicelab logic (#146931)" (flutter/flutter#146947) 2024-04-17 [email protected] Create web tests suite & runner_utils (flutter/flutter#146592) 2024-04-17 [email protected] Roll Flutter Engine from 376c86e3bbb6 to cc73c5c124c4 (3 revisions) (flutter/flutter#146940) 2024-04-17 [email protected] Try to be more consistent about deleting test apps in devicelab logic (flutter/flutter#146931) 2024-04-17 [email protected] Roll Flutter Engine from bc6382e35365 to 376c86e3bbb6 (2 revisions) (flutter/flutter#146937) 2024-04-17 [email protected] Remove now-redundant tests for isForEnvironment (flutter/flutter#146804) 2024-04-17 [email protected] Roll pub packages (flutter/flutter#146929) 2024-04-17 [email protected] Get rid of _NullElement. (flutter/flutter#146741) 2024-04-17 [email protected] Roll Flutter Engine from 818191d11404 to bc6382e35365 (2 revisions) (flutter/flutter#146930) 2024-04-17 [email protected] Fix memory leak in paginated tables (flutter/flutter#146755) 2024-04-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Try to be more consistent about deleting test apps in devicelab logic. (#146856)" (flutter/flutter#146927) 2024-04-17 [email protected] Roll Flutter Engine from 25b09e883dd8 to 818191d11404 (3 revisions) (flutter/flutter#146898) 2024-04-17 [email protected] Try to be more consistent about deleting test apps in devicelab logic. (flutter/flutter#146856) 2024-04-17 [email protected] Unpin frontend_server_client and roll packages (flutter/flutter#146650) 2024-04-17 [email protected] Roll Packages from 90c876d to d39830e (4 revisions) (flutter/flutter#146895) 2024-04-17 [email protected] Roll Flutter Engine from 0e9e2f419225 to 25b09e883dd8 (1 revision) (flutter/flutter#146889) 2024-04-17 [email protected] Reland: Update link branches to `main` (flutter/flutter#146882) 2024-04-17 [email protected] Roll Flutter Engine from 4b949d7d6065 to 0e9e2f419225 (4 revisions) (flutter/flutter#146884) 2024-04-17 [email protected] Revert "Update link branches to `main`" (flutter/flutter#146880) 2024-04-17 [email protected] Fix `Tab` indicator image configuration doesn't inherit device pixel ratio (flutter/flutter#146812) 2024-04-17 [email protected] Roll Flutter Engine from 1ea39b29ce8c to 4b949d7d6065 (1 revision) (flutter/flutter#146865) 2024-04-17 [email protected] Update link branches to `main` (flutter/flutter#146558) 2024-04-17 [email protected] Roll Flutter Engine from 45c86593a09a to 1ea39b29ce8c (1 revision) (flutter/flutter#146863) 2024-04-17 [email protected] Rewrap some lines that are about to get much longer. (flutter/flutter#146803) 2024-04-17 [email protected] Roll Flutter Engine from 0cdbc8a6e463 to 45c86593a09a (1 revision) (flutter/flutter#146862) 2024-04-17 [email protected] Roll Flutter Engine from 31b67985de27 to 0cdbc8a6e463 (1 revision) (flutter/flutter#146861) 2024-04-17 [email protected] Roll Flutter Engine from e7d8c62d291a to 31b67985de27 (1 revision) (flutter/flutter#146859) 2024-04-17 [email protected] Roll Flutter Engine from 4d69c0c95483 to e7d8c62d291a (11 revisions) (flutter/flutter#146857) 2024-04-16 [email protected] Switch to relevant `Remote` constructors (flutter/flutter#146773) ...

github-actions bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: routes Navigator, Router, and related APIs. labels Apr 17, 2024

Hixie mentioned this pull request Apr 17, 2024

Android/iOS tests not cleaning up applications after test #137555

Closed

Try to be more consistent about deleting test apps in devicelab logic.

48cce7a

Hixie force-pushed the delete_packages branch from 80ff347 to 48cce7a Compare April 17, 2024 05:43

reidbaker requested review from godofredoc and reidbaker April 17, 2024 14:14

reidbaker approved these changes Apr 17, 2024

View reviewed changes

Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 17, 2024

auto-submit bot merged commit 0301c8d into flutter:master Apr 17, 2024

engine-flutter-autoroll mentioned this pull request Apr 17, 2024

Roll Flutter from 3882afbfa997 to 0301c8dfa41e (27 revisions) flutter/packages#6559

Closed

Hixie deleted the delete_packages branch April 17, 2024 17:22

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024

0301c8d Try to be more consistent about deleting test apps in devicel…

f875d8f

…ab logic. (flutter/flutter#146856)

Hixie added the revert Autorevert PR (with "Reason for revert:" comment) label Apr 17, 2024

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Apr 17, 2024

Hixie added the revert Autorevert PR (with "Reason for revert:" comment) label Apr 17, 2024

auto-submit bot pushed a commit that referenced this pull request Apr 17, 2024

Revert "Try to be more consistent about deleting test apps in devicel…

8992e8f

…ab logic. (#146856)" This reverts commit 0301c8d.

auto-submit bot mentioned this pull request Apr 17, 2024

Reverts "Try to be more consistent about deleting test apps in devicelab logic. (#146856)" #146927

Merged

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Apr 17, 2024

engine-flutter-autoroll mentioned this pull request Apr 17, 2024

Roll Flutter from 3882afbfa997 to f8c3e52776ae (29 revisions) flutter/packages#6560

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 17, 2024

0301c8d Try to be more consistent about deleting test apps in devicel…

b1b9742

…ab logic. (flutter/flutter#146856)

Hixie added a commit to Hixie/flutter that referenced this pull request Apr 17, 2024

Try to be more consistent about deleting test apps in devicelab logic. (

9a119db

flutter#146856) Fixes flutter#137555.

Hixie mentioned this pull request Apr 17, 2024

Try to be more consistent about deleting test apps in devicelab logic #146931

Merged

auto-submit bot mentioned this pull request Apr 17, 2024

Reverts "Try to be more consistent about deleting test apps in devicelab logic (#146931)" #146947

Merged

Hixie mentioned this pull request Apr 17, 2024

Try to be more consistent about deleting test apps in devicelab logic #146952

Closed

engine-flutter-autoroll mentioned this pull request Apr 18, 2024

Roll Flutter from 3882afbfa997 to fb110b98da15 (56 revisions) flutter/packages#6565

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2024

0301c8d Try to be more consistent about deleting test apps in devicel…

9787f12

…ab logic. (flutter/flutter#146856)

engine-flutter-autoroll mentioned this pull request Apr 18, 2024

Manual roll Flutter from 3882afbfa997 to c219bf73fce4 (61 revisions) flutter/packages#6566

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 18, 2024

0301c8d Try to be more consistent about deleting test apps in devicel…

18ecf2f

…ab logic. (flutter/flutter#146856)

gilnobrega pushed a commit to gilnobrega/flutter that referenced this pull request Apr 22, 2024

Try to be more consistent about deleting test apps in devicelab logic. (

ddee6be

flutter#146856) Fixes flutter#137555.

Hixie added a commit to Hixie/flutter that referenced this pull request May 9, 2024

Try to be more consistent about deleting test apps in devicelab logic. (

d0a2f12

flutter#146856) Fixes flutter#137555.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try to be more consistent about deleting test apps in devicelab logic.#146856

Try to be more consistent about deleting test apps in devicelab logic.#146856
auto-submit[bot] merged 1 commit intoflutter:masterfrom
Hixie:delete_packages

Hixie commented Apr 17, 2024

Uh oh!

Hixie commented Apr 17, 2024

Uh oh!

reidbaker Apr 17, 2024

Uh oh!

Hixie Apr 17, 2024 •

edited

Loading

Uh oh!

auto-submit bot commented Apr 17, 2024

Uh oh!

Hixie commented Apr 17, 2024

Uh oh!

Hixie commented Apr 17, 2024

Uh oh!

Hixie commented Apr 17, 2024

Uh oh!

Hixie commented Apr 17, 2024

Uh oh!

Hixie commented Apr 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Hixie commented Apr 17, 2024

Uh oh!

Hixie commented Apr 17, 2024

Uh oh!

reidbaker Apr 17, 2024

Choose a reason for hiding this comment

Uh oh!

Hixie Apr 17, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Apr 17, 2024

Uh oh!

Hixie commented Apr 17, 2024

Uh oh!

Hixie commented Apr 17, 2024

Uh oh!

Hixie commented Apr 17, 2024

Uh oh!

Hixie commented Apr 17, 2024

Uh oh!

Hixie commented Apr 17, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Hixie Apr 17, 2024 •

edited

Loading