Add create app and plugin templates for Swift Package Manager by vashworth · Pull Request #147082 · flutter/flutter

vashworth · 2024-04-19T19:12:53Z

When Swift Package Manager feature is enabled, create app and create plugin will have Swift Package Manager integration already added and will not need to undergo a migration.

Fixes #146371.

flutter config --enable-swift-package-manager

flutter create --ios-language swift --platforms ios,macos swift_app_name

flutter create --ios-language objc --platforms ios objc_app_name

flutter create --template=plugin --ios-language swift --platforms ios,macos swift_plugin_name

flutter create --template=plugin --ios-language objc --platforms ios objc_plugin_name

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

… windows

vashworth · 2024-04-22T15:20:30Z

fyi @loic-sharma

vashworth · 2024-04-22T15:22:26Z

packages/flutter_tools/templates/app_shared/ios-objc.tmpl/RunnerTests/RunnerTests.m.tmpl

+{{#withSwiftPackageManager}}
+// If your plugin has been explicitly set to "type: .dynamic" in the Package.swift,
+// you will need to add your plugin as a dependency of RunnerTests within Xcode.
+{{/withSwiftPackageManager}}


@stuartmorgan This is where you were thinking I include the message, right?

Yep, perfect!

packages/flutter_tools/lib/src/commands/create.dart

jmagman · 2024-04-22T19:17:25Z

...templates/app_shared/macos.tmpl/Runner.xcodeproj/xcshareddata/xcschemes/Runner.xcscheme.tmpl

   <BuildAction
      parallelizeBuildables = "YES"
      buildImplicitDependencies = "YES">
+      {{#withSwiftPackageManager}}


Maybe we should always add the pre-actions? Does it hurt anything if it's not using SPM? I don't think it would add much time (because the next time it runs in the build phases it will be almost a no-op based on the target inputs and outputs). The less we can avoid fragmentation the better imo.

So it's not exactly a no-op, the pre-action unfortunately does not pass the EXPANDED_CODE_SIGN_IDENTITY build setting so the input is considered changed because the codesigning changes. So it does add a little bit of time (~4 seconds)

jmagman

Doesn't have to be in this PR, but consider adding tests to:
https://github.com/flutter/flutter/blob/master/dev/devicelab/bin/tasks/plugin_test_ios.dart

LGTM!

packages/flutter_tools/lib/src/template.dart

stuartmorgan-g

Template changes LGTM.

(I am slightly worried about people publishing things with this template and then us discovering we need to change something, but since the whole thing is behind a flag we can probably expect there won't be too much of that and we can follow up with individual plugin authors.)

stuartmorgan-g · 2024-04-24T14:49:58Z

packages/flutter_tools/templates/app_shared/ios-objc.tmpl/RunnerTests/RunnerTests.m.tmpl

+{{#withSwiftPackageManager}}
+// If your plugin has been explicitly set to "type: .dynamic" in the Package.swift,
+// you will need to add your plugin as a dependency of RunnerTests within Xcode.
+{{/withSwiftPackageManager}}


Yep, perfect!

…flutter/flutter#147082)

flutter/flutter@dba4f77...5d3bca4 2024-04-25 [email protected] Roll Flutter Engine from 6b33890a4701 to 674890ce7141 (1 revision) (flutter/flutter#147365) 2024-04-25 [email protected] [native_assets] Use kernel concatenation (flutter/flutter#147158) 2024-04-25 [email protected] Roll Flutter Engine from ccd57f5a4bc4 to 6b33890a4701 (2 revisions) (flutter/flutter#147359) 2024-04-25 [email protected] Roll Flutter Engine from 9de649ed2926 to ccd57f5a4bc4 (1 revision) (flutter/flutter#147356) 2024-04-25 [email protected] Roll Flutter Engine from 2f48456a425a to 9de649ed2926 (2 revisions) (flutter/flutter#147354) 2024-04-25 [email protected] Roll Flutter Engine from f48f3b6a0172 to 2f48456a425a (1 revision) (flutter/flutter#147351) 2024-04-25 [email protected] Roll Flutter Engine from b30c0a765680 to f48f3b6a0172 (8 revisions) (flutter/flutter#147348) 2024-04-25 [email protected] Allow the SceneBuilder, PictureRecord, and Canvas constructor calls from the rendering layer to be hooked (flutter/flutter#147271) 2024-04-24 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.3 to 4.1.4 (flutter/flutter#147334) 2024-04-24 [email protected] Fix filled color is wrong for a focused and hovered TextField (flutter/flutter#146976) 2024-04-24 [email protected] Roll Flutter Engine from b5d5832f7144 to b30c0a765680 (14 revisions) (flutter/flutter#147336) 2024-04-24 [email protected] Run new_gallery__transition_perf on mokey in staging (flutter/flutter#147339) 2024-04-24 [email protected] Remove hidden dependencies on the default goldenFileComparator. (flutter/flutter#146956) 2024-04-24 [email protected] Add create app and plugin templates for Swift Package Manager (flutter/flutter#147082) 2024-04-24 [email protected] Add support for overriding `reverseCurve` with `ExpansionTile.expansionAnimationStyle` (flutter/flutter#147103) 2024-04-24 [email protected] Mark firebase tests as `bringup: true` (flutter/flutter#147338) 2024-04-24 [email protected] Add Valentin Vignal to AUTHORS (flutter/flutter#147314) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…flutter/flutter#147082)

vashworth added 4 commits April 11, 2024 16:46

Add create app and plugin templates for Swift Package Manager

139c3ca

add some tests, fix some formatting

a5eb0ed

Merge remote-tracking branch 'upstream/master' into spm_create_templates

b27609c

fix xcscheme template and add more tests

800ba88

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Apr 19, 2024

make swift tools version and supported platform dynamic in templates

3a2a222

github-actions bot added the a: desktop Running on desktop label Apr 19, 2024

use filesystem to get path rather than string to make compatible with…

e15d167

… windows

vashworth marked this pull request as ready for review April 22, 2024 15:20

vashworth requested a review from jmagman April 22, 2024 15:20

vashworth requested a review from stuartmorgan-g April 22, 2024 15:21

vashworth commented Apr 22, 2024

View reviewed changes

jmagman reviewed Apr 22, 2024

View reviewed changes

vashworth added 3 commits April 23, 2024 10:37

Move CocoaPod specific files to it's own template directory

f4bc4e6

fix test

5f1fcd4

Merge remote-tracking branch 'upstream/master' into spm_create_templates

3b7e3e0

jmagman approved these changes Apr 23, 2024

View reviewed changes

packages/flutter_tools/lib/src/template.dart Outdated Show resolved Hide resolved

remove unused parameter

8a74113

stuartmorgan-g approved these changes Apr 24, 2024

View reviewed changes

vashworth added the autosubmit Merge PR when tree becomes green via auto submit App label Apr 24, 2024

auto-submit bot merged commit 5a63b1d into flutter:master Apr 24, 2024

engine-flutter-autoroll mentioned this pull request Apr 25, 2024

Roll Flutter from dba4f7747441 to 5d3bca4500b1 (17 revisions) flutter/packages#6612

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Apr 25, 2024

5a63b1d Add create app and plugin templates for Swift Package Manager (…

35cbc92

…flutter/flutter#147082)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

5a63b1d Add create app and plugin templates for Swift Package Manager (…

ab804fd

…flutter/flutter#147082)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add create app and plugin templates for Swift Package Manager#147082

Add create app and plugin templates for Swift Package Manager#147082
auto-submit[bot] merged 10 commits intoflutter:masterfrom
vashworth:spm_create_templates

vashworth commented Apr 19, 2024 •

edited

Loading

Uh oh!

vashworth commented Apr 22, 2024

Uh oh!

vashworth Apr 22, 2024

Uh oh!

stuartmorgan-g Apr 24, 2024

Uh oh!

Uh oh!

jmagman Apr 22, 2024

Uh oh!

vashworth Apr 23, 2024

Uh oh!

jmagman left a comment

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Uh oh!

stuartmorgan-g Apr 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

vashworth commented Apr 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

vashworth commented Apr 22, 2024

Uh oh!

vashworth Apr 22, 2024

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 24, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jmagman Apr 22, 2024

Choose a reason for hiding this comment

Uh oh!

vashworth Apr 23, 2024

Choose a reason for hiding this comment

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Apr 24, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vashworth commented Apr 19, 2024 •

edited

Loading