fix DropdownMenu overflow by PurplePolyhedron · Pull Request #147233 · flutter/flutter

PurplePolyhedron · 2024-04-23T12:13:15Z

fix DropdownMenu overflow issue in #147076 and #147173
However I believe the the menu placement issue in #147076 is a separate issue. It is not fixed here.

fixes #147173

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

bleroux

Thanks for this PR!
Just some minor comments to address.

packages/flutter/test/material/dropdown_menu_test.dart

QuncCccccc

LGTM! Thanks a lot for the fix!

Piinks

auto-submit · 2024-05-01T20:57:41Z

auto label is removed for flutter/flutter/147233, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

Roll Flutter from d33bb8f to bf7191f (34 revisions) flutter/flutter@d33bb8f...bf7191f 2024-05-02 [email protected] Roll Flutter Engine from b989d239e281 to 1fb36ac9d718 (2 revisions) (flutter/flutter#147713) 2024-05-02 [email protected] Roll Flutter Engine from 3c9c2ce8369e to b989d239e281 (1 revision) (flutter/flutter#147711) 2024-05-02 [email protected] Roll Flutter Engine from 58b031c096ea to 3c9c2ce8369e (2 revisions) (flutter/flutter#147703) 2024-05-02 [email protected] Roll Flutter Engine from fc28057dbd4d to 58b031c096ea (1 revision) (flutter/flutter#147701) 2024-05-02 [email protected] Roll Flutter Engine from bfc6787eedc3 to fc28057dbd4d (1 revision) (flutter/flutter#147700) 2024-05-02 [email protected] Roll Flutter Engine from 7cbef71f4f54 to bfc6787eedc3 (1 revision) (flutter/flutter#147699) 2024-05-02 [email protected] Roll Flutter Engine from 90ce9e5959fc to 7cbef71f4f54 (1 revision) (flutter/flutter#147696) 2024-05-02 [email protected] Roll Flutter Engine from 78dced50c467 to 90ce9e5959fc (1 revision) (flutter/flutter#147695) 2024-05-02 [email protected] add verbose logging to select hot reload/hot restart tests (flutter/flutter#147673) 2024-05-02 [email protected] Roll Flutter Engine from 3087ec1adddd to 78dced50c467 (3 revisions) (flutter/flutter#147693) 2024-05-02 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Implement computeDryBaseline for `RenderWrap` (#146260)" (flutter/flutter#147692) 2024-05-02 [email protected] Roll Flutter Engine from f56c20c6ac67 to 3087ec1adddd (2 revisions) (flutter/flutter#147688) 2024-05-02 [email protected] Allow explicit exclusion of packages from pinned packages in `flutter update-packages --force-update` (flutter/flutter#147679) 2024-05-02 [email protected] Implement getDryBaseline for Stack and Overlay (flutter/flutter#146253) 2024-05-02 [email protected] Roll Flutter Engine from 2d73fa207927 to f56c20c6ac67 (2 revisions) (flutter/flutter#147681) 2024-05-02 [email protected] Update selectable_text_test.dart (flutter/flutter#147677) 2024-05-01 [email protected] Roll Flutter Engine from c536a14052e5 to 2d73fa207927 (2 revisions) (flutter/flutter#147678) 2024-05-01 [email protected] Implement computeDryBaseline for `RenderWrap` (flutter/flutter#146260) 2024-05-01 [email protected] Roll Flutter Engine from 842cf254ec58 to c536a14052e5 (1 revision) (flutter/flutter#147675) 2024-05-01 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.3.0 to 4.3.1 (flutter/flutter#147674) 2024-05-01 [email protected] Remove obsolete performance analysis tools. (flutter/flutter#147663) 2024-05-01 [email protected] Roll Flutter Engine from 5129b4919434 to 842cf254ec58 (3 revisions) (flutter/flutter#147670) 2024-05-01 [email protected] fix DropdownMenu overflow (flutter/flutter#147233) 2024-05-01 [email protected] [web] remove platform_messages_integration test (flutter/flutter#147654) 2024-05-01 [email protected] Fix `TextField` horizontal drag conflicts (flutter/flutter#147341) 2024-05-01 [email protected] `flutter/lib/src/`: refactoring if-chains into switch expressions (flutter/flutter#147472) 2024-05-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Draggable feedback positioning (#145647)" (flutter/flutter#147658) 2024-05-01 [email protected] Roll Flutter Engine from 0014e0353aa9 to 5129b4919434 (1 revision) (flutter/flutter#147655) 2024-05-01 [email protected] add lang attribute to the a11y_assessments app (flutter/flutter#147586) 2024-05-01 [email protected] Draggable feedback positioning (flutter/flutter#145647) 2024-05-01 [email protected] Roll Flutter Engine from 0ce67714ce4c to 0014e0353aa9 (13 revisions) (flutter/flutter#147649) 2024-05-01 [email protected] Add test for animated_fractionally_sized_box.0.dart API example. (flutter/flutter#146721) 2024-05-01 [email protected] Roll Packages from cc47b06 to aea93d2 (5 revisions) (flutter/flutter#147647) 2024-05-01 [email protected] Update reorderable_list.dart to use Dart 3 return switch statement for consistency (flutter/flutter#147505) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 ...

## Description This PR fixes `DropdownMenu` menu vertical position when tight constraints are given to the `DropdownMenu`. Before: ![image](https://github.com/user-attachments/assets/d8d9b857-07ed-4d3c-afe2-44518d979e66) After: ![image](https://github.com/user-attachments/assets/a71ea3c8-a408-43a1-8c99-c2612ad4b24b) ## Related Issue Fixes [DropdownMenu does not correctly handle incoming maxWidth and minHeight constraints](#147076). (It fixes the minHeight part, the maxWidth part was already fixed in #147233). ## Tests Adds 4 tests.

PurplePolyhedron added 2 commits April 23, 2024 21:59

fix DropdownMenu overflow

dfe9e78

fix DropdownMenu overflow test

aa9e2be

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Apr 23, 2024

bleroux reviewed Apr 24, 2024

View reviewed changes

packages/flutter/test/material/dropdown_menu_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/dropdown_menu_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/dropdown_menu_test.dart Outdated Show resolved Hide resolved

PurplePolyhedron added 2 commits April 24, 2024 18:38

Update test indentation and find widget comments

e20d3c3

Update test indentation

ebc13a9

bleroux requested a review from QuncCccccc April 24, 2024 09:44

QuncCccccc approved these changes May 1, 2024

View reviewed changes

Piinks approved these changes May 1, 2024

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2024

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label May 1, 2024

auto-submit bot merged commit 68f8b53 into flutter:master May 1, 2024

engine-flutter-autoroll mentioned this pull request May 2, 2024

Roll Flutter from d33bb8fa5eb8 to bf7191fd3884 (34 revisions) flutter/packages#6637

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 2, 2024

68f8b53 fix DropdownMenu overflow (flutter/flutter#147233)

65853ba

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

68f8b53 fix DropdownMenu overflow (flutter/flutter#147233)

8768ab6

bleroux mentioned this pull request Oct 24, 2024

fix DropdownMenu menu vertical position #157496

Closed

bleroux mentioned this pull request Nov 6, 2024

Fix menu is detached when a MenuAnchor is given tight constraints #158265

Closed

bleroux mentioned this pull request Dec 2, 2024

Fix DropdownMenu menu is detached from the text field #159665

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix DropdownMenu overflow#147233

fix DropdownMenu overflow#147233
auto-submit[bot] merged 4 commits intoflutter:masterfrom
PurplePolyhedron:dropdown_menu_size

PurplePolyhedron commented Apr 23, 2024 •

edited by bleroux

Loading

Uh oh!

bleroux left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QuncCccccc left a comment

Uh oh!

Piinks left a comment

Uh oh!

auto-submit bot commented May 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

PurplePolyhedron commented Apr 23, 2024 • edited by bleroux Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Piinks left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented May 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PurplePolyhedron commented Apr 23, 2024 •

edited by bleroux

Loading