Fix memory leak in TabPageSelector [prod-leak-fix]#147403
Merged
polina-c merged 4 commits intoflutter:masterfrom Apr 30, 2024
Merged
Conversation
Contributor
Author
|
cc @polina-c |
github-actions
bot
added
framework
polina-c
added
the
a: leak tracking
polina-c
reviewed
Apr 26, 2024
| WidgetController.hitTestWarningShouldBeFatal = true; | ||
|
|
||
| if (_isLeakTrackingEnabled()) { | ||
| // if (_isLeakTrackingEnabled()) { |
Contributor
Author
There was a problem hiding this comment.
Oops ! Very sorry about that :( I reverted it in refactor: Revert bad commit
polina-c
approved these changes
Apr 30, 2024
Contributor
|
Reason for revert: Causing an internal test to fail, see b/338159496 for details |
auto-submit bot
pushed a commit
that referenced
this pull request
May 1, 2024
This reverts commit af27093.
9 tasks
auto-submit
bot
removed
the
revert
Contributor
Author
|
@chingjun Sorry for that. What can I do / check to make sure no internal tests fail ? (ex: what does "see b/338159496 for details" mean? ) |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 1, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
May 1, 2024
flutter/flutter@b597dd2...d33bb8f 2024-05-01 [email protected] Add tests for single_activator.0.dart API example. (flutter/flutter#147426) 2024-05-01 [email protected] Added missing code block language in docs (flutter/flutter#147481) 2024-05-01 [email protected] Move docs_test and docs_publish to bringup (flutter/flutter#147645) 2024-05-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix memory leak in `TabPageSelector` (#147403)" (flutter/flutter#147622) 2024-04-30 [email protected] Revert "add a new PopScope.onPopWithResultInvoke widget to replace Po� (flutter/flutter#147597) 2024-04-30 [email protected] include exception details in tool exit displayed when adb call fails (flutter/flutter#147498) 2024-04-30 [email protected] Fix memory leak in `TabPageSelector` (flutter/flutter#147403) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Contributor
|
The information is available to Google employees. @polina-c can you help with this? Thanks! |
Contributor
|
Error: I suggest to create PR to redo the change. |
9 tasks
Contributor
Author
|
OK thank you for the insights. I created a new PR: #147689. Let's see what is happening there |
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@b597dd2...d33bb8f 2024-05-01 [email protected] Add tests for single_activator.0.dart API example. (flutter/flutter#147426) 2024-05-01 [email protected] Added missing code block language in docs (flutter/flutter#147481) 2024-05-01 [email protected] Move docs_test and docs_publish to bringup (flutter/flutter#147645) 2024-05-01 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Fix memory leak in `TabPageSelector` (#147403)" (flutter/flutter#147622) 2024-04-30 [email protected] Revert "add a new PopScope.onPopWithResultInvoke widget to replace Po� (flutter/flutter#147597) 2024-04-30 [email protected] include exception details in tool exit displayed when adb call fails (flutter/flutter#147498) 2024-04-30 [email protected] Fix memory leak in `TabPageSelector` (flutter/flutter#147403) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced May 28, 2024
Closed
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
polina-c
changed the title
TabPageSelector TabPageSelector [prod-leak-fix]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #141198
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.