Add tests for material banner example by derdilla · Pull Request #147733 · flutter/flutter

derdilla · 2024-05-02T18:46:38Z

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

bleroux

Thanks for adding these valuable tests.
Just one small comment about capitalizing test descriptions first letter.

examples/api/test/material/banner/material_banner.0_test.dart

bleroux

LGTM! Thanks for adding those tests.
Taha and I are attending Google/IO this week, expect slow review, we will catch up on reviews next week.

bleroux · 2024-05-21T18:57:00Z

@NobodyForNothing Thanks for your patience, can you rebase this PR and solve the conflict if there is still one?

bleroux · 2024-05-22T06:37:05Z

Thanks for the rebase.
Linux analyze step failed because of several trailing space characters, see the corresponding lines in https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20analyze/79407/overview

examples/api/test/material/banner/material_banner.1_test.dart

bleroux

LGTM!

TahaTesser

LGTM! Just minor format issues

TahaTesser · 2024-05-23T12:00:02Z

examples/api/test/material/banner/material_banner.0_test.dart

 void main() {
+  testWidgets('Shows all elements', (WidgetTester tester) async {
+    await tester.pumpWidget(
+      const example.MaterialBannerExampleApp()


Suggested change

const example.MaterialBannerExampleApp()

const example.MaterialBannerExampleApp(),

TahaTesser · 2024-05-23T12:00:08Z

examples/api/test/material/banner/material_banner.0_test.dart

+
+  testWidgets('The banner is below the text saying so', (WidgetTester tester) async {
+    await tester.pumpWidget(
+      const example.MaterialBannerExampleApp()


Suggested change

const example.MaterialBannerExampleApp()

const example.MaterialBannerExampleApp(),

TahaTesser · 2024-05-23T12:00:51Z

examples/api/test/material/banner/material_banner.1_test.dart

+    final MaterialBanner banner = tester.widget<MaterialBanner>(
+        find.byType(MaterialBanner));


Suggested change

final MaterialBanner banner = tester.widget<MaterialBanner>(

find.byType(MaterialBanner));

final MaterialBanner banner = tester.widget<MaterialBanner>(

find.byType(MaterialBanner),

);

Co-authored-by: Taha Tesser <[email protected]>

flutter/flutter@8d955cd...8dd0831 2024-05-24 [email protected] Roll Flutter Engine from c6041cd9049c to 4ab442475223 (1 revision) (flutter/flutter#149039) 2024-05-24 [email protected] Roll Flutter Engine from 8d896f4feb76 to c6041cd9049c (1 revision) (flutter/flutter#149035) 2024-05-24 [email protected] Roll Flutter Engine from fe3b26294d8f to 8d896f4feb76 (1 revision) (flutter/flutter#149030) 2024-05-24 [email protected] Roll Flutter Engine from b4fb08f21757 to fe3b26294d8f (1 revision) (flutter/flutter#149028) 2024-05-24 [email protected] Roll Flutter Engine from f873230ce823 to b4fb08f21757 (2 revisions) (flutter/flutter#149025) 2024-05-24 [email protected] Roll Flutter Engine from d78f66753332 to f873230ce823 (1 revision) (flutter/flutter#149021) 2024-05-24 [email protected] Roll Flutter Engine from 768c90ee5dc7 to d78f66753332 (3 revisions) (flutter/flutter#149011) 2024-05-23 [email protected] Reland "Update `FocusManager` platform check to include iOS" (flutter/flutter#148984) 2024-05-23 [email protected] Roll Flutter Engine from ad12c5d02a8c to 768c90ee5dc7 (2 revisions) (flutter/flutter#149003) 2024-05-23 [email protected] Fix `SnackBar` action text button overlay color (flutter/flutter#148961) 2024-05-23 [email protected] Fix the second TextFormField to trigger onTapOutside (flutter/flutter#148930) 2024-05-23 [email protected] Roll Flutter Engine from 2a48302f6f4e to ad12c5d02a8c (3 revisions) (flutter/flutter#148993) 2024-05-23 [email protected] Roll Flutter Engine from 964f087f288c to 2a48302f6f4e (1 revision) (flutter/flutter#148950) 2024-05-23 [email protected] [wiki migration] Remaining pages under docs/contributing/ (flutter/flutter#148790) 2024-05-23 [email protected] [wiki migration] Web team pages (flutter/flutter#148777) 2024-05-23 [email protected] Test remaining transitions api examples (flutter/flutter#148302) 2024-05-23 [email protected] Test snack bar examples (flutter/flutter#147774) 2024-05-23 [email protected] Add tests for material banner example (flutter/flutter#147733) 2024-05-23 [email protected] Roll Packages from 6525441 to 1008d9e (6 revisions) (flutter/flutter#148980) 2024-05-23 [email protected] Revert "const vs. non-const widget build benchmark" (flutter/flutter#148970) 2024-05-23 [email protected] Remove hidden dependencies on HttpClient (flutter/flutter#148773) 2024-05-23 [email protected] Revert "Update `FocusManager` platform check to include iOS" (flutter/flutter#148978) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Part of flutter#130459.

derdilla added 3 commits May 2, 2024 20:35

test material banner example 0

6935f78

test material banner example 1

ecf868f

remove material banner from exemptions

fc85c47

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels May 2, 2024

test for correct banner color

b42421b

Piinks requested review from TahaTesser and bleroux May 8, 2024 18:20

bleroux requested changes May 9, 2024

View reviewed changes

examples/api/test/material/banner/material_banner.0_test.dart Outdated Show resolved Hide resolved

change capitalization

6dd071f

bleroux approved these changes May 14, 2024

View reviewed changes

Merge branch 'master' into 130459-material_banner-test

a4e42cc

fix formating

e6b13e7

bleroux requested changes May 22, 2024

View reviewed changes

examples/api/test/material/banner/material_banner.1_test.dart Outdated Show resolved Hide resolved

derdilla added 2 commits May 23, 2024 10:55

Update material_banner.1_test.dart

d5ed2d2

Update material_banner.1_test.dart

3afadd8

bleroux approved these changes May 23, 2024

View reviewed changes

TahaTesser approved these changes May 23, 2024

View reviewed changes

Apply suggestions from code review

451f32f

Co-authored-by: Taha Tesser <[email protected]>

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label May 23, 2024

auto-submit bot merged commit 1c1516c into flutter:master May 23, 2024

engine-flutter-autoroll mentioned this pull request May 24, 2024

Roll Flutter from 8d955cdd644e to 8dd08314d2e4 (22 revisions) flutter/packages#6788

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 24, 2024

1c1516c Add tests for material banner example (flutter/flutter#147733)

fd758b9

Piinks mentioned this pull request May 31, 2024

Flutter Framework Team: Notable Commits #121415

Closed

victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024

Add tests for material banner example (flutter#147733)

7b501a7

Part of flutter#130459.

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

1c1516c Add tests for material banner example (flutter/flutter#147733)

0a9bae5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add tests for material banner example#147733

Add tests for material banner example#147733
auto-submit[bot] merged 10 commits intoflutter:masterfrom
derdilla:130459-material_banner-test

derdilla commented May 2, 2024

Uh oh!

bleroux left a comment

Uh oh!

Uh oh!

bleroux left a comment

Uh oh!

bleroux commented May 21, 2024

Uh oh!

bleroux commented May 22, 2024

Uh oh!

Uh oh!

bleroux left a comment

Uh oh!

TahaTesser left a comment

Uh oh!

TahaTesser May 23, 2024

Uh oh!

TahaTesser May 23, 2024

Uh oh!

TahaTesser May 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	const example.MaterialBannerExampleApp()
	const example.MaterialBannerExampleApp(),

		final MaterialBanner banner = tester.widget<MaterialBanner>(
		find.byType(MaterialBanner));

Conversation

derdilla commented May 2, 2024

Pre-launch Checklist

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

bleroux commented May 21, 2024

Uh oh!

bleroux commented May 22, 2024

Uh oh!

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

TahaTesser May 23, 2024

Choose a reason for hiding this comment

Uh oh!

TahaTesser May 23, 2024

Choose a reason for hiding this comment

Uh oh!

TahaTesser May 23, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants