Merged
Conversation
548571f to
e61789d
Compare
TahaTesser
approved these changes
May 9, 2024
Contributor
TahaTesser
left a comment
There was a problem hiding this comment.
LGTM! With minor nits
Signed-off-by: huycozy <[email protected]>
e61789d to
736c597
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
May 9, 2024
bparrishMines
pushed a commit
to flutter/packages
that referenced
this pull request
May 10, 2024
flutter/flutter@00f4066...2bfb1b0 2024-05-09 [email protected] Bump flutter_lints to 4.0 (flutter/flutter#148020) 2024-05-09 [email protected] Add Badge example (flutter/flutter#148053) 2024-05-09 [email protected] Fix ExpandIcon color when ExpansionPanel.canTapOnHeader true (#147097) (flutter/flutter#147098) 2024-05-09 [email protected] Roll Flutter Engine from c2e874fdc164 to c0fd3386d018 (1 revision) (flutter/flutter#148040) 2024-05-09 [email protected] Roll Flutter Engine from fe08238f5a52 to c2e874fdc164 (1 revision) (flutter/flutter#148038) 2024-05-09 [email protected] Roll Flutter Engine from 69f2d9610a18 to fe08238f5a52 (1 revision) (flutter/flutter#148034) 2024-05-09 [email protected] Roll pub packages (flutter/flutter#148011) 2024-05-09 [email protected] Roll Flutter Engine from bd58d2b2d655 to 69f2d9610a18 (7 revisions) (flutter/flutter#148030) 2024-05-09 [email protected] [web] Update wasm CLI details to be clear JavaScript is ALSO compiled (flutter/flutter#147944) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter
pushed a commit
to TecHaxter/flutter_packages
that referenced
this pull request
May 22, 2024
flutter/flutter@00f4066...2bfb1b0 2024-05-09 [email protected] Bump flutter_lints to 4.0 (flutter/flutter#148020) 2024-05-09 [email protected] Add Badge example (flutter/flutter#148053) 2024-05-09 [email protected] Fix ExpandIcon color when ExpansionPanel.canTapOnHeader true (#147097) (flutter/flutter#147098) 2024-05-09 [email protected] Roll Flutter Engine from c2e874fdc164 to c0fd3386d018 (1 revision) (flutter/flutter#148040) 2024-05-09 [email protected] Roll Flutter Engine from fe08238f5a52 to c2e874fdc164 (1 revision) (flutter/flutter#148038) 2024-05-09 [email protected] Roll Flutter Engine from 69f2d9610a18 to fe08238f5a52 (1 revision) (flutter/flutter#148034) 2024-05-09 [email protected] Roll pub packages (flutter/flutter#148011) 2024-05-09 [email protected] Roll Flutter Engine from bd58d2b2d655 to 69f2d9610a18 (7 revisions) (flutter/flutter#148030) 2024-05-09 [email protected] [web] Update wasm CLI details to be clear JavaScript is ALSO compiled (flutter/flutter#147944) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demo screenshot
Related issue
Fixes #144336
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.