Manual roll camera dependency by goderbauer · Pull Request #148426 · flutter/flutter

goderbauer · 2024-05-15T20:53:02Z

Supersedes #148245

goderbauer · 2024-05-15T21:22:11Z

Looks like just removing that extra dependency is not enough. Now there are other gradle errors.

stuartmorgan-g · 2024-05-15T21:25:45Z

Buried in the output is:

┌─ Flutter Fix ───────────────────────────────────────────────────────────────────────────────┐
│ You need to update the lockfile, or disable Gradle dependency locking.                      │
│ To regenerate the lockfiles run: `./gradlew :generateLockfiles` in                          │
│ /b/s/w/ir/x/w/flutter/dev/integration_tests/gradle_deprecated_settings/android/build.gradle │
│ To remove dependency locking, remove the `dependencyLocking` from                           │
│ /b/s/w/ir/x/w/flutter/dev/integration_tests/gradle_deprecated_settings/android/build.gradle │
└─────────────────────────────────────────────────────────────────────────────────────────────┘

goderbauer · 2024-05-15T22:32:41Z

Thanks, totally missed that in the output. The command fails, though:

% ./gradlew :generateLockfiles

Welcome to Gradle 8.3!

Here are the highlights of this release:
 - Faster Java compilation
 - Reduced memory usage
 - Support for running on Java 20

For more details see https://docs.gradle.org/8.3/release-notes.html

Starting a Gradle Daemon, 1 incompatible Daemon could not be reused, use --status for details

> Configure project :app
You are applying Flutter's main Gradle plugin imperatively using the apply script method, which is deprecated and will be removed in a future release. Migrate to applying Gradle plugins with the declarative plugins block: https://flutter.dev/go/flutter-gradle-plugin-apply

w: file:///Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts:107:40: Variable 'agpVersion' initializer is redundant
w: file:///Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts:108:40: Variable 'kgpVersion' initializer is redundant
w: file:///Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts:143:28: Parameter 'project' is never used
w: file:///Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts:152:40: Variable 'agpVersion' initializer is redundant
w: file:///Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts:167:55: 'Version' is deprecated. Deprecated in Java
w: file:///Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts:195:56: Unnecessary non-null assertion (!!) on a non-null receiver of type Any
w: file:///Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/kotlin/dependency_version_checker.gradle.kts:344:28: The corresponding parameter in the supertype 'Comparable' is named 'other'. This may cause problems when calling this function with named arguments.
Starting a Gradle Daemon, 1 busy and 1 incompatible Daemons could not be reused, use --status for details

FAILURE: Build failed with an exception.

* What went wrong:
A problem occurred configuring root project 'android'.
> Could not open proj generic class cache for build file '/Users/goderbauer/dev/flutter/dev/integration_tests/gradle_deprecated_settings/android/build.gradle' (/Users/goderbauer/.gradle/caches/8.3/scripts/c192y7qa3j8v1de05e2zs4p7).
   > BUG! exception in phase 'semantic analysis' in source unit '_BuildScript_' Unsupported class file major version 66

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 4s

FAILURE: Build failed with an exception.

* Where:
Script '/Users/goderbauer/dev/flutter/packages/flutter_tools/gradle/src/main/groovy/flutter.groovy' line: 222

* What went wrong:
A problem occurred configuring root project 'android'.
> Could not create task ':generateLockfiles'.
   > Process 'command '/Users/goderbauer/dev/flutter/dev/integration_tests/gradle_deprecated_settings/android/gradlew'' finished with non-zero exit value 1

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org.

BUILD FAILED in 18s

stuartmorgan-g · 2024-05-15T23:48:16Z

Unsupported class file major version 66

IIRC that means your Java version isn't in the support range of your Gradle version. This isn't my area of expertise, but it looks from a skim of search results like this mean you are using Java 22, and the Gradle output sounds like it's only supporting 20 at that version.

@reidbaker may have suggestions on how to handle this (other than by installing an old version of Java)?

goderbauer · 2024-05-20T18:44:46Z

For future archeologists:

@gmackall helped me out and instructed me to set my JAVA_HOME to the java version that shipped with the engine:

export JAVA_HOME=/Users/goderbauer/dev/engine/src/third_party/java/openjdk/Contents/Home

With that, the ./gradlew :generateLockfiles run succeeded in regenerating the lock files. Now 🤞 that everything will pass on CI as well.

Thanks a ton for everyone's help with this one!

stuartmorgan-g

LGTM

goderbauer · 2024-05-20T23:03:54Z

Note to self: Remember to close #148245 when this is submitted to restart auto-roller.

flutter/flutter@02a6c91...d02292d 2024-05-21 [email protected] Make FileSystem dependency explicit througout (more). (flutter/flutter#148095) 2024-05-20 [email protected] Remove add-to-app bitcode warning (flutter/flutter#148587) 2024-05-20 [email protected] SelectionArea's selection should not be cleared on loss of window focus (flutter/flutter#148067) 2024-05-20 [email protected] [wiki migration] Engine team pages (flutter/flutter#148696) 2024-05-20 [email protected] Manual roll camera dependency (flutter/flutter#148426) 2024-05-20 [email protected] [wiki migration] Framework team pages (flutter/flutter#148721) 2024-05-20 [email protected] Roll Flutter Engine from a8fb9daae8d0 to c2ef01f6f1ab (3 revisions) (flutter/flutter#148722) 2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter/flutter#148715) 2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter/flutter#148714) 2024-05-20 [email protected] Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter/flutter#148580) 2024-05-20 [email protected] Roll Flutter Engine from c6fecf65fbf3 to a8fb9daae8d0 (3 revisions) (flutter/flutter#148700) 2024-05-20 [email protected] Remove the no-shuffle tag on the flutter_tools create_test suite (flutter/flutter#148688) 2024-05-20 [email protected] log incoming vm service messages in `FlutterVMService::runInView` (flutter/flutter#148596) 2024-05-20 [email protected] Add tests for shared_app_data.#.dart API examples. (flutter/flutter#147830) 2024-05-20 [email protected] Add tests for logical_key_set.0.dart API example. (flutter/flutter#147735) 2024-05-20 [email protected] [wiki migration] Ecosystem team pages (flutter/flutter#148589) 2024-05-20 [email protected] Fix painting API examples tests directories structure. (flutter/flutter#148177) 2024-05-20 [email protected] fixes `CupertinoModalPopupRoute` (flutter/flutter#147823) 2024-05-20 [email protected] Implement new `AnimationStatus` getters (flutter/flutter#148570) 2024-05-20 [email protected] Reland "`if` chains â�� `switch` expressions" (flutter/flutter#148634) 2024-05-20 [email protected] Factor out `RawView`, make `View` listen to engine generated view focus events (flutter/flutter#143259) 2024-05-20 [email protected] Remove all tests from a02s. Replace with mokey in bringup (flutter/flutter#148563) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…-coder-xu/flutter into fix/slider_text_null_error * 'fix/slider_text_null_error' of https://github.com/hello-coder-xu/flutter: (65 commits) Change implementation method fix slider text null error Make FileSystem dependency explicit througout (more). (flutter#148095) Remove add-to-app bitcode warning (flutter#148587) SelectionArea's selection should not be cleared on loss of window focus (flutter#148067) [wiki migration] Engine team pages (flutter#148696) Manual roll camera dependency (flutter#148426) [wiki migration] Framework team pages (flutter#148721) Roll Flutter Engine from a8fb9da to c2ef01f (3 revisions) (flutter#148722) Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter#148715) Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter#148714) Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter#148580) Roll Flutter Engine from c6fecf6 to a8fb9da (3 revisions) (flutter#148700) Remove the no-shuffle tag on the flutter_tools create_test suite (flutter#148688) log incoming vm service messages in `FlutterVMService::runInView` (flutter#148596) Add tests for shared_app_data.#.dart API examples. (flutter#147830) Add tests for logical_key_set.0.dart API example. (flutter#147735) [wiki migration] Ecosystem team pages (flutter#148589) Fix painting API examples tests directories structure. (flutter#148177) fixes `CupertinoModalPopupRoute` (flutter#147823) ...

flutter/flutter@02a6c91...d02292d 2024-05-21 [email protected] Make FileSystem dependency explicit througout (more). (flutter/flutter#148095) 2024-05-20 [email protected] Remove add-to-app bitcode warning (flutter/flutter#148587) 2024-05-20 [email protected] SelectionArea's selection should not be cleared on loss of window focus (flutter/flutter#148067) 2024-05-20 [email protected] [wiki migration] Engine team pages (flutter/flutter#148696) 2024-05-20 [email protected] Manual roll camera dependency (flutter/flutter#148426) 2024-05-20 [email protected] [wiki migration] Framework team pages (flutter/flutter#148721) 2024-05-20 [email protected] Roll Flutter Engine from a8fb9daae8d0 to c2ef01f6f1ab (3 revisions) (flutter/flutter#148722) 2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter/flutter#148715) 2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter/flutter#148714) 2024-05-20 [email protected] Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter/flutter#148580) 2024-05-20 [email protected] Roll Flutter Engine from c6fecf65fbf3 to a8fb9daae8d0 (3 revisions) (flutter/flutter#148700) 2024-05-20 [email protected] Remove the no-shuffle tag on the flutter_tools create_test suite (flutter/flutter#148688) 2024-05-20 [email protected] log incoming vm service messages in `FlutterVMService::runInView` (flutter/flutter#148596) 2024-05-20 [email protected] Add tests for shared_app_data.#.dart API examples. (flutter/flutter#147830) 2024-05-20 [email protected] Add tests for logical_key_set.0.dart API example. (flutter/flutter#147735) 2024-05-20 [email protected] [wiki migration] Ecosystem team pages (flutter/flutter#148589) 2024-05-20 [email protected] Fix painting API examples tests directories structure. (flutter/flutter#148177) 2024-05-20 [email protected] fixes `CupertinoModalPopupRoute` (flutter/flutter#147823) 2024-05-20 [email protected] Implement new `AnimationStatus` getters (flutter/flutter#148570) 2024-05-20 [email protected] Reland "`if` chains â�� `switch` expressions" (flutter/flutter#148634) 2024-05-20 [email protected] Factor out `RawView`, make `View` listen to engine generated view focus events (flutter/flutter#143259) 2024-05-20 [email protected] Remove all tests from a02s. Replace with mokey in bringup (flutter/flutter#148563) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixes #146004 The `camera_android`plugin had its version pinned when it was still used in the `gradle_deprecated_settings`. It has since been [replaced](#148426) by `camera_android_camerax`, and therefore isn't used in `flutter/flutter`. So it's pin should be fine to remove.

goderbauer requested a review from stuartmorgan-g May 15, 2024 20:53

goderbauer mentioned this pull request May 15, 2024

Roll pub packages #148245

Closed

Manual roll camera dependency

825920c

goderbauer force-pushed the manualCameraBump branch from c3aea0b to 7c28e0b Compare May 20, 2024 18:36

run gradlew

15c17df

goderbauer force-pushed the manualCameraBump branch from 7c28e0b to 15c17df Compare May 20, 2024 18:39

stuartmorgan-g approved these changes May 20, 2024

View reviewed changes

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024

auto-submit bot merged commit 40b5bc3 into flutter:master May 20, 2024

engine-flutter-autoroll mentioned this pull request May 21, 2024

Roll Flutter from 02a6c91e4d37 to d02292dbc409 (22 revisions) flutter/packages#6778

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2024

40b5bc3 Manual roll camera dependency (flutter/flutter#148426)

d152166

goderbauer deleted the manualCameraBump branch May 21, 2024 16:07

gmackall mentioned this pull request Jun 10, 2024

Unpin camera_android and remove its only usage #150017

Merged

9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

40b5bc3 Manual roll camera dependency (flutter/flutter#148426)

c608126

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Manual roll camera dependency#148426

Manual roll camera dependency#148426
auto-submit[bot] merged 2 commits intoflutter:masterfrom
goderbauer:manualCameraBump

goderbauer commented May 15, 2024

Uh oh!

goderbauer commented May 15, 2024

Uh oh!

stuartmorgan-g commented May 15, 2024

Uh oh!

goderbauer commented May 15, 2024 •

edited

Loading

Uh oh!

stuartmorgan-g commented May 15, 2024

Uh oh!

goderbauer commented May 20, 2024

Uh oh!

stuartmorgan-g left a comment

Uh oh!

goderbauer commented May 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

goderbauer commented May 15, 2024

Uh oh!

goderbauer commented May 15, 2024

Uh oh!

stuartmorgan-g commented May 15, 2024

Uh oh!

goderbauer commented May 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stuartmorgan-g commented May 15, 2024

Uh oh!

goderbauer commented May 20, 2024

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

goderbauer commented May 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

goderbauer commented May 15, 2024 •

edited

Loading