Skip to content

Implement new AnimationStatus getters#148570

Merged
auto-submit[bot] merged 4 commits intoflutter:masterfrom
nate-thegrate:animation-status-refactor
May 20, 2024
Merged

Implement new AnimationStatus getters#148570
auto-submit[bot] merged 4 commits intoflutter:masterfrom
nate-thegrate:animation-status-refactor

Conversation

@nate-thegrate
Copy link
Contributor

@nate-thegrate nate-thegrate commented May 17, 2024

PR #147801 introduced some convenient AnimationStatus getters, but I just realized that AnimationController now has 2 getters for the same thing: isAnimating and isRunning.

The intent of this pull request is to correct that mistake, and implement the getters in the appropriate places.

@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: routes Navigator, Router, and related APIs. labels May 17, 2024
nate-thegrate
nate-thegrate commented May 17, 2024
View reviewed changes
packages/flutter/lib/src/animation/animation.dart Outdated
Comment on lines 182 to 183
Copy link
Contributor Author

@nate-thegrate nate-thegrate May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Names are consistent now!

dev/integration_tests/new_gallery/lib/feature_discovery/feature_discovery.dart Outdated
Comment on lines 290 to 297
Copy link
Contributor Author

@nate-thegrate nate-thegrate May 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't an isForward getter, so I decided to do a switch statement here (for readability and to follow the style guide).

@goderbauer goderbauer self-requested a review May 17, 2024 21:03
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: routes Navigator, Router, and related APIs. and removed a: text input Entering text in a text field or keyboard related problems f: material design flutter/packages/flutter/material repository. f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: routes Navigator, Router, and related APIs. labels May 17, 2024
@nate-thegrate nate-thegrate force-pushed the animation-status-refactor branch from 747f9e5 to 2141f68 Compare May 18, 2024 16:35
@nate-thegrate nate-thegrate marked this pull request as ready for review May 19, 2024 14:21
@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label May 19, 2024
@nate-thegrate nate-thegrate removed the will affect goldens Changes to golden files label May 19, 2024
@flutter-dashboard
Copy link

flutter-dashboard bot commented May 19, 2024

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #148570 at sha fa6d261c1a7b80d581cd3b58bd367aa48751c43a

@flutter-dashboard flutter-dashboard bot added the will affect goldens Changes to golden files label May 19, 2024
@flutter flutter deleted a comment from flutter-dashboard bot May 19, 2024
@nate-thegrate
Copy link
Contributor Author

nate-thegrate commented May 19, 2024

slightly different

(Link from original comment)

goderbauer
goderbauer approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goderbauer
Copy link
Member

goderbauer commented May 20, 2024

The link doesn't show any golden file changes? Did you already triage them? Or maybe they were related to a different change on main? For the latter, you could just try rebasing and see if it goes away.

@nate-thegrate nate-thegrate force-pushed the animation-status-refactor branch from fa6d261 to aef464a Compare May 20, 2024 16:44
@nate-thegrate nate-thegrate removed the will affect goldens Changes to golden files label May 20, 2024
@nate-thegrate
Copy link
Contributor Author

nate-thegrate commented May 20, 2024

The link doesn't show any golden file changes? Did you already triage them? Or maybe they were related to a different change on main? For the latter, you could just try rebasing and see if it goes away.

I didn't do any triage… not sure why it isn't visible anymore.

I found the images from my browser history:

Hopefully everything will pass now!

@nate-thegrate nate-thegrate added the autosubmit Merge PR when tree becomes green via auto submit App label May 20, 2024
@auto-submit auto-submit bot merged commit 76a07a1 into flutter:master May 20, 2024
@nate-thegrate nate-thegrate deleted the animation-status-refactor branch May 20, 2024 17:44
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 21, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 21, 2024
@engine-flutter-autoroll
76a07a1 Implement new AnimationStatus getters (flutter/flutter#148570)
bf3fbc2
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 21, 2024
@engine-flutter-autoroll
Roll Flutter from 02a6c91 to d02292d (22 revisions) (#6778)
1b1b5e3 
flutter/flutter@02a6c91...d02292d

2024-05-21 [email protected] Make FileSystem dependency explicit througout (more). (flutter/flutter#148095)
2024-05-20 [email protected] Remove add-to-app bitcode warning (flutter/flutter#148587)
2024-05-20 [email protected] SelectionArea's selection should not be cleared on loss of window focus (flutter/flutter#148067)
2024-05-20 [email protected] [wiki migration] Engine team pages (flutter/flutter#148696)
2024-05-20 [email protected] Manual roll camera dependency (flutter/flutter#148426)
2024-05-20 [email protected] [wiki migration] Framework team pages (flutter/flutter#148721)
2024-05-20 [email protected] Roll Flutter Engine from a8fb9daae8d0 to c2ef01f6f1ab (3 revisions) (flutter/flutter#148722)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter/flutter#148715)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter/flutter#148714)
2024-05-20 [email protected] Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter/flutter#148580)
2024-05-20 [email protected] Roll Flutter Engine from c6fecf65fbf3 to a8fb9daae8d0 (3 revisions) (flutter/flutter#148700)
2024-05-20 [email protected] Remove the no-shuffle tag on the flutter_tools create_test suite (flutter/flutter#148688)
2024-05-20 [email protected] log incoming vm service messages in `FlutterVMService::runInView` (flutter/flutter#148596)
2024-05-20 [email protected] Add tests for shared_app_data.#.dart API examples. (flutter/flutter#147830)
2024-05-20 [email protected] Add tests for logical_key_set.0.dart API example. (flutter/flutter#147735)
2024-05-20 [email protected] [wiki migration] Ecosystem team pages (flutter/flutter#148589)
2024-05-20 [email protected] Fix painting API examples tests directories structure. (flutter/flutter#148177)
2024-05-20 [email protected] fixes `CupertinoModalPopupRoute` (flutter/flutter#147823)
2024-05-20 [email protected] Implement new `AnimationStatus` getters (flutter/flutter#148570)
2024-05-20 [email protected] Reland "`if` chains â�� `switch` expressions" (flutter/flutter#148634)
2024-05-20 [email protected] Factor out `RawView`, make `View` listen to engine generated view focus events (flutter/flutter#143259)
2024-05-20 [email protected] Remove all tests from a02s. Replace with mokey in bringup (flutter/flutter#148563)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TecHaxter pushed a commit to TecHaxter/flutter_packages that referenced this pull request May 22, 2024
@engine-flutter-autoroll @TecHaxter
Roll Flutter from 02a6c91 to d02292d (22 revisions) (flutter#6778)
e4ff699 
flutter/flutter@02a6c91...d02292d

2024-05-21 [email protected] Make FileSystem dependency explicit througout (more). (flutter/flutter#148095)
2024-05-20 [email protected] Remove add-to-app bitcode warning (flutter/flutter#148587)
2024-05-20 [email protected] SelectionArea's selection should not be cleared on loss of window focus (flutter/flutter#148067)
2024-05-20 [email protected] [wiki migration] Engine team pages (flutter/flutter#148696)
2024-05-20 [email protected] Manual roll camera dependency (flutter/flutter#148426)
2024-05-20 [email protected] [wiki migration] Framework team pages (flutter/flutter#148721)
2024-05-20 [email protected] Roll Flutter Engine from a8fb9daae8d0 to c2ef01f6f1ab (3 revisions) (flutter/flutter#148722)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.5 to 3.25.6 (flutter/flutter#148715)
2024-05-20 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.4.0 to 4.4.1 (flutter/flutter#148714)
2024-05-20 [email protected] Fixes incorrect read/write permissions on Flutter.framework and FlutterMacOS.framework (flutter/flutter#148580)
2024-05-20 [email protected] Roll Flutter Engine from c6fecf65fbf3 to a8fb9daae8d0 (3 revisions) (flutter/flutter#148700)
2024-05-20 [email protected] Remove the no-shuffle tag on the flutter_tools create_test suite (flutter/flutter#148688)
2024-05-20 [email protected] log incoming vm service messages in `FlutterVMService::runInView` (flutter/flutter#148596)
2024-05-20 [email protected] Add tests for shared_app_data.#.dart API examples. (flutter/flutter#147830)
2024-05-20 [email protected] Add tests for logical_key_set.0.dart API example. (flutter/flutter#147735)
2024-05-20 [email protected] [wiki migration] Ecosystem team pages (flutter/flutter#148589)
2024-05-20 [email protected] Fix painting API examples tests directories structure. (flutter/flutter#148177)
2024-05-20 [email protected] fixes `CupertinoModalPopupRoute` (flutter/flutter#147823)
2024-05-20 [email protected] Implement new `AnimationStatus` getters (flutter/flutter#148570)
2024-05-20 [email protected] Reland "`if` chains â�� `switch` expressions" (flutter/flutter#148634)
2024-05-20 [email protected] Factor out `RawView`, make `View` listen to engine generated view focus events (flutter/flutter#143259)
2024-05-20 [email protected] Remove all tests from a02s. Replace with mokey in bringup (flutter/flutter#148563)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@Piinks Piinks mentioned this pull request May 31, 2024
Closed
@nate-thegrate nate-thegrate added the refactor Improving readability/efficiency without behavioral changes label Jul 12, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
76a07a1 Implement new AnimationStatus getters (flutter/flutter#148570)
7cc9ef2
@huycozy huycozy mentioned this pull request Aug 22, 2024
Closed
@bleroux bleroux mentioned this pull request Aug 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

a: animation Animation APIs a: text input Entering text in a text field or keyboard related problems autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. f: routes Navigator, Router, and related APIs. f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. refactor Improving readability/efficiency without behavioral changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nate-thegrate @goderbauer