Add tests for tween_animation_builder.0.dart API example.#148902
Conversation
github-actions
bot
added
framework
victorsanni
left a comment
victorsanni
left a comment
There was a problem hiding this comment.
LGTM. I think it might be prudent to add an additional test that the reverse animation is triggered immediately the icon is tapped during the animation (not just at the end), and vice versa. I'm not sure if that's already covered here.
Thanks for writing these tests!
|
Hi @victorsanni, thanks for the review! |
There was a problem hiding this comment.
Maybe make this optional, and provide a default duration of 1 second?
There was a problem hiding this comment.
@gspencergoog thanks for the review!
In the recent commit I updated the duration to be optional and provided a default value.
Could you please take a look again?
ksokolovskyi
force-pushed
the
add-tween-animation-builder-example-tests
branch
from
303113f to
64fc8a2
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #148902 at sha 8fd218b3e208da75cfc8b2adf8d3c0c85edc8c99 |
ksokolovskyi
force-pushed
the
add-tween-animation-builder-example-tests
branch
from
8fd218b to
607ea31
Compare
There was a problem hiding this comment.
I think you can just hard code const Duration(seconds: 1) here as the default. Having it be a separate static reference doesn't add anything to the example, and people will replicate it, which isn't necessarily desirable. Instead of referencing the static in the test, just hardcode it there too.
There was a problem hiding this comment.
@gspencergoog got it, thanks for the suggestion!
gspencergoog
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/flutter/148902, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
ksokolovskyi
force-pushed
the
add-tween-animation-builder-example-tests
branch
from
a9f778e to
e888493
Compare
gspencergoog
added
the
autosubmit
|
@victorsanni @gspencergoog thanks a lot for the review! |
…8902) This PR contributes to flutter#130459 ### Description - Adds tests for `examples/api/lib/widgets/tween_animation_builder/tween_animation_builder.0.dart`
3 participants
This PR contributes to #130459
Description
examples/api/lib/widgets/tween_animation_builder/tween_animation_builder.0.dartPre-launch Checklist
///).