Skip to content

Manual pub roll w/ gradle lockfile regeneration#149342

Merged
auto-submit[bot] merged 1 commit intoflutter:masterfrom
gmackall:manual_pub_roll
May 30, 2024
Merged

Manual pub roll w/ gradle lockfile regeneration#149342
auto-submit[bot] merged 1 commit intoflutter:masterfrom
gmackall:manual_pub_roll

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented May 30, 2024 •
edited
Loading

Manual recreation of #148911

Entire PR is just the output of

flutter update-packages --force-upgrade

followed by (run from the root of the flutter repo)

find . -type d -name 'android' | dart dev/tools/bin/generate_gradle_lockfiles.dart --no-gradle-generation --no-exclusion

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos platform-web Web applications specifically f: integration_test The flutter/packages/integration_test plugin labels May 30, 2024
@gmackall gmackall marked this pull request as ready for review May 30, 2024 21:27
gmackall
gmackall commented May 30, 2024
View reviewed changes
dev/benchmarks/test_apps/stocks/lib/i18n/stock_strings.dart Outdated
Copy link
Member Author

@gmackall gmackall May 30, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @christopherfujino if you have any pointers, I think you encountered this (changes to these stock strings that fail analysis) in the past in #145564, and said you "fixed analysis and checked it in" but I don't know what that means in this context

Copy link
Contributor

@christopherfujino christopherfujino May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I gave up on this because it turned into a yak shave. I would recommend just reverting the diffs to three dart files here as a workaround.

I believe @andrewkolos has a PR open that would fix this, although as I recall this is a subtly tricky problem to solve.

Copy link
Member Author

@gmackall gmackall May 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I'll revert

Copy link
Contributor

@andrewkolos andrewkolos May 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(FYI) I filed #149386 and will be trying to resolve this.

@gmackall gmackall requested a review from andrewkolos May 30, 2024 22:42
andrewkolos
andrewkolos approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewkolos andrewkolos mentioned this pull request May 30, 2024
Closed
@andrewkolos andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label May 30, 2024
@auto-submit auto-submit bot merged commit d89ae48 into flutter:master May 30, 2024
@andrewkolos andrewkolos mentioned this pull request May 31, 2024
Closed
@DanTup DanTup mentioned this pull request May 31, 2024
Closed
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
@gmackall @victorsanni
Manual pub roll w/ gradle lockfile regeneration (flutter#149342)
e86b6e9 
Manual recreation of flutter#148911

Entire PR is just the output of 
```
flutter update-packages --force-upgrade
```
followed by (run from the root of the flutter repo)
```
find . -type d -name 'android' | dart dev/tools/bin/generate_gradle_lockfiles.dart --no-gradle-generation --no-exclusion
```
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2024
@engine-flutter-autoroll
d89ae48 Manual pub roll w/ gradle lockfile regeneration (flutter/flut…
ec45e58 
…ter#149342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 2, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 2, 2024
@engine-flutter-autoroll
d89ae48 Manual pub roll w/ gradle lockfile regeneration (flutter/flut…
0bc27fa 
…ter#149342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
d89ae48 Manual pub roll w/ gradle lockfile regeneration (flutter/flut…
977a9af 
…ter#149342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
d89ae48 Manual pub roll w/ gradle lockfile regeneration (flutter/flut…
0402f03 
…ter#149342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
d89ae48 Manual pub roll w/ gradle lockfile regeneration (flutter/flut…
2598937 
…ter#149342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
d89ae48 Manual pub roll w/ gradle lockfile regeneration (flutter/flut…
05c90c1 
…ter#149342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
d89ae48 Manual pub roll w/ gradle lockfile regeneration (flutter/flut…
ebb79b2 
…ter#149342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
d89ae48 Manual pub roll w/ gradle lockfile regeneration (flutter/flut…
03d3327 
…ter#149342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
d89ae48 Manual pub roll w/ gradle lockfile regeneration (flutter/flut…
d0575fd 
…ter#149342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
d89ae48 Manual pub roll w/ gradle lockfile regeneration (flutter/flut…
8a04b90 
…ter#149342)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 3, 2024
@engine-flutter-autoroll
d89ae48 Manual pub roll w/ gradle lockfile regeneration (flutter/flut…
d72dcbb 
…ter#149342)
@andrewkolos andrewkolos mentioned this pull request Jun 18, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
d89ae48 Manual pub roll w/ gradle lockfile regeneration (flutter/flut…
2b4e69c 
…ter#149342)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkolos andrewkolos andrewkolos approved these changes

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gmackall @christopherfujino @andrewkolos