Add contrastLevel parameter to ColorScheme.fromSeed#149705
Merged
auto-submit[bot] merged 7 commits intoflutter:masterfrom Jun 5, 2024
Merged
Add contrastLevel parameter to ColorScheme.fromSeed#149705auto-submit[bot] merged 7 commits intoflutter:masterfrom
contrastLevel parameter to ColorScheme.fromSeed#149705auto-submit[bot] merged 7 commits intoflutter:masterfrom
Conversation
github-actions
bot
added
framework
guidezpl
approved these changes
Jun 5, 2024
Member
There was a problem hiding this comment.
suggest mentioning that medium and high contrast from the M3 guidelines correspond to 0.5 and 1.0 respectively. otherwise LGTM!
Contributor
Author
There was a problem hiding this comment.
Thanks for helping review this! Will update!
QuncCccccc
force-pushed
the
add_contrast_level
branch
from
a09622f to
57ab7fd
Compare
Contributor
Author
|
Once this is landed, will add the high-contrast |
QuncCccccc
added
the
autosubmit
chunhtai
reviewed
Jun 5, 2024
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, is there another pr to update the a11y app as well?
Contributor
Author
There was a problem hiding this comment.
Updated:) Thanks for the review!
chunhtai
approved these changes
Jun 5, 2024
QuncCccccc
removed
the
autosubmit
Contributor
Author
Yes! Will create another PR to add the high-contrast color scheme to the a11y assessment app. |
QuncCccccc
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/149705, due to - The status or check suite Windows framework_tests_widgets has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
QuncCccccc
force-pushed
the
add_contrast_level
branch
from
d197ec0 to
bfb4caa
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 6, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 6, 2024
flutter/flutter@27e0656...4608a89 2024-06-06 [email protected] Fix InputDecorator suffixIcon color when in error and hovered (flutter/flutter#149643) 2024-06-06 [email protected] Roll Flutter Engine from 32c3b9b7cbe1 to 92d0cd9370f7 (1 revision) (flutter/flutter#149789) 2024-06-06 [email protected] Roll Flutter Engine from 0edca2e9d3d2 to 32c3b9b7cbe1 (2 revisions) (flutter/flutter#149786) 2024-06-06 [email protected] Roll Flutter Engine from f51e0ad3abbe to 0edca2e9d3d2 (8 revisions) (flutter/flutter#149785) 2024-06-06 [email protected] Roll Flutter Engine from f37733035060 to f51e0ad3abbe (3 revisions) (flutter/flutter#149778) 2024-06-05 [email protected] Remove abi key from local golden file testing (flutter/flutter#149696) 2024-06-05 [email protected] Fixes Router transaction to respect operation order (flutter/flutter#149763) 2024-06-05 [email protected] Send q once (flutter/flutter#149767) 2024-06-05 [email protected] Marks Mac_ios rrect_blur_perf_ios__timeline_summary to be unflaky (flutter/flutter#149729) 2024-06-05 [email protected] Add `contrastLevel` parameter to `ColorScheme.fromSeed` (flutter/flutter#149705) 2024-06-05 [email protected] Roll Flutter Engine from 11a32d43e3f6 to f37733035060 (11 revisions) (flutter/flutter#149770) 2024-06-05 [email protected] Remove unused code from an older test artifact. (flutter/flutter#149746) 2024-06-05 [email protected] Create CarouselView widget - Part 1 (flutter/flutter#148094) 2024-06-05 [email protected] [flutter_tools] Remove additional listener on VM service that simply logged incoming messages (flutter/flutter#149756) 2024-06-05 [email protected] Fix signature for TokenTemplate.updateFile (flutter/flutter#149673) 2024-06-05 [email protected] Remove temporary LayoutBuilder migration flag, defer `markNeedsLayout` (flutter/flutter#149637) 2024-06-05 [email protected] Revert "make output of flutter run web tests verbose (#149694)" (flutter/flutter#149766) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add a parameter
contrastLeveltoColorScheme.fromSeedso that we can construct high contrastColorScheme.Screen.Recording.2024-06-04.at.5.57.15.PM.mov
Related to #149683
Pre-launch Checklist
///).