Revert "Reland 2: [CupertinoActionSheet] Match colors to native"#150142
Merged
yaakovschectman merged 1 commit intomasterfrom Jun 12, 2024
Merged
Revert "Reland 2: [CupertinoActionSheet] Match colors to native"#150142yaakovschectman merged 1 commit intomasterfrom
yaakovschectman merged 1 commit intomasterfrom
Conversation
)" This reverts commit bb9daf5.
Contributor
Author
|
Reason for revert: Gold tests failing |
Contributor
|
The error golden file is not introduced by this PR, but an earlier PR |
Contributor
Author
|
I am not quite following. What is it in that error log that indicates that this error file was introduced in an earlier PR? |
Contributor
Both golden files that failed were introdced, and were the only golden files introduced in #149471, which was also merged during the infra P0. The problem is, there is no way #150129 was merged with untriaged golden, even if I wanted to, because I used autosubmit to merge. The only explanation I can think of is that #149471 caused some inconsistency in the golden file database. |
hello-coder-xu
added a commit
to hello-coder-xu/flutter
that referenced
this pull request
Jun 13, 2024
…Extent-add-assert * master: Revert "Reland 2: [CupertinoActionSheet] Match colors to native" (flutter#150142) Reland 2: [CupertinoActionSheet] Match colors to native (flutter#150129)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 13, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
Reverts #149471. I will reland it without changes in the future. There have been CI post-submit errors reported, such as #150142, that the two golden files introduced in #149471 were untriaged. The only explanation I can think of is that #149471 being merged during the infra P0 left some inconsistency in the golden database.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 13, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 13, 2024
flutter/flutter@b1f9d71...01db23b 2024-06-13 [email protected] Roll Flutter Engine from c7fcbfce608f to 4cb3025d3abf (28 revisions) (flutter/flutter#150199) 2024-06-13 [email protected] Revert "[CupertinoActionSheet] Add sliding tap gesture" (flutter/flutter#150147) 2024-06-13 [email protected] RawScrollbar: don't listen for drag gestures when scrolling is not possible (flutter/flutter#149925) 2024-06-13 [email protected] Update testowners (flutter/flutter#150141) 2024-06-12 [email protected] Revert "Reland 2: [CupertinoActionSheet] Match colors to native" (flutter/flutter#150142) 2024-06-12 [email protected] Reland 2: [CupertinoActionSheet] Match colors to native (flutter/flutter#150129) 2024-06-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.6 to 4.1.7 (flutter/flutter#150132) 2024-06-12 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.8 to 3.25.9 (flutter/flutter#150133) 2024-06-12 [email protected] Improve build time when using SwiftPM (flutter/flutter#150052) 2024-06-12 [email protected] Reland: Request focus if accessibility focus is given to a Focus widget (#142942) (flutter/flutter#149840) 2024-06-12 [email protected] Update WidgetStatesController docs (flutter/flutter#150081) 2024-06-12 [email protected] [Reland] Fix `SegmentedButton` clipping when drawing segments (#149739) (flutter/flutter#150090) 2024-06-12 [email protected] Fix markdown hyperlinks in the style guide (flutter/flutter#150071) 2024-06-12 [email protected] Update packages desktop PR triage link lables (flutter/flutter#150124) 2024-06-12 [email protected] Add mouse cursor property to `CupertinoRadio` (flutter/flutter#149681) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…tter#150142) Reverts flutter#150129 Still introducing failure for flutter gold. The failure and error messages are specifically pointing to the test file modified by this commit. See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8745296364911252625/+/u/run_test.dart_for_framework_tests_shard_and_subshard_libraries/stdout
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
Reverts flutter#149471. I will reland it without changes in the future. There have been CI post-submit errors reported, such as flutter#150142, that the two golden files introduced in flutter#149471 were untriaged. The only explanation I can think of is that flutter#149471 being merged during the infra P0 left some inconsistency in the golden database.
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
…tter#150142) Reverts flutter#150129 Still introducing failure for flutter gold. The failure and error messages are specifically pointing to the test file modified by this commit. See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8745296364911252625/+/u/run_test.dart_for_framework_tests_shard_and_subshard_libraries/stdout
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
Reverts flutter#149471. I will reland it without changes in the future. There have been CI post-submit errors reported, such as flutter#150142, that the two golden files introduced in flutter#149471 were untriaged. The only explanation I can think of is that flutter#149471 being merged during the infra P0 left some inconsistency in the golden database.
dkwingsmt
added a commit
to dkwingsmt/flutter
that referenced
this pull request
Jun 17, 2024
…utter#150142) This reverts commit 7b6d667.
9 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
Relands #149568 (first attempt) or #150129 (latest attempt), which was reverted in #150142 due to unverified golden tests post-commit from recent infra issues. No code is changed from #150129. The relevant golden files have been resubmitted in #150219. I expect these files to appear in the golden file checker in this PR (which will hint that this PR is safe.) Fingers crossed.
9 tasks
auto-submit bot
added a commit
that referenced
this pull request
Jun 18, 2024
…0386)" (#150413) Reverts: #150386 Initiated by: andrewkolos Reason for reverting: the Mac framework_tests_impeller check has been failing (due to golden test failures) since this PR (though it occasionally passes after retry). Taking a brief look at this PR, it looks like there's been some troubles with goldens in the past (though the recent failures appear very different to past ones). Regardless, I'm taking a shot at getting the tree green again by reverting this. Apologies i Original PR Author: dkwingsmt Reviewed By: {chunhtai} This change reverts the following previous change: Relands #149568 (first attempt) or #150129 (latest attempt), which was reverted in #150142 due to unverified golden tests post-commit from recent infra issues. No code is changed from #150129. The relevant golden files have been resubmitted in #150219. I expect these files to appear in the golden file checker in this PR (which will hint that this PR is safe.) Fingers crossed.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #150129
Still introducing failure for flutter gold. The failure and error messages are specifically pointing to the test file modified by this commit.
See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8745296364911252625/+/u/run_test.dart_for_framework_tests_shard_and_subshard_libraries/stdout