Add test for inherited_notifier.0.dart by ValentinVignal · Pull Request #150344 · flutter/flutter

ValentinVignal · 2024-06-17T10:07:21Z

Contributes to #130459

It adds a test for

examples/api/lib/widgets/inherited_notifier/inherited_notifier.0.dart

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

bleroux

Thanks for the contribution!
Because this test is somewhat difficult to read, I proposed some changes, especially introducing an utility matcher.

bleroux · 2024-06-20T06:48:55Z

examples/api/test/widgets/inherited_notifier/inherited_notifier.0_test.dart

+      const example.InheritedNotifierExampleApp(),
+    );
+
+    final Iterable<Transform> widgets = tester.widgetList<Transform>(find.ancestor(of: find.text('Whee!'), matching: find.byType(Transform)));


Suggested change

final Iterable<Transform> widgets = tester.widgetList<Transform>(find.ancestor(of: find.text('Whee!'), matching: find.byType(Transform)));

final Iterable<Transform> widgets = tester.widgetList<Transform>(

find.ancestor(of: find.text('Whee!'),

matching: find.byType(Transform),

));

For readability, consider using multiline and adding an empty line.

Sure, I updated it in refactor: Use a utils matcher

bleroux · 2024-06-20T06:53:53Z

examples/api/test/widgets/inherited_notifier/inherited_notifier.0_test.dart

+    );
+
+    final Iterable<Transform> widgets = tester.widgetList<Transform>(find.ancestor(of: find.text('Whee!'), matching: find.byType(Transform)));
+    expect(widgets, everyElement(isA<Transform>().having((Transform widget) => widget.transform, 'transform', Matrix4.identity())));


To reduce verbosity, consider using an utility matcher, such as:

Suggested change

expect(widgets, everyElement(isA<Transform>().having((Transform widget) => widget.transform, 'transform', Matrix4.identity())));

Matcher transforms(Matrix4 matrix) {

return everyElement(isA<Transform>().having((Transform widget) => widget.transform, 'transform', matrix));

}

expect(widgets, transforms(Matrix4.identity()));

Not sure about the name, maybe we can find a better one.

What do you think of refactor: Use a utils matcher ?

bleroux

LGTM! Thanks for pursuing this effort 🙏

I spotted one small typo.

examples/api/test/widgets/inherited_notifier/inherited_notifier.0_test.dart

TahaTesser

LGTM

auto-submit · 2024-06-20T10:58:29Z

auto label is removed for flutter/flutter/150344, due to - The status or check suite Mac plugin_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.

…r.0_test.dart Co-authored-by: Bruno Leroux <[email protected]>

* master: (213 commits) Fix: Memory leak in UndoHistory widget because it never de-registered itself as global UndoManager client (Resolves flutter#148291) (flutter#150661) [CupertinoActionSheet] Fix the layout (part 1) (flutter#149636) Remove discontinued `device_info` and `connectivity` plugins from `flutter_gallery`, roll pub packages (flutter#150585) [a11y] Update semantics in bottom_navigation_bar.dart (flutter#150576) Roll Flutter Engine from dda82d9 to 33415c6 (7 revisions) (flutter#150637) Reland 4: [CupertinoActionSheet] Match colors to native (flutter#150442) Enable SelectionArea double tap/triple tap gesture support for mobile platforms (flutter#149295) made SelectionArea alignment consistent between web and other platform (flutter#150037) Fix link hook typo (flutter#150194) Stop looking for .packages when analyzing (flutter#150349) Update flutter.dev links from misc packages to more permanent destinations (flutter#150532) Roll Flutter Engine from dd37cef to dda82d9 (9 revisions) (flutter#150582) Update Material token to the latest 4.1.0 (flutter#150382) Let the lockfile script generate lockfiles for kotlin gradle files as well (flutter#150471) Make popup menu hardcoded padding configurable (flutter#150506) [flutter_tools] un-hide the --dds flag (flutter#150280) [material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. (flutter#149586) Add test for inherited_notifier.0.dart (flutter#150344) [CLI tool] in `flutter test`, consider `--flavor` when validating the cached asset bundle (flutter#150461) Test InputDecoration API examples (flutter#148560) ...

…ileTheme * master: (88 commits) Fix: Memory leak in UndoHistory widget because it never de-registered itself as global UndoManager client (Resolves flutter#148291) (flutter#150661) [CupertinoActionSheet] Fix the layout (part 1) (flutter#149636) Remove discontinued `device_info` and `connectivity` plugins from `flutter_gallery`, roll pub packages (flutter#150585) [a11y] Update semantics in bottom_navigation_bar.dart (flutter#150576) Roll Flutter Engine from dda82d9 to 33415c6 (7 revisions) (flutter#150637) Reland 4: [CupertinoActionSheet] Match colors to native (flutter#150442) Enable SelectionArea double tap/triple tap gesture support for mobile platforms (flutter#149295) made SelectionArea alignment consistent between web and other platform (flutter#150037) Fix link hook typo (flutter#150194) Stop looking for .packages when analyzing (flutter#150349) Update flutter.dev links from misc packages to more permanent destinations (flutter#150532) Roll Flutter Engine from dd37cef to dda82d9 (9 revisions) (flutter#150582) Update Material token to the latest 4.1.0 (flutter#150382) Let the lockfile script generate lockfiles for kotlin gradle files as well (flutter#150471) Make popup menu hardcoded padding configurable (flutter#150506) [flutter_tools] un-hide the --dds flag (flutter#150280) [material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. (flutter#149586) Add test for inherited_notifier.0.dart (flutter#150344) [CLI tool] in `flutter test`, consider `--flavor` when validating the cached asset bundle (flutter#150461) Test InputDecoration API examples (flutter#148560) ...

Roll Flutter from 6c06abb to e726eb4 (51 revisions) flutter/flutter@6c06abb...e726eb4 2024-06-25 [email protected] Roll Packages from 711b4ac to 03f5f6d (21 revisions) (flutter/flutter#150779) 2024-06-25 [email protected] Roll Flutter Engine from afa7ce19bca8 to fbd92055f3a6 (1 revision) (flutter/flutter#150777) 2024-06-25 [email protected] Reland Add tests for form_text_field.1.dart (#150481) (#150696) (flutter/flutter#150750) 2024-06-25 [email protected] Add an example for CupertinoPopupSurface (flutter/flutter#150357) 2024-06-25 [email protected] [flutter_tools/dap] Handle app.stop errors when launching/attaching (flutter/flutter#149734) 2024-06-25 [email protected] Roll Flutter Engine from be7db94196fe to afa7ce19bca8 (18 revisions) (flutter/flutter#150762) 2024-06-25 [email protected] Remove dubious comment (flutter/flutter#150608) 2024-06-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual engine roll to 6884e83 (#150733)" (flutter/flutter#150746) 2024-06-25 [email protected] Manual engine roll to 6884e83 (flutter/flutter#150733) 2024-06-24 [email protected] Linkify 'see also' sections (flutter/flutter#150734) 2024-06-24 [email protected] Roll pub packages (flutter/flutter#150712) 2024-06-24 [email protected] Update flutter.dev links from framework to more permanent destinations (flutter/flutter#150531) 2024-06-24 [email protected] Manual engine roll to be7db94196fe (flutter/flutter#150714) 2024-06-24 [email protected] allow adb to set canfail then use canFail=true for clearing logs (flutter/flutter#150517) 2024-06-24 [email protected] Update android_device.dart to have clearLogs not print to standard error (flutter/flutter#150197) 2024-06-24 [email protected] Update issue link in analysis_options.yaml (flutter/flutter#150395) 2024-06-24 [email protected] Fix a number of broken doc comment references (flutter/flutter#150540) 2024-06-24 [email protected] Fix flaky sliver tree test (flutter/flutter#150707) 2024-06-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add tests for form_text_field.1.dart (#150481)" (flutter/flutter#150696) 2024-06-24 [email protected] Add tests for form_text_field.1.dart (flutter/flutter#150481) 2024-06-22 [email protected] Fix: Memory leak in UndoHistory widget because it never de-registered itself as global UndoManager client (Resolves #148291) (flutter/flutter#150661) 2024-06-22 [email protected] [CupertinoActionSheet] Fix the layout (part 1) (flutter/flutter#149636) 2024-06-21 [email protected] Remove discontinued `device_info` and `connectivity` plugins from `flutter_gallery`, roll pub packages (flutter/flutter#150585) 2024-06-21 [email protected] [a11y] Update semantics in bottom_navigation_bar.dart (flutter/flutter#150576) 2024-06-21 [email protected] Roll Flutter Engine from dda82d905f37 to 33415c6ee7c2 (7 revisions) (flutter/flutter#150637) 2024-06-21 [email protected] Reland 4: [CupertinoActionSheet] Match colors to native (flutter/flutter#150442) 2024-06-21 [email protected] Enable SelectionArea double tap/triple tap gesture support for mobile platforms (flutter/flutter#149295) 2024-06-21 [email protected] made SelectionArea alignment consistent between web and other platform (flutter/flutter#150037) 2024-06-21 [email protected] Fix link hook typo (flutter/flutter#150194) 2024-06-21 [email protected] Stop looking for .packages when analyzing (flutter/flutter#150349) 2024-06-20 [email protected] Update flutter.dev links from misc packages to more permanent destinations (flutter/flutter#150532) 2024-06-20 [email protected] Roll Flutter Engine from dd37cefd4a94 to dda82d905f37 (9 revisions) (flutter/flutter#150582) 2024-06-20 [email protected] Update Material token to the latest 4.1.0 (flutter/flutter#150382) 2024-06-20 [email protected] Let the lockfile script generate lockfiles for kotlin gradle files as well (flutter/flutter#150471) 2024-06-20 [email protected] Make popup menu hardcoded padding configurable (flutter/flutter#150506) 2024-06-20 [email protected] [flutter_tools] un-hide the --dds flag (flutter/flutter#150280) 2024-06-20 [email protected] [material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. (flutter/flutter#149586) 2024-06-20 [email protected] Add test for inherited_notifier.0.dart (flutter/flutter#150344) 2024-06-20 [email protected] [CLI tool] in `flutter test`, consider `--flavor` when validating the cached asset bundle (flutter/flutter#150461) 2024-06-20 [email protected] Test InputDecoration API examples (flutter/flutter#148560) 2024-06-20 [email protected] Clean leaky tests. (flutter/flutter#150335) 2024-06-20 [email protected] Roll Flutter Engine from f9c497f178d3 to dd37cefd4a94 (2 revisions) (flutter/flutter#150537) 2024-06-20 [email protected] Roll Flutter Engine from a31279381b40 to f9c497f178d3 (9 revisions) (flutter/flutter#150528) 2024-06-19 [email protected] Add tests for about_list_tile.0.dart (flutter/flutter#150181) 2024-06-19 [email protected] Roll Flutter Engine from 0ad18fe4c0b5 to a31279381b40 (7 revisions) (flutter/flutter#150473) 2024-06-18 [email protected] Revert "[a11y] Add semantics: button to bottom navigation bar items and dropdown menu items" (flutter/flutter#150445) ...

Contributes to flutter#130459 It adds a test for - `examples/api/lib/widgets/inherited_notifier/inherited_notifier.0.dart`

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jun 17, 2024

goderbauer requested review from TahaTesser and bleroux June 18, 2024 22:03

bleroux reviewed Jun 20, 2024

View reviewed changes

bleroux approved these changes Jun 20, 2024

View reviewed changes

examples/api/test/widgets/inherited_notifier/inherited_notifier.0_test.dart Outdated Show resolved Hide resolved

TahaTesser approved these changes Jun 20, 2024

View reviewed changes

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 20, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 20, 2024

ValentinVignal and others added 3 commits June 20, 2024 18:51

test: Add test for inherited notifier

52f1949

refactor: Use a utils matcher

843a8e2

Update examples/api/test/widgets/inherited_notifier/inherited_notifie…

e075aa1

…r.0_test.dart Co-authored-by: Bruno Leroux <[email protected]>

bleroux force-pushed the flutter/api/example/Add-test-for-inherited-notifier branch from 1ba09f3 to e075aa1 Compare June 20, 2024 16:51

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 20, 2024

auto-submit bot merged commit b3dc24c into flutter:master Jun 20, 2024

engine-flutter-autoroll mentioned this pull request Jun 20, 2024

Roll Flutter from 6c06abbb5576 to 80a65bd781bc (16 revisions) flutter/packages#6960

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 20, 2024

b3dc24c Add test for inherited_notifier.0.dart (flutter/flutter#150344)

5292ac2

engine-flutter-autoroll mentioned this pull request Jun 21, 2024

Roll Flutter from 6c06abbb5576 to a3f6a2bdc7e6 (23 revisions) flutter/packages#6966

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 21, 2024

b3dc24c Add test for inherited_notifier.0.dart (flutter/flutter#150344)

968aba9

engine-flutter-autoroll mentioned this pull request Jun 21, 2024

Roll Flutter from 6c06abbb5576 to 9056c0b192bd (24 revisions) flutter/packages#6968

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 21, 2024

b3dc24c Add test for inherited_notifier.0.dart (flutter/flutter#150344)

d9d6534

engine-flutter-autoroll mentioned this pull request Jun 21, 2024

Roll Flutter from 6c06abbb5576 to 20459dda0d6d (25 revisions) flutter/packages#6969

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 21, 2024

b3dc24c Add test for inherited_notifier.0.dart (flutter/flutter#150344)

587576a

engine-flutter-autoroll mentioned this pull request Jun 22, 2024

Roll Flutter from 6c06abbb5576 to 4a84fb0fea9d (29 revisions) flutter/packages#6971

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 22, 2024

b3dc24c Add test for inherited_notifier.0.dart (flutter/flutter#150344)

45cf2ff

engine-flutter-autoroll mentioned this pull request Jun 22, 2024

Roll Flutter from 6c06abbb5576 to 88e6f6297487 (30 revisions) flutter/packages#6972

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 22, 2024

b3dc24c Add test for inherited_notifier.0.dart (flutter/flutter#150344)

6f8bf6a

engine-flutter-autoroll mentioned this pull request Jun 23, 2024

Roll Flutter from 6c06abbb5576 to 1cb003b8fb45 (31 revisions) flutter/packages#6974

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2024

b3dc24c Add test for inherited_notifier.0.dart (flutter/flutter#150344)

a8cbf59

engine-flutter-autoroll mentioned this pull request Jun 23, 2024

Roll Flutter from 6c06abbb5576 to 1cb003b8fb45 (31 revisions) flutter/packages#6975

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 23, 2024

b3dc24c Add test for inherited_notifier.0.dart (flutter/flutter#150344)

b6e0573

engine-flutter-autoroll mentioned this pull request Jun 24, 2024

Roll Flutter from 6c06abbb5576 to 70e9b4185e3d (33 revisions) flutter/packages#6977

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2024

b3dc24c Add test for inherited_notifier.0.dart (flutter/flutter#150344)

d01053a

engine-flutter-autoroll mentioned this pull request Jun 24, 2024

Roll Flutter from 6c06abbb5576 to 70e9b4185e3d (33 revisions) flutter/packages#6978

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 24, 2024

b3dc24c Add test for inherited_notifier.0.dart (flutter/flutter#150344)

45486d9

engine-flutter-autoroll mentioned this pull request Jun 25, 2024

Roll Flutter from 6c06abbb5576 to 93c14565f0ec (49 revisions) flutter/packages#6985

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2024

b3dc24c Add test for inherited_notifier.0.dart (flutter/flutter#150344)

eb8b01c

engine-flutter-autoroll mentioned this pull request Jun 25, 2024

Roll Flutter from 6c06abbb5576 to f90f40a86619 (50 revisions) flutter/packages#6986

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2024

b3dc24c Add test for inherited_notifier.0.dart (flutter/flutter#150344)

43588ab

engine-flutter-autoroll mentioned this pull request Jun 25, 2024

Roll Flutter from 6c06abbb5576 to e726eb401c2c (51 revisions) flutter/packages#6987

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 25, 2024

b3dc24c Add test for inherited_notifier.0.dart (flutter/flutter#150344)

1911456

sigurdm pushed a commit to sigurdm/flutter that referenced this pull request Jun 26, 2024

Add test for inherited_notifier.0.dart (flutter#150344)

1a0f625

Contributes to flutter#130459 It adds a test for - `examples/api/lib/widgets/inherited_notifier/inherited_notifier.0.dart`

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

b3dc24c Add test for inherited_notifier.0.dart (flutter/flutter#150344)

7edb59e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test for inherited_notifier.0.dart#150344

Add test for inherited_notifier.0.dart#150344
auto-submit[bot] merged 3 commits intoflutter:masterfrom
ValentinVignal:flutter/api/example/Add-test-for-inherited-notifier

ValentinVignal commented Jun 17, 2024

Uh oh!

bleroux left a comment

Uh oh!

bleroux Jun 20, 2024

Uh oh!

ValentinVignal Jun 20, 2024

Uh oh!

bleroux Jun 20, 2024

Uh oh!

ValentinVignal Jun 20, 2024

Uh oh!

bleroux left a comment

Uh oh!

Uh oh!

TahaTesser left a comment

Uh oh!

auto-submit bot commented Jun 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-    expect(widgets, everyElement(isA<Transform>().having((Transform widget) => widget.transform, 'transform', Matrix4.identity())));
+    Matcher transforms(Matrix4 matrix) {
+      return everyElement(isA<Transform>().having((Transform widget) => widget.transform, 'transform', matrix));
+    }
+    expect(widgets, transforms(Matrix4.identity()));

Conversation

ValentinVignal commented Jun 17, 2024

Pre-launch Checklist

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

bleroux Jun 20, 2024

Choose a reason for hiding this comment

Uh oh!

ValentinVignal Jun 20, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux Jun 20, 2024

Choose a reason for hiding this comment

Uh oh!

ValentinVignal Jun 20, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jun 20, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants