Fix flaky complex_layout_scroll_perf__memory & flutter_gallery__memory_nav#150368
Merged
auto-submit[bot] merged 4 commits intoflutter:masterfrom Jun 17, 2024
Merged
Fix flaky complex_layout_scroll_perf__memory & flutter_gallery__memory_nav#150368auto-submit[bot] merged 4 commits intoflutter:masterfrom
auto-submit[bot] merged 4 commits intoflutter:masterfrom
Conversation
Initial tap is missing sometimes; either its never delivered or it is delivered before gesture controller is hooked up. 1: Update the two perf tests to output when TAPPED is received 2: Update the MemoryTest to keep tapping while waiting for TAPPED Tested on devicelab: * setting iterations=1 * removing the timeout before READY * running tests in a while loop Before this change, you could get the test to hang often. After this change you'll see "tapping device... [x]" where x is the counter. Fixes flutter#150096
Co-authored-by: gaaclarke <[email protected]>
Initial tap is missing sometimes; either its never delivered or it is delivered before gesture controller is hooked up. 1: Update MemoryTest to have option `requiresTapToStart` guarding the new paths 2: Update the two perf tests that appear to be flaky to output when TAPPED is received 3: Update the MemoryTest to keep tapping while waiting for TAPPED Tested on devicelab: * setting iterations=1 * removing the timeout before READY * running tests in a while loop Before this change, you could get the test to hang often. After this change you'll see "tapping device... [x]" where x is the counter. Fixes flutter#150096
jtmcdole
added
autosubmit
Member
|
note: the previous PR that fixed this was reverted: #150287 |
Member
Author
I should have noted that. Was following the hygiene document and trying not to use "reland":
The revert was here #150293 |
gaaclarke
approved these changes
Jun 17, 2024
Member
gaaclarke
left a comment
gaaclarke
left a comment
There was a problem hiding this comment.
Code looks good to me. It still bothers me we have to do this. I feel like there has to be an appropriate proxy or callback for this. Like, is it possible that a frame has been rendered but the gesture recognizers have not been installed?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 17, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 17, 2024
flutter/flutter@5187cab...ccf3abe 2024-06-17 [email protected] Roll Flutter Engine from 2218a4566765 to 5989f0215fed (9 revisions) (flutter/flutter#150373) 2024-06-17 [email protected] Update API docs footer (flutter/flutter#150347) 2024-06-17 [email protected] Update old wiki links (flutter/flutter#149544) 2024-06-17 [email protected] Fix flaky complex_layout_scroll_perf__memory & flutter_gallery__memory_nav (flutter/flutter#150368) 2024-06-17 [email protected] Roll Packages from dd04ab1 to 711b4ac (3 revisions) (flutter/flutter#150359) 2024-06-17 [email protected] Roll Flutter Engine from 9779c273aac3 to 2218a4566765 (3 revisions) (flutter/flutter#150298) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial tap is missing sometimes; either its never delivered or it is
delivered before gesture controller is hooked up.
1: Update MemoryTest to have option
requiresTapToStartguarding thenew paths
2: Update the two perf tests that appear to be flaky to output when
TAPPED is received
3: Update the MemoryTest to keep tapping while waiting for TAPPED
Tested on devicelab:
Before this change, you could get the test to hang often. After this
change you'll see "tapping device... [x]" where x is the counter.
Fixes #150096