Closed
Conversation
github-actions
bot
added
a: tests
Member
Author
|
Looks like there is just one failing test, the test that builds |
8 tasks
Merged
8 tasks
auto-submit bot
added a commit
to flutter/engine
that referenced
this pull request
Jun 19, 2024
…53462)" (#53468) Reverts: #53462 Initiated by: gmackall Reason for reverting: blocking roll (see flutter/flutter#150465 (comment)). Original PR Author: gmackall Reviewed By: {reidbaker} This change reverts the following previous change: Relands #53001. Also pulls in @matanlurey's dependency on `androidx.lifecycle:lifecycle-process`, and upgrades it to `2.7.0`. It is unblocked by the changes in flutter/flutter#149204. Tested by building the engine, and then also by building the `flutter/packages` `all_packages` app on this branch, so that hopefully it will also roll smoothly into the packages repo. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Member
Author
|
I think I remember this issue as being related to the |
Contributor
|
FWIW the google testing bug looks unrelated. |
Member
Author
|
This is indeed caused by the fact that Reference b/213599629 |
… into manual_engine_land
9 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 21, 2024
…utter_gallery`, roll pub packages (#150585) Removes these two discontinued plugins from `dev/integration_tests/flutter_gallery` [`device_info`](https://pub.dev/packages/device_info): Apparently the video playback doesn't work on iOS simulators (I wasn't able to verify this, as I don't have an iOS simulator installed). I removed the guard against running on those simulators, and replaced with a note in the README. [`connectivity`](https://pub.dev/packages/connectivity): This plugin was used to play the bee video from the network. I changed the demo so that the bee video is instead also played from an asset (like its friend the butterfly), and then removed the use of the plugin. Unblocks the re-land of flutter/engine#53462 (itself a reland ð���), because of #150465 (comment).
sigurdm
pushed a commit
to sigurdm/flutter
that referenced
this pull request
Jun 26, 2024
…utter_gallery`, roll pub packages (flutter#150585) Removes these two discontinued plugins from `dev/integration_tests/flutter_gallery` [`device_info`](https://pub.dev/packages/device_info): Apparently the video playback doesn't work on iOS simulators (I wasn't able to verify this, as I don't have an iOS simulator installed). I removed the guard against running on those simulators, and replaced with a note in the README. [`connectivity`](https://pub.dev/packages/connectivity): This plugin was used to play the bee video from the network. I changed the demo so that the bee video is instead also played from an asset (like its friend the butterfly), and then removed the use of the plugin. Unblocks the re-land of flutter/engine#53462 (itself a reland ð���), because of flutter#150465 (comment).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drafting a manual takeover of #150458, to see if re-generating all the lockfiles will fix the problems with the roll.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.