Remove all usages of the deprecated usage package#150667
Closed
andrewkolos wants to merge 10 commits intoflutter:masterfrom
Closed
Remove all usages of the deprecated usage package#150667andrewkolos wants to merge 10 commits intoflutter:masterfrom
usage package#150667andrewkolos wants to merge 10 commits intoflutter:masterfrom
Conversation
ce672fb to
ed3c7e1
Compare
7074df6 to
6bf9e6c
Compare
andrewkolos
commented
Jun 26, 2024
Contributor
Author
|
This will be succeeded by smaller PRs to make this change more reviewable. |
This was referenced Jul 8, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 8, 2024
…unset) override by default (#151357) While exploring #107607, I noticed that flutter_tools test results change based on whether `dart test` is run from a terminal or from a process (such as a Dart program). I also ran into this while writing tests for #150667. This is due to tests that rely on the global `Stdio` instance, on which the `hasTerminal` property depends on whether the tool is being invoked from a terminal. Ideally, `testUsingContext` would require any tests that depend on `globals.stdio` to define an override for `Stdio`, but this is not the case. Until a solution to this more general problem is figured out, I think we should have `testUsingContext` always provide a `Stdio` override by default.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #150575.
Also fixes #150665.
Also fixes #150663.
Pre-launch Checklist
///).