[CP] Fix Linux numpad shortcuts on web#150723
Conversation
## Description This PRs fixes a Web issue on Linux related to numpad keys. In flutter#145464, I introduced numpad shortcuts for Linux. These shortcuts work well on a desktop Linux application but they broke the Linux+Web numpad logic. When I added these shortcuts, I expected them to not be active on Web (because I knew that on Web, those shortcuts are handled by the browser). But there is a trick: text editing shortcuts are still defined on Web but they are disabled at the editable text level so one can use them in components that are not `EditableText` (see flutter#103377). In this PR, I used the same approach than for other text editing shortcuts: when on web associate those shortcuts to the `DoNothingAndStopPropagationTextIntent` intent. ## Related Issue Fixes flutter#148447. ## Tests Updates 2 tests. Adds 2 tests.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
a: text input
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
CP LGTM 👍 This should be a very low risk cherry pick. What do you think @itsjustkevin?
|
@justinmc and @m3c-fnicola is there an associated cherry-pick issue with this cherry-pick? I can't seem to find any information. |
I take it back, found it here 🙃 |
itsjustkevin
added
the
autosubmit
4 participants
Cherry pick request of #148988 to stable.
Fixes an issue on Web+Linux that prevents users from inputting data using the numpad.