[tool] make `ErrorHandlingFileSystem.deleteIfExists` catch error code 3 (`ERROR_PATH_NOT_FOUND` on Windows) by andrewkolos · Pull Request #150741 · flutter/flutter

andrewkolos · 2024-06-25T00:00:58Z

FYI I plan to cherry-pick this

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

andrewkolos · 2024-06-25T00:01:49Z

packages/flutter_tools/lib/src/base/error_handling_io.dart

+      // This check will falsely match "3/ESRCH: No such process" on Linux/macOS,
+      // but this should be fine since this code should never come up here.


If this is a bit too smelly for your taste, please read #150736 (comment)

Why do you say "this code should never come up here"? Are you saying that we should never hit a "no such process" error on unix-like operating systems when calling deleteIfExists?

(We talked about this in-person. I'm commenting here for posterity's sake). Yes, that's my hope. I'm assuming 3/ESRCH is never set by a file op. I'm assuming this code is used by Linux utilities that act on processes rather than files.

christopherfujino

LGTM

… 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter#150741) Resolves flutter#150736 FYI I plan to cherry-pick this

* master: (23 commits) Roll pub packages (flutter#150810) Remove reference to `MaterialApp` and `showCupertinoModalPopup` from `CupertinoAlertDialog` (flutter#150725) Read `AndroidManifest.xml` and emit `manifest-impeller-(enabled|disabled)` analytics (flutter#150791) [flutter_tools] Shut down Chromium cleanly using a command sent through the debug protocol (flutter#150645) Reland fix inputDecorator hint color on M3 (flutter#150278) Roll Flutter Engine from 62e0b5f to 94023d7 (7 revisions) (flutter#150797) Fix collapsed InputDecorator minimum height (flutter#150770) Add more warm up frame docs (flutter#150464) Roll pub packages (flutter#150739) Add `focusNode`, `focusColor`, `onFocusChange`, `autofocus` to `CupertinoButton` (flutter#150721) Document RenderObject._relayoutBoundary and its invariant; small refactors (flutter#150527) Roll Flutter Engine from 6313b1e to 62e0b5f (1 revision) (flutter#150790) fix a typo (flutter#150682) Fix link in RenderObjectWidget doc comment (flutter#150600) Roll Flutter Engine from fbd9205 to 6313b1e (1 revision) (flutter#150781) [tool] make `ErrorHandlingFileSystem.deleteIfExists` catch error code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter#150741) Roll Packages from 711b4ac to 03f5f6d (21 revisions) (flutter#150779) Roll Flutter Engine from afa7ce1 to fbd9205 (1 revision) (flutter#150777) Reland Add tests for form_text_field.1.dart (flutter#150481) (flutter#150696) (flutter#150750) Add an example for CupertinoPopupSurface (flutter#150357) ...

…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)

andrewkolos added 2 commits June 24, 2024 16:55

init

fb9f900

formatting oops

2cd89c7

andrewkolos added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 25, 2024

andrewkolos commented Jun 25, 2024

View reviewed changes

andrewkolos changed the title ~~make ErrorHandlingFileSystem.deleteIfExists catch error code 3 (ERROR_PATH_NOT_FOUND on Windows)~~ [tool] make ErrorHandlingFileSystem.deleteIfExists catch error code 3 (ERROR_PATH_NOT_FOUND on Windows) Jun 25, 2024

andrewkolos marked this pull request as ready for review June 25, 2024 00:04

andrewkolos requested a review from christopherfujino June 25, 2024 00:04

christopherfujino approved these changes Jun 25, 2024

View reviewed changes

andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2024

tiny refactor

2f569b9

This comment was marked as outdated.

Sign in to view

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2024

andrewkolos added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 25, 2024

auto-submit bot merged commit d520f07 into flutter:master Jun 25, 2024

andrewkolos added the cp: stable cherry pick this pull request to stable release candidate branch label Jun 25, 2024

engine-flutter-autoroll mentioned this pull request Jun 26, 2024

Roll Flutter from e726eb401c2c to 00f94830364b (21 revisions) flutter/packages#6991

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2024

d520f07 [tool] make ErrorHandlingFileSystem.deleteIfExists catch er…

5897f14

…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)

engine-flutter-autoroll mentioned this pull request Jun 26, 2024

Roll Flutter from e726eb401c2c to 00f94830364b (21 revisions) flutter/packages#6993

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2024

d520f07 [tool] make ErrorHandlingFileSystem.deleteIfExists catch er…

6032c43

…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)

engine-flutter-autoroll mentioned this pull request Jun 26, 2024

Roll Flutter from e726eb401c2c to 05f294c7116f (22 revisions) flutter/packages#6994

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 26, 2024

d520f07 [tool] make ErrorHandlingFileSystem.deleteIfExists catch er…

6573ea4

…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)

engine-flutter-autoroll mentioned this pull request Jun 27, 2024

Roll Flutter from e726eb401c2c to ef34436402be (39 revisions) flutter/packages#6996

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2024

d520f07 [tool] make ErrorHandlingFileSystem.deleteIfExists catch er…

a0832b8

…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)

engine-flutter-autoroll mentioned this pull request Jun 27, 2024

Roll Flutter from e726eb401c2c to ba03c59406c7 (40 revisions) flutter/packages#6999

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2024

d520f07 [tool] make ErrorHandlingFileSystem.deleteIfExists catch er…

633dc48

…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)

engine-flutter-autoroll mentioned this pull request Jun 27, 2024

Roll Flutter from e726eb401c2c to ab4d42221349 (42 revisions) flutter/packages#7000

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2024

d520f07 [tool] make ErrorHandlingFileSystem.deleteIfExists catch er…

729c7ed

…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

d520f07 [tool] make ErrorHandlingFileSystem.deleteIfExists catch er…

92f7524

…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

d520f07 [tool] make ErrorHandlingFileSystem.deleteIfExists catch er…

00bf40a

…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

d520f07 [tool] make ErrorHandlingFileSystem.deleteIfExists catch er…

e934077

…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

d520f07 [tool] make ErrorHandlingFileSystem.deleteIfExists catch er…

f9c3c95

…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

d520f07 [tool] make ErrorHandlingFileSystem.deleteIfExists catch er…

cebec57

…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

d520f07 [tool] make ErrorHandlingFileSystem.deleteIfExists catch er…

637f8b7

…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)

andrewkolos deleted the catch-error-3-in-deleteIfExists branch July 22, 2024 04:41

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

d520f07 [tool] make ErrorHandlingFileSystem.deleteIfExists catch er…

2db7c3b

…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[tool] make `ErrorHandlingFileSystem.deleteIfExists` catch error code 3 (`ERROR_PATH_NOT_FOUND` on Windows)#150741

[tool] make `ErrorHandlingFileSystem.deleteIfExists` catch error code 3 (`ERROR_PATH_NOT_FOUND` on Windows)#150741
auto-submit[bot] merged 3 commits intoflutter:masterfrom
andrewkolos:catch-error-3-in-deleteIfExists

andrewkolos commented Jun 25, 2024 •

edited

Loading

Uh oh!

andrewkolos Jun 25, 2024 •

edited

Loading

Uh oh!

christopherfujino Jun 25, 2024

Uh oh!

andrewkolos Jun 25, 2024

Uh oh!

christopherfujino left a comment

Uh oh!

This comment was marked as outdated.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		// This check will falsely match "3/ESRCH: No such process" on Linux/macOS,
		// but this should be fine since this code should never come up here.

Conversation

andrewkolos commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

andrewkolos Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

christopherfujino Jun 25, 2024

Choose a reason for hiding this comment

Uh oh!

andrewkolos Jun 25, 2024

Choose a reason for hiding this comment

Uh oh!

christopherfujino left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

andrewkolos commented Jun 25, 2024 •

edited

Loading

andrewkolos Jun 25, 2024 •

edited

Loading