Add 'direction' allow to 'SegmentedButton' vertically#150854
Closed
abdalmonem wants to merge 6 commits intoflutter:masterfrom
abdalmonem:master
Closed
Add 'direction' allow to 'SegmentedButton' vertically#150854abdalmonem wants to merge 6 commits intoflutter:masterfrom abdalmonem:master
abdalmonem wants to merge 6 commits intoflutter:masterfrom
abdalmonem:master
Conversation
github-actions
bot
added
framework
Piinks
reviewed
Jun 26, 2024
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Hey @abdalmonem thanks for contributing! It looks like the autoformatter may have been run over some of this code, can you revert that? The flutter repo does not use the autoformatter: https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md#in-defense-of-the-extra-work-that-hand-formatting-entails
Contributor
Author
|
Heeeey @Piinks , and yah sure i will , but i am facing another issue with Github automated linux analyzer, and i am working on. |
Contributor
Hey! From the error message, looks like we juts need to add a type for |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add the ability to change buttons of 'SegmentedButton' directionality (In the vertical and horizontal axis) to be 'vertical' or 'horizontal' instead of just horizontally position by adding "direction" argument.
direction: Axis.horizontaldirection: Axis.verticalNotice: in this example i used:
style: ButtonStyle( shape: MaterialStateProperty.all<RoundedRectangleBorder>( const RoundedRectangleBorder( borderRadius: BorderRadius.zero, ), ), )To change the Radius of
SegmentedButton, and the default will be like:I keep it as it is , cause its not the main purpose of this BR.
List which issues are fixed by this PR. You must list at least one issue. An issue is not required if the PR fixes something trivial like a typo.
Fixes #150416
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.