Add tests for material_state_border_side.0_test.dart#151089
Merged
auto-submit[bot] merged 4 commits intoflutter:masterfrom Jul 8, 2024
Merged
Conversation
github-actions
bot
added
framework
…-state-border-side
TahaTesser
suggested changes
Jul 8, 2024
| }, | ||
| ); | ||
|
|
||
| void expectBorderColor(Color color) { |
Contributor
There was a problem hiding this comment.
Any utility functions should be placed on top of the tests.
Contributor
Author
There was a problem hiding this comment.
Now that I deleted the first test in test: Remove duplicated test
Is it okay for you? Or do you want the utility method to be placed outside the main?
|
|
||
| void main() { | ||
| testWidgets( | ||
| 'MaterialStateBorderSideExampleApp displays FilterChip', |
Contributor
There was a problem hiding this comment.
This test isn't necessary. "await tester.tap(find.byType(FilterChip));" already finds exactly one chip in other test.
Contributor
Author
There was a problem hiding this comment.
Sure I removed it in test: Remove duplicated test
TahaTesser
suggested changes
Jul 8, 2024
| } | ||
| return shape.side.color == color; | ||
| }); | ||
| expect(finder, findsOne); |
Contributor
There was a problem hiding this comment.
Please turn the finder instead of void and put the expect in the test itself where this would be called.
This helps readability, one don't have to go to function to find out the expect.
Contributor
Author
There was a problem hiding this comment.
Sure, I made the change in refactor: Return a finder
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 8, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 8, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 8, 2024
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jul 8, 2024
Contributes to flutter#130459 It adds a test for - `examples/api/test/material/material_state/material_state_border_side.0_test.dart`
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 9, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 9, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 9, 2024
flutter/flutter@fafd67d...5103d75 2024-07-09 [email protected] [tool] Remove some usages of deprecated usage package (flutter/flutter#151359) 2024-07-09 [email protected] Write the package config location to the test bootstrap. (flutter/flutter#150440) 2024-07-09 [email protected] [deps] Roll dart-lang/native packages (flutter/flutter#151403) 2024-07-08 [email protected] [tool] make `testUsingContext` provide a `Stdio` (with `hasTerminal` unset) override by default (flutter/flutter#151357) 2024-07-08 [email protected] Make `FittedBox` not throw when child has zero size. (flutter/flutter#150430) 2024-07-08 [email protected] Update `DataTable` documentation (flutter/flutter#151356) 2024-07-08 [email protected] `MaterialState` � `WidgetState` in documentation (flutter/flutter#151376) 2024-07-08 [email protected] [ios]A typical news app benchmark with bottom ad banner (flutter/flutter#150991) 2024-07-08 [email protected] Re-enable `SemanticsAction.focus` matchers (flutter/flutter#150990) 2024-07-08 [email protected] Added SliverFloatingHeader.snapMode (flutter/flutter#151289) 2024-07-08 [email protected] Factor out deprecated names in example code (flutter/flutter#151374) 2024-07-08 [email protected] Add cedric vanden bosch to authors (flutter/flutter#151313) 2024-07-08 [email protected] Roll Packages from 97bad7e to 14341d1 (5 revisions) (flutter/flutter#151417) 2024-07-08 [email protected] Update doc-import to primary configured import, _goldens_io.dart (flutter/flutter#151390) 2024-07-08 [email protected] [Reland] - Enable `explicitChildNodes` for the `AlertDialog` content (flutter/flutter#149597) 2024-07-08 [email protected] Add tests for material_state_border_side.0_test.dart (flutter/flutter#151089) 2024-07-08 [email protected] Roll Flutter Engine from ca79a56a66d7 to 69075e7e87d4 (1 revision) (flutter/flutter#151393) 2024-07-08 [email protected] Add tests for action_listener.0.dart (flutter/flutter#150606) 2024-07-07 [email protected] Roll Flutter Engine from 5ca3b856ee5a to ca79a56a66d7 (1 revision) (flutter/flutter#151387) 2024-07-06 [email protected] Roll Flutter Engine from 3600ec613a00 to 5ca3b856ee5a (1 revision) (flutter/flutter#151378) 2024-07-06 [email protected] Roll Flutter Engine from d1ebc5fde630 to 3600ec613a00 (1 revision) (flutter/flutter#151377) 2024-07-06 [email protected] Roll Flutter Engine from e6b09697df1a to d1ebc5fde630 (1 revision) (flutter/flutter#151362) 2024-07-05 49699333+dependabot[bot]@users.noreply.github.com Bump actions/upload-artifact from 4.3.3 to 4.3.4 (flutter/flutter#151354) 2024-07-05 [email protected] Roll Flutter Engine from 4ee09d3b7f3b to e6b09697df1a (2 revisions) (flutter/flutter#151352) 2024-07-05 [email protected] Add tests for color_filtered.0.dart example. (flutter/flutter#151064) 2024-07-05 [email protected] de-duplicate code in analyze.dart (flutter/flutter#151279) 2024-07-05 [email protected] Roll Packages from 754de19 to 97bad7e (1 revision) (flutter/flutter#151350) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #130459
It adds a test for
examples/api/test/material/material_state/material_state_border_side.0_test.dartPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.