Add test for menu_anchor.2.dart by ValentinVignal · Pull Request #151399 · flutter/flutter

ValentinVignal · 2024-07-08T10:54:53Z

Contributes to #130459

It adds a test for

examples/api/lib/material/menu_anchor/menu_anchor.2.dart

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

bleroux

LGTM with one small nit.
Thanks for the contribution!

bleroux · 2024-07-10T08:30:53Z

examples/api/test/material/menu_anchor/menu_anchor.2_test.dart

+      expect(find.widgetWithText(MenuItemButton, 'Item $i'), findsOne);
+    }
+  });
+


Consider removing this empty line

Argh!! Always this empty line 😱 😞

I removed it in
test: Remove empty line

TahaTesser

LGTM with nit

examples/api/test/material/menu_anchor/menu_anchor.2_test.dart

Co-authored-by: Taha Tesser <[email protected]>

…or-2

auto-submit · 2024-07-12T14:11:24Z

auto label is removed for flutter/flutter/151399, due to - The status or check suite Windows build_tests_2_7 has failed. Please fix the issues identified (or deflake) before re-applying this label.

test: Add test for menu_anchor.2.dart

cee950c

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jul 8, 2024

goderbauer requested review from TahaTesser and bleroux July 9, 2024 22:06

bleroux approved these changes Jul 10, 2024

View reviewed changes

test: Remove empty line

7fa7386

TahaTesser approved these changes Jul 10, 2024

View reviewed changes

examples/api/test/material/menu_anchor/menu_anchor.2_test.dart Outdated Show resolved Hide resolved

ValentinVignal and others added 2 commits July 10, 2024 17:14

Update examples/api/test/material/menu_anchor/menu_anchor.2_test.dart

a7a5b7e

Co-authored-by: Taha Tesser <[email protected]>

Merge branch 'master' into flutter/api/example/Add-test-for-menu-anch…

2583efe

…or-2

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 12, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 12, 2024

bleroux added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 12, 2024

auto-submit bot merged commit e47c837 into flutter:master Jul 12, 2024

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to e47c83729075 (43 revisions) flutter/packages#7111

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

659e825

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to 68f375fe3871 (44 revisions) flutter/packages#7112

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

c4fa2fb

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to 607190448b1c (45 revisions) flutter/packages#7113

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

92a9a02

engine-flutter-autoroll mentioned this pull request Jul 13, 2024

Roll Flutter from 58068d8ea4ec to c95977568aa2 (14 revisions) flutter/packages#7116

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 13, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

0cabae6

engine-flutter-autoroll mentioned this pull request Jul 13, 2024

Roll Flutter from 58068d8ea4ec to c95977568aa2 (14 revisions) flutter/packages#7117

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 13, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

530f2ca

engine-flutter-autoroll mentioned this pull request Jul 14, 2024

Roll Flutter from 58068d8ea4ec to 82b63ff27d7a (16 revisions) flutter/packages#7118

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

c67cee9

engine-flutter-autoroll mentioned this pull request Jul 14, 2024

Roll Flutter from 58068d8ea4ec to 82b63ff27d7a (16 revisions) flutter/packages#7119

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

30bcbec

engine-flutter-autoroll mentioned this pull request Jul 16, 2024

Roll Flutter from 58068d8ea4ec to 41e6e6b04114 (37 revisions) flutter/packages#7139

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

829a0db

engine-flutter-autoroll mentioned this pull request Jul 16, 2024

Roll Flutter from 58068d8ea4ec to ba57fa382156 (38 revisions) flutter/packages#7140

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

64f7e6b

engine-flutter-autoroll mentioned this pull request Jul 16, 2024

Roll Flutter from 58068d8ea4ec to cb4ba2fddc6c (39 revisions) flutter/packages#7141

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

2f21c94

engine-flutter-autoroll mentioned this pull request Jul 16, 2024

Roll Flutter from 58068d8ea4ec to b9e4416ad358 (40 revisions) flutter/packages#7142

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

adc0e1e

engine-flutter-autoroll mentioned this pull request Jul 16, 2024

Roll Flutter from 58068d8ea4ec to 22a5c6cb0a90 (41 revisions) flutter/packages#7144

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

51ed1b6

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

3d2d9fe

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

d1695d7

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

a95f12b

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

ebb48ff

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

65b976c

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

cbb756f

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

e11b462

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

00680b6

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

12daf14

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

a9ed024

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

54c5ee8

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

feb49e5

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

3402080

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

2129a73

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

4f971b5

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

7ff7e39

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

b2f24cb

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

ff286be

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

1b2b7c9

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024

e47c837 Add test for menu_anchor.2.dart (flutter/flutter#151399)

7e6b520

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test for menu_anchor.2.dart#151399

Add test for menu_anchor.2.dart#151399
auto-submit[bot] merged 4 commits intoflutter:masterfrom
ValentinVignal:flutter/api/example/Add-test-for-menu-anchor-2

ValentinVignal commented Jul 8, 2024

Uh oh!

bleroux left a comment

Uh oh!

bleroux Jul 10, 2024

Uh oh!

ValentinVignal Jul 10, 2024

Uh oh!

TahaTesser left a comment

Uh oh!

Uh oh!

auto-submit bot commented Jul 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ValentinVignal commented Jul 8, 2024

Pre-launch Checklist

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

bleroux Jul 10, 2024

Choose a reason for hiding this comment

Uh oh!

ValentinVignal Jul 10, 2024

Choose a reason for hiding this comment

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

auto-submit bot commented Jul 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants