Use correct locale for `CupertinoDatePicker` weekday by victorsanni · Pull Request #151494 · flutter/flutter

victorsanni · 2024-07-09T21:44:48Z

#120052 introduces the showDayOfWeek flag to CupertinoDatePicker for mode CupertinoDatePickerMode.date, but the default en locale from DefaultCupertinoLocalizations is always used for the day of the week:

flutter/packages/flutter_localizations/lib/src/cupertino_localizations.dart

Lines 116 to 119 in 5103d75

    
           String datePickerDayOfMonth(int dayIndex, [int? weekDay]) { 
        
              if (weekDay != null) { 
        
               return ' ${DefaultCupertinoLocalizations.shortWeekdays[weekDay - DateTime.monday]} $dayIndex '; 
        
             }

This PR introduces a new intl.DateFormat weekdayFormat to replace the default with the abbreviated weekday for any supported locales.

Before	After

Fixes #141875

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-07-10T17:41:04Z

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

MitchellGoodwin

LGTM!

MitchellGoodwin · 2024-07-10T22:39:45Z

packages/flutter/lib/src/cupertino/localizations.dart


  /// Short version of days of week.
-  static const List<String> shortWeekdays = <String>[
+  static const List<String> _shortWeekdays = <String>[


Technically, this is a breaking change, but I don't know if this is worth deprecating? I don't know why somebody would be using a static list of english only day names from a localization class, but if they are maybe we let it break their app, and they can just make their own static list.

Yes. It should have been private anyways like _shortMonths etc.

…/flutter#151494)

@tool

Roll Flutter from 5103d75 to 58068d8 (42 revisions) flutter/flutter@5103d75...58068d8 2024-07-12 [email protected] Reland: Move all Linux Moto G4 tests to mokey in staging (flutter/flutter#151654) 2024-07-12 [email protected] Update obsolete comment in InputDecorator test (flutter/flutter#151651) 2024-07-12 [email protected] Fix `TabBar` tab indicator stretch effect (flutter/flutter#150868) 2024-07-12 [email protected] Remove workaround for a bug in dart2wasm (flutter/flutter#151603) 2024-07-12 [email protected] [native_assets] Stop running link hooks in JIT mode (flutter/flutter#151534) 2024-07-12 [email protected] Roll `Switch.adaptive` changes into `CupertinoSwitch` (flutter/flutter#149465) 2024-07-11 [email protected] Unmark java11 tests as bringup:true (flutter/flutter#151612) 2024-07-11 [email protected] Add link to design document archive (flutter/flutter#151489) 2024-07-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Move all Linux Moto G4 tests to mokey in staging (#151608)" (flutter/flutter#151620) 2024-07-11 [email protected] Move all Linux Moto G4 tests to mokey in staging (flutter/flutter#151608) 2024-07-11 [email protected] docimports for API samples (flutter/flutter#151606) 2024-07-11 [email protected] docimports for flutter_goldens, flutter_localizations, flutter_web_plugins, fuchsia_remote_debug_protocol, integration_test (flutter/flutter#151271) 2024-07-11 [email protected] Re-enable debug canvaskit e2e tests. (flutter/flutter#151565) 2024-07-11 [email protected] Fix: Submenu anchor misaligned with child panel in web (Resolved #151081) (flutter/flutter#151294) 2024-07-11 [email protected] Replaced {@tool snippet} with {@tool dartpad} in CupertinoTabController (flutter/flutter#151272) 2024-07-11 [email protected] feat: Support overriding native endorsed plugins (flutter/flutter#137040) 2024-07-11 [email protected] expose keyboardType in DropdownMenu #150894 (flutter/flutter#150896) 2024-07-11 [email protected] docimports for flutter_driver (flutter/flutter#151267) 2024-07-11 [email protected] Add `TimeOfDay` comparison methods (flutter/flutter#151233) 2024-07-11 [email protected] Roll Flutter Engine from 6534fbf3c2c1 to 36dccf7bb25c (2 revisions) (flutter/flutter#151577) 2024-07-11 [email protected] Roll Flutter Engine from 1c23c8f64076 to 6534fbf3c2c1 (3 revisions) (flutter/flutter#151572) 2024-07-11 [email protected] Use correct locale for `CupertinoDatePicker` weekday (flutter/flutter#151494) 2024-07-10 [email protected] doc imports for enum values (flutter/flutter#151548) 2024-07-10 [email protected] Reland "Upgrade template Gradle, App AGP, Module AGP, and Kotlin versions, and tests"... but no longer upgrade module AGP version (flutter/flutter#151433) 2024-07-10 [email protected] Roll Packages from 14341d1 to ea35fc6 (16 revisions) (flutter/flutter#151556) 2024-07-10 [email protected] [CupertinoActionSheet] Fix padding and font size of buttons (flutter/flutter#151199) 2024-07-10 [email protected] Roll Flutter Engine from db2b45bea2c0 to 1c23c8f64076 (2 revisions) (flutter/flutter#151550) 2024-07-10 [email protected] Add docImports for flutter_test references (flutter/flutter#151175) 2024-07-10 [email protected] Mention not @-mentioning people in commit messages in tree hygiene (flutter/flutter#151487) 2024-07-10 [email protected] Roll Flutter Engine from 371db85f33d7 to db2b45bea2c0 (8 revisions) (flutter/flutter#151522) 2024-07-10 [email protected] fix heading level absorption, diagnostics; add tests and an a11y use-case (flutter/flutter#151421) 2024-07-10 [email protected] Roll Flutter Engine from 9d943eb2b37a to 371db85f33d7 (3 revisions) (flutter/flutter#151505) 2024-07-10 [email protected] Roll Flutter Engine from d3269d5855a7 to 9d943eb2b37a (5 revisions) (flutter/flutter#151495) 2024-07-09 [email protected] Update doc of `SemanticsProperties.identifier` (flutter/flutter#149915) 2024-07-09 [email protected] Clean up leaky test. (flutter/flutter#151131) 2024-07-09 [email protected] Roll pub packages (flutter/flutter#151492) 2024-07-09 [email protected] testAdd tests for stepper.controls_builder.0.dart (flutter/flutter#150669) 2024-07-09 [email protected] Add Semantics Property `linkUrl` (flutter/flutter#150639) 2024-07-09 [email protected] Roll Flutter Engine from 4a2ac0e51a8f to d3269d5855a7 (1 revision) (flutter/flutter#151488) 2024-07-09 [email protected] Link engine docs on AS setup in flutter/flutter docs on engine contributor setup (flutter/flutter#151481) 2024-07-09 [email protected] Roll Flutter Engine from 69075e7e87d4 to 4a2ac0e51a8f (21 revisions) (flutter/flutter#151482) 2024-07-09 [email protected] Fix Material 3 `Dialog` default background color (flutter/flutter#151400) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages ...

…/flutter#151494)

Use current locale for CupertinoDatePicker weekday

c69a3c2

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository labels Jul 9, 2024

victorsanni added 5 commits July 9, 2024 15:46

Change formatting slightly to match previous behavior

65b3683

Make day of week calculations accurate

bdc047a

Merge branch 'master' into cupertino-datepicker-weekday-locale

38818f6

Remove extra unnecessary newline

671c332

Merge branch 'master' into cupertino-datepicker-weekday-locale

077724d

victorsanni requested a review from MitchellGoodwin July 10, 2024 00:01

victorsanni marked this pull request as ready for review July 10, 2024 00:01

victorsanni marked this pull request as draft July 10, 2024 17:35

victorsanni added 2 commits July 10, 2024 10:53

Add weekdayFormat to localizations generator

9493448

Merge branch 'master' into cupertino-datepicker-weekday-locale

197e341

victorsanni marked this pull request as ready for review July 10, 2024 18:14

victorsanni changed the title ~~Use current locale for CupertinoDatePicker weekday~~ Use correct locale for CupertinoDatePicker weekday Jul 10, 2024

victorsanni mentioned this pull request Jul 10, 2024

[CupertinoDatePicker] Showing months incorrectly in pt-br #138305

Closed

2 tasks

victorsanni requested a review from justinmc July 10, 2024 22:27

MitchellGoodwin approved these changes Jul 10, 2024

View reviewed changes

victorsanni removed the request for review from justinmc July 11, 2024 00:07

victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 11, 2024

auto-submit bot merged commit ceeeb7d into flutter:master Jul 11, 2024

victorsanni deleted the cupertino-datepicker-weekday-locale branch July 11, 2024 13:16

engine-flutter-autoroll mentioned this pull request Jul 11, 2024

Roll Flutter from 5103d7574361 to ee0260b41aca (23 revisions) flutter/packages#7101

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 11, 2024

ceeeb7d Use correct locale for CupertinoDatePicker weekday (flutter…

ae90e80

…/flutter#151494)

engine-flutter-autoroll mentioned this pull request Jul 11, 2024

Roll Flutter from 5103d7574361 to defdb958ff24 (24 revisions) flutter/packages#7102

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 11, 2024

ceeeb7d Use correct locale for CupertinoDatePicker weekday (flutter…

ef1de63

…/flutter#151494)

engine-flutter-autoroll mentioned this pull request Jul 11, 2024

Roll Flutter from 5103d7574361 to 90025e29645b (26 revisions) flutter/packages#7103

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 11, 2024

ceeeb7d Use correct locale for CupertinoDatePicker weekday (flutter…

8290722

…/flutter#151494)

engine-flutter-autoroll mentioned this pull request Jul 11, 2024

Roll Flutter from 5103d7574361 to d55a5f96c117 (27 revisions) flutter/packages#7104

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 11, 2024

ceeeb7d Use correct locale for CupertinoDatePicker weekday (flutter…

36a5fcc

…/flutter#151494)

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to bf6c455d4a7a (41 revisions) flutter/packages#7109

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

ceeeb7d Use correct locale for CupertinoDatePicker weekday (flutter…

2e96ecb

…/flutter#151494)

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to 58068d8ea4ec (42 revisions) flutter/packages#7110

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

ceeeb7d Use correct locale for CupertinoDatePicker weekday (flutter…

b1ae226

…/flutter#151494)

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to e47c83729075 (43 revisions) flutter/packages#7111

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

ceeeb7d Use correct locale for CupertinoDatePicker weekday (flutter…

5b829b4

…/flutter#151494)

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to 68f375fe3871 (44 revisions) flutter/packages#7112

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

ceeeb7d Use correct locale for CupertinoDatePicker weekday (flutter…

33ad087

…/flutter#151494)

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to 607190448b1c (45 revisions) flutter/packages#7113

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

ceeeb7d Use correct locale for CupertinoDatePicker weekday (flutter…

7ef2025

…/flutter#151494)

Piinks mentioned this pull request Jul 12, 2024

Flutter Framework Team: Notable Commits #121415

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use correct locale for `CupertinoDatePicker` weekday#151494

Use correct locale for `CupertinoDatePicker` weekday#151494
auto-submit[bot] merged 8 commits intoflutter:masterfrom
victorsanni:cupertino-datepicker-weekday-locale

victorsanni commented Jul 9, 2024 •

edited

Loading

Uh oh!

flutter-dashboard bot commented Jul 10, 2024

Uh oh!

MitchellGoodwin left a comment

Uh oh!

MitchellGoodwin Jul 10, 2024

Uh oh!

victorsanni Jul 10, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	String datePickerDayOfMonth(int dayIndex, [int? weekDay]) {
	if (weekDay != null) {
	return ' ${DefaultCupertinoLocalizations.shortWeekdays[weekDay - DateTime.monday]} $dayIndex ';
	}

Conversation

victorsanni commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jul 10, 2024

Uh oh!

MitchellGoodwin left a comment

Choose a reason for hiding this comment

Uh oh!

MitchellGoodwin Jul 10, 2024

Choose a reason for hiding this comment

Uh oh!

victorsanni Jul 10, 2024

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

victorsanni commented Jul 9, 2024 •

edited

Loading