Closed
Conversation
flutter-pub-roller-bot
added
the
tool
flutter-pub-roller-bot
requested a review
from christopherfujino
as a code owner
flutter-pub-roller-bot
added
the
autosubmit
fluttergithubbot
approved these changes
Jul 10, 2024
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/151539, due to - The status or check suite Mac_arm64 run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
Member
Contributor
Member
|
As far as I can tell from https://github.com/flutter/flutter/blob/32c0c39ea5d81f0c9b3e51a513c76c4ca3d5d111/packages/flutter_tools/lib/src/update_packages_pins.dart they are currently not excluded. Should they be pinned to always require manual intervention to roll them? cc @christopherfujino who may have more context. |
Contributor
I don't have more context, I would echo what Michael said, if we want to ensure the autoroller is not rolling these, we should pin them in the library he linked. |
9 tasks
auto-submit bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
Stop trying to roll the dependencies for native assets automatically. They are under active development (pre 1.0.0), and have frequent breaking changes. I'll be rolling these manually. (We have the same setup in the Dart SDK, not auto-rolling dart-lang/native via DEPS.) Related comment: * #151539 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was generated by
flutter update-packages --force-upgrade.