Skip to content

[macOS] support secure restorable state by default#151605

Merged
cbracken merged 7 commits intoflutter:masterfrom
cbracken:secure-restorable-state
Jul 12, 2024
Merged

[macOS] support secure restorable state by default#151605
cbracken merged 7 commits intoflutter:masterfrom
cbracken:secure-restorable-state

Conversation

@cbracken
Copy link
Member

@cbracken cbracken commented Jul 11, 2024 •
edited
Loading

By default, Flutter apps only do default AppKit app serialisation of Window location etc. and by default, state serialisation in AppKit apps is compatible with NSSecureCoding. AppKit apps generated since Xcode 13.2 include this method in the app delegate generated by the default app template.

Background

This method was added to opt into having [de]serialization require a coder implementing the NSSecureCoding protocol. Apple wasn't able to force this across the board, because NSSecureCoding limits certain behaviours during deserialisation, which some third-party apps have have previously relied on.

Specific background on the sorts of vulnerabilities that NSSecureCoding was designed to prevent are described in the NSSecureCoding documentation:
https://developer.apple.com/documentation/foundation/nssecurecoding?language=objc

A demonstration of a root privilege escalation and SIP bypass vulnerability is described in the following blog post: https://sector7.computest.nl/post/2022-08-process-injection-breaking-all-macos-security-layers-with-a-single-vulnerability/

Fixes: #150062

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 11, 2024
@cbracken cbracken mentioned this pull request Jul 11, 2024
Closed
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos a: desktop Running on desktop labels Jul 11, 2024
@cbracken cbracken force-pushed the secure-restorable-state branch from 8a367e9 to 7c434ac Compare July 11, 2024 19:26
@cbracken cbracken marked this pull request as ready for review July 11, 2024 19:27
@cbracken cbracken requested a review from jmagman July 11, 2024 19:27
cbracken added 4 commits July 11, 2024 13:29
@cbracken
[macOS] support secure restorable state by default
15ab883 
By default, Flutter apps only do default AppKit app serialisation of
Window location etc. and by default, state serialisation in AppKit apps
is compatible with NSSecureCoding. AppKit apps generated since Xcode
13.2 include this method in the app delegate generated by the default
app template.

Background
==========

This method was added to opt into having [de]serialization  require a
coder implementing the `NSSecureCoding` protocol. Apple wasn't able to
force this across the board, because `NSSecureCoding` limits certain
behaviours during deserialisation, which some third-party apps have have
previously relied on.

Specific background on the sorts of vulnerabilities that
`NSSecureCoding` was designed to prevent are described in the
`NSSecureCoding` documentation:
https://developer.apple.com/documentation/foundation/nssecurecoding?language=objc

A demonstration of a root privilege escalation and SIP bypass
vulnerability is described in the following blog post:
https://sector7.computest.nl/post/2022-08-process-injection-breaking-all-macos-security-layers-with-a-single-vulnerability/

Issue: flutter#150062
@cbracken
Update examples to support secure restorable state
78aac88
@cbracken
Add SecureRestorableStateMigration
25d2f22
@cbracken
Eliminate comment from template
14e600a 
Avoid leading developers down the rabbit-hole of whether or not they
need to change the override value to false.
@cbracken cbracken requested a review from loic-sharma July 11, 2024 20:31
loic-sharma
loic-sharma approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@loic-sharma loic-sharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cbracken cbracken force-pushed the secure-restorable-state branch from 2b0a3fb to 3f93813 Compare July 11, 2024 21:44
@cbracken cbracken force-pushed the secure-restorable-state branch from 2ce2cf9 to 45e68cb Compare July 11, 2024 22:22
@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 11, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 11, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 11, 2024

auto label is removed for flutter/flutter/151605, due to - The status or check suite Mac tool_integration_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@cbracken cbracken added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 11, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Jul 12, 2024

auto label is removed for flutter/flutter/151605, due to - The status or check suite Mac_arm64 build_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 12, 2024
@cbracken cbracken merged commit 68f375f into flutter:master Jul 12, 2024
@cbracken cbracken deleted the secure-restorable-state branch July 12, 2024 18:08
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 12, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
cdb8a9a 
…lutter#151605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
4519013 
…lutter#151605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
d3bbc52 
…lutter#151605)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
cf14493 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
9602e3b 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
b5b3cb1 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
a83d5a3 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
682af11 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
765af8c 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
582df53 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
5d86a36 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
23144b3 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
c4c3c6c 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
ae69c18 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
c4dcafb 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
53f3195 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
83d999c 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
08bca46 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
0788119 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
fecbe3d 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
642fd99 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
b5f8088 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
cf742f3 
…lutter#151605)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
68f375f [macOS] support secure restorable state by default (flutter/f…
d5eb66f 
…lutter#151605)
MaxFangX pushed a commit to lexe-app/lexe-public that referenced this pull request Jul 29, 2024
@phlip9
app: macos: silence annoying warning log
f5549c6 
See: <flutter/flutter#151605>
phlip9 added a commit to lexe-app/lexe-public that referenced this pull request Nov 26, 2024
@phlip9
app: macos: silence annoying warning log
024a78a 
See: <flutter/flutter#151605>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@loic-sharma loic-sharma loic-sharma approved these changes

@jmagman jmagman Awaiting requested review from jmagman

Assignees

No one assigned

Labels

a: desktop Running on desktop d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

2 participants

@cbracken @loic-sharma