Skip to content

[native_assets] Don't auto-roll deps#151636

Merged
auto-submit[bot] merged 2 commits intomasterfrom
pin-native-assets-packages
Jul 12, 2024
Merged

[native_assets] Don't auto-roll deps#151636
auto-submit[bot] merged 2 commits intomasterfrom
pin-native-assets-packages

Conversation

@dcharkes
Copy link
Contributor

@dcharkes dcharkes commented Jul 12, 2024

Stop trying to roll the dependencies for native assets automatically.

They are under active development (pre 1.0.0), and have frequent breaking changes. I'll be rolling these manually.
(We have the same setup in the Dart SDK, not auto-rolling dart-lang/native via DEPS.)

Related comment:

Pre-launch Checklist

@flutter-dashboard
Copy link

flutter-dashboard bot commented Jul 12, 2024

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 12, 2024
christopherfujino
christopherfujino approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcharkes dcharkes added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 12, 2024
@auto-submit auto-submit bot merged commit 6071904 into master Jul 12, 2024
@auto-submit auto-submit bot deleted the pin-native-assets-packages branch July 12, 2024 18:56
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
a4ddfe9
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 13, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
9748595
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 13, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
ae6a885
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
2e5812e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
6fa3387
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
0bc644e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
b513613
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
a4f6f8d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
a9f1d91
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
469874c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
c3386cd
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
b2181c5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
8d51f2a
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
ff602bb
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
674b3b4
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
a4e4e19
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
b4e1ea0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
1187683
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
aedecc0
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
db1d8e9
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
b454c2d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
d917049
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
ff3b442
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
5ed2dd3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
98105f2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
821d0e5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
4006e6b
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
2d874cb
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
29b16a3
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
7fae88d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
6ed7b13
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
976f4ad
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
dc65fd5
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
76d8b77
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
6071904 [native_assets] Don't auto-roll deps (flutter/flutter#151636)
72ea8c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer Awaiting requested review from goderbauer

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dcharkes @christopherfujino