Delay `DropdownMenu` filtering until text input by PurplePolyhedron · Pull Request #152368 · flutter/flutter

PurplePolyhedron · 2024-07-26T12:18:15Z

fixes #152055

Disabling filtering in DropdownMenu at start and after a selection has been made, and re-enable it (if widget.enableFilter is true) after text input.
This way it doesn't hide all other options when there is an existing selection.

Note: currently this may crush due to issue #151878 . Which is not directly related to this PR

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

dkwingsmt

The change LGTM. The only question I have is whether this is the behavior observed on other implementations, such as Android.

bleroux

Thanks for your contribution.
If possible, can you answer this question?

bleroux · 2024-08-07T08:19:20Z

packages/flutter/test/material/dropdown_menu_test.dart

+
+    await tester.tap(find.byType(DropdownMenu<TestMenu>));
+    await tester.pumpAndSettle();
+    // All entries should be avaliable, and two buttons should be found for each entry.


Suggested change

// All entries should be avaliable, and two buttons should be found for each entry.

// All entries should be available, and two buttons should be found for each entry.

Small typo, and maybe add an empty line before this comment

bleroux · 2024-08-07T08:21:00Z

packages/flutter/test/material/dropdown_menu_test.dart

+    await tester.enterText(find
+        .byType(TextField)
+        .first, 'Menu 1');


Suggested change

await tester.enterText(find

.byType(TextField)

.first, 'Menu 1');

await tester.enterText(find.byType(TextField).first, 'Menu 1');

PurplePolyhedron · 2024-08-08T17:25:24Z

The change LGTM. The only question I have is whether this is the behavior observed on other implementations, such as Android.

I am not familiar with native android development, and I wasn't able to find android app that uses dropdown menu with initial entry and filter.

In the current version of DropdownMenu with filter enabled, _enableFilter is turned off temporarily after selecting an item, so then if you tap to open the menu again, all the item is shown. I believe an initial entry should behave the same way.

bleroux

LGTM! Thanks for your contribution.

…ter#152368)

flutter/flutter@cc13cd1...99f00a1 2024-08-15 [email protected] Roll Flutter Engine from 76a1c64f4e63 to 971ddd9fe1bf (6 revisions) (flutter/flutter#153487) 2024-08-14 [email protected] Update tokens to 5.0.0 (flutter/flutter#153385) 2024-08-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.1 to 3.26.2 (flutter/flutter#153468) 2024-08-14 [email protected] Enable invalid_runtime_check_with_js_interop_types, use_truncating_division (flutter/flutter#153464) 2024-08-14 [email protected] Roll Flutter Engine from 9b8421662ec9 to 76a1c64f4e63 (1 revision) (flutter/flutter#153465) 2024-08-14 [email protected] Roll Flutter Engine from 328c4df8329f to 9b8421662ec9 (1 revision) (flutter/flutter#153463) 2024-08-14 [email protected] Lint sync (flutter/flutter#153453) 2024-08-14 [email protected] manual pub roll w/ gradle updates (flutter/flutter#153403) 2024-08-14 [email protected] Update docs to use new Android version in the engine (flutter/flutter#151601) 2024-08-14 [email protected] move some tool TESTOWNERS entries to andrew (flutter/flutter#153400) 2024-08-14 [email protected] Slider shows visual label of value on focus (flutter/flutter#152960) 2024-08-14 [email protected] Add `Row` and `Column` widgets specific `spacing` tests (flutter/flutter#153353) 2024-08-14 [email protected] Delay `DropdownMenu` filtering until text input (flutter/flutter#152368) 2024-08-14 [email protected] Update cherry pick issue template's PR field (flutter/flutter#153381) 2024-08-14 [email protected] Roll Flutter Engine from 5909666fdedb to 328c4df8329f (1 revision) (flutter/flutter#153436) 2024-08-14 [email protected] [web] Pass `--no-source-maps` instead of `--extra-compiler-option=--no-source-maps` to `dart compile wasm` (flutter/flutter#153417) 2024-08-14 [email protected] Manual roll Flutter Engine from 019f9e3f0744 to 5909666fdedb (12 revisions) (flutter/flutter#153413) 2024-08-14 [email protected] Move `@_debugOnly` documentation in `framework.dart` to be more visible to IDE. (flutter/flutter#153134) 2024-08-13 [email protected] Roll Flutter Engine from 4246f1536c5d to 019f9e3f0744 (2 revisions) (flutter/flutter#153394) 2024-08-13 [email protected] fix(flutter/a11y assessments): h1 missing a11y from each page on the web app (flutter/flutter#152198) 2024-08-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.0 to 3.26.1 (flutter/flutter#153395) 2024-08-13 [email protected] Roll Packages from d9a6de8 to e4f2247 (4 revisions) (flutter/flutter#153383) 2024-08-13 [email protected] Roll pub packages (flutter/flutter#153380) 2024-08-13 [email protected] Roll Flutter Engine from 73c3135cc3be to 4246f1536c5d (2 revisions) (flutter/flutter#153377) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fixes flutter#152055 Disabling filtering in `DropdownMenu` at start and after a selection has been made, and re-enable it (if `widget.enableFilter` is true) after text input. This way it doesn't hide all other options when there is an existing selection. Note: currently this may crush due to issue flutter#151878 . Which is not directly related to this PR

…ter#152368)

PurplePolyhedron added 6 commits July 26, 2024 19:46

update dropdown_menu

92a9489

update dropdown_menu_test

f829bf6

fix dropdown_menu conflict

b4288e3

fix dropdown_menu_test conflict

48ebd7d

fix dropdown_menu conflict

b6627d5

fix dropdown_menu conflict

505feec

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 26, 2024

PurplePolyhedron added 2 commits July 26, 2024 20:31

Update dropdown_menu.dart didUpdateWidget

c68c4e3

fix format in dropdown_menu_test

f89aef9

dkwingsmt requested review from QuncCccccc and dkwingsmt July 31, 2024 18:31

dkwingsmt approved these changes Aug 7, 2024

View reviewed changes

bleroux reviewed Aug 7, 2024

View reviewed changes

PurplePolyhedron added 3 commits August 8, 2024 23:34

fix dropdown_menu_test format

a07674c

Merge branch 'flutter:master' into dropdown_menu_delay_filter

16ddc58

Merge branch 'flutter:master' into dropdown_menu_delay_filter

21ff65f

bleroux approved these changes Aug 9, 2024

View reviewed changes

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 14, 2024

auto-submit bot merged commit b5847d3 into flutter:master Aug 14, 2024

engine-flutter-autoroll mentioned this pull request Aug 14, 2024

Roll Flutter from cc13cd1f1191 to b5847d364a26 (12 revisions) flutter/packages#7414

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2024

b5847d3 Delay DropdownMenu filtering until text input (flutter/flut…

c861071

…ter#152368)

engine-flutter-autoroll mentioned this pull request Aug 14, 2024

Manual roll Flutter from cc13cd1f1191 to 51c640297f08 (14 revisions) flutter/packages#7415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2024

b5847d3 Delay DropdownMenu filtering until text input (flutter/flut…

6a9b9d1

…ter#152368)

engine-flutter-autoroll mentioned this pull request Aug 14, 2024

Roll Flutter from cc13cd1f1191 to 51c640297f08 (14 revisions) flutter/packages#7416

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 14, 2024

b5847d3 Delay DropdownMenu filtering until text input (flutter/flut…

720d29b

…ter#152368)

engine-flutter-autoroll mentioned this pull request Aug 15, 2024

Manual roll Flutter from cc13cd1f1191 to 99f00a130923 (24 revisions) flutter/packages#7418

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2024

b5847d3 Delay DropdownMenu filtering until text input (flutter/flut…

52fc20c

…ter#152368)

engine-flutter-autoroll mentioned this pull request Aug 15, 2024

Roll Flutter from cc13cd1f1191 to 99f00a130923 (24 revisions) flutter/packages#7419

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 15, 2024

b5847d3 Delay DropdownMenu filtering until text input (flutter/flut…

e6f64e0

…ter#152368)

Piinks mentioned this pull request Aug 16, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

b5847d3 Delay DropdownMenu filtering until text input (flutter/flut…

33292fb

…ter#152368)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

b5847d3 Delay DropdownMenu filtering until text input (flutter/flut…

2adcca6

…ter#152368)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delay `DropdownMenu` filtering until text input#152368

Delay `DropdownMenu` filtering until text input#152368
auto-submit[bot] merged 11 commits intoflutter:masterfrom
PurplePolyhedron:dropdown_menu_delay_filter

PurplePolyhedron commented Jul 26, 2024 •

edited

Loading

Uh oh!

dkwingsmt left a comment

Uh oh!

bleroux left a comment

Uh oh!

bleroux Aug 7, 2024

Uh oh!

bleroux Aug 7, 2024

Uh oh!

PurplePolyhedron commented Aug 8, 2024 •

edited

Loading

Uh oh!

bleroux left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	// All entries should be avaliable, and two buttons should be found for each entry.
	// All entries should be available, and two buttons should be found for each entry.

Conversation

PurplePolyhedron commented Jul 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

bleroux Aug 7, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux Aug 7, 2024

Choose a reason for hiding this comment

Uh oh!

PurplePolyhedron commented Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

PurplePolyhedron commented Jul 26, 2024 •

edited

Loading

PurplePolyhedron commented Aug 8, 2024 •

edited

Loading