Add ability to disable CupertinoSegmentedControl by huycozy · Pull Request #152813 · flutter/flutter

huycozy · 2024-08-03T19:38:12Z

Summary

Add the ability to configure enabled or disabled segments in CupertinoSegmentedControl. The idea is to pass a segmentStates map, where the user can set the state according to segment key. User can also set background and text colors when the segment is disabled.

Demo

demo.fix.video.mov

Related issue

Fixes #52105

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

QuncCccccc

Thanks so much for the fix! Just left 2 questions below:)

packages/flutter/lib/src/cupertino/segmented_control.dart

QuncCccccc

Thanks so much for the contribution! One comment I left is about the api type, I think a Set of disabled children might be better than a map, based on the comment that I received from SlidingSegmentedControl PR.

packages/flutter/lib/src/cupertino/segmented_control.dart

huycozy · 2024-08-27T08:21:25Z

Thank you for the suggestion! It looks better with Set type. I pushed the update.

QuncCccccc

Sorry for the late response! Left some comments. Please let me know if there's anything that doesn't make sense:)

QuncCccccc · 2024-09-05T01:50:28Z

examples/api/lib/cupertino/segmented_control/cupertino_segmented_control.1.dart

+                        _toggleAll = false;
+                        _disabledChildren = <Sky>{Sky.midnight};
+                      } else {
+                        _toggleAll = true;


Why _toggleAll is set to true if _toggleOne is false? This part looks a little confusing. Seems if toggleOne is true, it disables the first segment, but if toggleAll is true, it enables all segments.🤔

Since this example looks similar with cupertino_segmented_control.0.dart, maybe we can just add the Switches in that example instead of creating a new one:)

Why _toggleAll is set to true if _toggleOne is false? This part looks a little confusing. Seems if toggleOne is true, it disables the first segment, but if toggleAll is true, it enables all segments.🤔

In this example, my purpose is to create clear cases, please also watch the demo video in the original comment

User can disable one segment (1st segment for eg)

User can disable/enable all segments

So, when user toggles one Switch, it will also reset the remaining Switch.

Since this example looks similar with cupertino_segmented_control.0.dart, maybe we can just add the Switches in that example instead of creating a new one:)

My initial purpose is to create separate examples for disabled segments. But I can do this if it's cleaner :)

packages/flutter/lib/src/cupertino/segmented_control.dart

huycozy · 2024-09-24T12:01:35Z

@QuncCccccc Thank you so much for your thorough review and sorry for the delayed response, I've just come back from travel :). I've updated the code based on most of your suggestions, except for those concerning example and disabledColor, I'm eager to hear back from you again. Here is the updated demo video for the example:

Screen.Recording.2024-09-24.at.18.16.45.mov

packages/flutter/lib/src/cupertino/segmented_control.dart

packages/flutter/test/cupertino/segmented_control_test.dart

QuncCccccc

LGTM:) Thanks for the contribution!

Signed-off-by: huycozy <[email protected]>

…ult disabled text color. Signed-off-by: huycozy <[email protected]>

Signed-off-by: huycozy <[email protected]>

…mprovement Signed-off-by: huycozy <[email protected]>

…tter#152813)

Roll Flutter from 4faa4a4 to 5a11904 (67 revisions) flutter/flutter@4faa4a4...5a11904 2024-10-26 [email protected] Relands "Wide gamut framework gradient test (#153976)" (flutter/flutter#157643) 2024-10-26 [email protected] Roll Flutter Engine from 7c5c5fe5c84d to c9b8ac96f6ce (3 revisions) (flutter/flutter#157662) 2024-10-26 [email protected] Add test for `navigator_state.restorable_push_and_remove_until.0.dart` (flutter/flutter#157595) 2024-10-26 [email protected] Tighten up `throwToolExit`, explain when to use it. (flutter/flutter#157561) 2024-10-26 [email protected] Remove extraneous `throw`. (flutter/flutter#157658) 2024-10-26 [email protected] Add tests for `navigator.restorable_push.0.dart` (flutter/flutter#157492) 2024-10-25 [email protected] Roll Flutter Engine from 43e4d9a30666 to 7c5c5fe5c84d (1 revision) (flutter/flutter#157644) 2024-10-25 [email protected] Roll Flutter Engine from 5061358e255f to 43e4d9a30666 (1 revision) (flutter/flutter#157637) 2024-10-25 [email protected] Roll Flutter Engine from eb867e055790 to 5061358e255f (2 revisions) (flutter/flutter#157623) 2024-10-25 [email protected] Create flutter specific leak troubleshooting guidance. (flutter/flutter#157396) 2024-10-25 [email protected] Update CupertinoNavigationBar to support large layout (flutter/flutter#157133) 2024-10-25 [email protected] Roll Flutter Engine from 38e9be1f74fa to eb867e055790 (3 revisions) (flutter/flutter#157613) 2024-10-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Wide gamut framework gradient test (#153976)" (flutter/flutter#157615) 2024-10-25 [email protected] Wide gamut framework gradient test (flutter/flutter#153976) 2024-10-25 [email protected] Roll Flutter Engine from b413d9996c86 to 38e9be1f74fa (2 revisions) (flutter/flutter#157604) 2024-10-25 [email protected] Roll Packages from a556f0f to e0c4f55 (2 revisions) (flutter/flutter#157605) 2024-10-25 [email protected] Support backdrop key in flutter framework. (flutter/flutter#157278) 2024-10-25 [email protected] Add 3.24.4 changelog to master (flutter/flutter#157600) 2024-10-25 [email protected] Update flutter.groovy to catch unknown task exception when finding api task (flutter/flutter#157282) 2024-10-25 [email protected] Roll Flutter Engine from c4b0184c8783 to b413d9996c86 (1 revision) (flutter/flutter#157580) 2024-10-25 [email protected] Roll Flutter Engine from b1c2ba8c4d52 to c4b0184c8783 (1 revision) (flutter/flutter#157578) 2024-10-25 [email protected] Add test for `build_owner.0.dart` (flutter/flutter#157499) 2024-10-25 [email protected] Add tests for `focusable_action_detector.0.dart` (flutter/flutter#157575) 2024-10-25 [email protected] Add test for `navigator.restorable_push_and_remove_until.0.dart` (flutter/flutter#157487) 2024-10-25 [email protected] Roll Flutter Engine from 29440ed1e225 to b1c2ba8c4d52 (1 revision) (flutter/flutter#157572) 2024-10-25 [email protected] Roll Flutter Engine from 88716d804aef to 29440ed1e225 (1 revision) (flutter/flutter#157569) 2024-10-25 [email protected] Roll Flutter Engine from b8b28c80a737 to 88716d804aef (2 revisions) (flutter/flutter#157567) 2024-10-24 [email protected] Roll Flutter Engine from 48ff670d256b to b8b28c80a737 (2 revisions) (flutter/flutter#157564) 2024-10-24 [email protected] Use discenrable characters (replace `' ð�� ð�� '` in error logs) (flutter/flutter#157548) 2024-10-24 [email protected] Remove unused `PubDependenciesProjectValidator`. (flutter/flutter#157516) 2024-10-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (#157032)" (flutter/flutter#157559) 2024-10-24 [email protected] Mark mac impeller as bringup. (flutter/flutter#157551) 2024-10-24 [email protected] Deprecate `ThemeData.dialogBackgroundColor` in favor of `DialogThemeData.backgroundColor` (flutter/flutter#155072) 2024-10-24 [email protected] Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10 (flutter/flutter#157032) 2024-10-24 [email protected] Roll Flutter Engine from 246344f26edc to 48ff670d256b (2 revisions) (flutter/flutter#157544) 2024-10-24 [email protected] Allow opting out of `.flutter-plugins`, opt-out in `refreshPluginsList`. (flutter/flutter#157527) 2024-10-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reverts "Added a warning if `flutter.groovy` uses a `.flutter-plugins` file. (#157388)" (#157541)" (flutter/flutter#157549) 2024-10-24 [email protected] Changes the offset computation to first item for RenderSliverMainAxisGroup (flutter/flutter#154688) 2024-10-24 [email protected] Roll Packages from 5e03bb1 to a556f0f (7 revisions) (flutter/flutter#157539) 2024-10-24 [email protected] Add partial test for flutter build ios-framework on non-module (flutter/flutter#157482) 2024-10-24 [email protected] Add example to SafeArea docs (flutter/flutter#157228) 2024-10-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Added a warning if `flutter.groovy` uses a `.flutter-plugins` file. (#157388)" (flutter/flutter#157541) 2024-10-24 [email protected] Added a warning if `flutter.groovy` uses a `.flutter-plugins` file. (flutter/flutter#157388) 2024-10-24 [email protected] Roll Flutter Engine from be56084344d1 to 246344f26edc (2 revisions) (flutter/flutter#157504) 2024-10-24 [email protected] Add ability to disable CupertinoSegmentedControl (flutter/flutter#152813) 2024-10-24 [email protected] Update `Tab.height` parameter doc for tab height lower than default (flutter/flutter#157443) ...

### Summary Add the ability to configure enabled or disabled segments in CupertinoSegmentedControl. The idea is to pass a `segmentStates` map, where the user can set the state according to segment key. User can also set background and text colors when the segment is disabled. ### Demo https://github.com/user-attachments/assets/4a02da02-a0fb-4ded-a271-033a8dc79ac3 ### Related issue Fixes flutter#52105

…tter#152813)

huycozy self-assigned this Aug 3, 2024

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Aug 3, 2024

QuncCccccc mentioned this pull request Aug 4, 2024

Missing CupertinoSlidingSegmentedControl features #43826

Closed

huycozy requested a review from QuncCccccc August 5, 2024 03:41

QuncCccccc reviewed Aug 7, 2024

View reviewed changes

packages/flutter/lib/src/cupertino/segmented_control.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/cupertino/segmented_control.dart Outdated Show resolved Hide resolved

QuncCccccc self-requested a review August 14, 2024 18:09

QuncCccccc reviewed Aug 20, 2024

View reviewed changes

packages/flutter/lib/src/cupertino/segmented_control.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/cupertino/segmented_control.dart Outdated Show resolved Hide resolved

huycozy force-pushed the toggle-cupertino-segmentedcontrol-52105 branch from f3a77d8 to b07088c Compare August 27, 2024 08:20

QuncCccccc self-requested a review September 4, 2024 18:12

QuncCccccc reviewed Sep 5, 2024

View reviewed changes

huynguyennovem force-pushed the toggle-cupertino-segmentedcontrol-52105 branch from b07088c to b5ea236 Compare September 24, 2024 11:53

Piinks requested a review from QuncCccccc October 2, 2024 18:13

QuncCccccc reviewed Oct 10, 2024

View reviewed changes

huycozy force-pushed the toggle-cupertino-segmentedcontrol-52105 branch from aee89ef to e82773c Compare October 17, 2024 04:05

QuncCccccc approved these changes Oct 23, 2024

View reviewed changes

huycozy added 8 commits October 23, 2024 11:25

Option to disable CupertinoSegmentedControl

e181df6

Signed-off-by: huycozy <[email protected]>

Add tests for "Option to disable CupertinoSegmentedControl"

5c37cbb

Signed-off-by: huycozy <[email protected]>

Add example for "Option to disable CupertinoSegmentedControl"

f7b7ada

Signed-off-by: huycozy <[email protected]>

Update example and add tests

51f2ca6

Signed-off-by: huycozy <[email protected]>

Fix up: replace int to T key for segment states map

fc46431

Signed-off-by: huycozy <[email protected]>

Fix up: Change segmentStates Map to disabledChildren Set. Change defa…

ff00788

…ult disabled text color. Signed-off-by: huycozy <[email protected]>

Fix up: docs, disable colors, style guide and merge example/test

fc569f7

Signed-off-by: huycozy <[email protected]>

Fix up: disable colors in selected/unselected state, add test, docs i…

366aa0e

…mprovement Signed-off-by: huycozy <[email protected]>

Piinks force-pushed the toggle-cupertino-segmentedcontrol-52105 branch from e82773c to 366aa0e Compare October 23, 2024 18:25

huycozy added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 24, 2024

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2024

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

eab402d

…tter#152813)

engine-flutter-autoroll mentioned this pull request Oct 24, 2024

Roll Flutter from 4faa4a415ec9 to 25b55b9f2d09 (25 revisions) flutter/packages#7921

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2024

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

af740bb

…tter#152813)

engine-flutter-autoroll mentioned this pull request Oct 24, 2024

Roll Flutter from 4faa4a415ec9 to ef99fcbd60c5 (26 revisions) flutter/packages#7923

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2024

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

0ea76fb

…tter#152813)

engine-flutter-autoroll mentioned this pull request Oct 24, 2024

Roll Flutter from 4faa4a415ec9 to bf319d621371 (28 revisions) flutter/packages#7924

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 24, 2024

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

37a7f3f

…tter#152813)

engine-flutter-autoroll mentioned this pull request Oct 25, 2024

Roll Flutter from 4faa4a415ec9 to 7e2a06657c1c (49 revisions) flutter/packages#7929

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

1f9bdcb

…tter#152813)

engine-flutter-autoroll mentioned this pull request Oct 25, 2024

Roll Flutter from 4faa4a415ec9 to 23274284a7b5 (50 revisions) flutter/packages#7931

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

abb0268

…tter#152813)

engine-flutter-autoroll mentioned this pull request Oct 25, 2024

Roll Flutter from 4faa4a415ec9 to c4c545215ad9 (51 revisions) flutter/packages#7932

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

54072fa

…tter#152813)

engine-flutter-autoroll mentioned this pull request Oct 25, 2024

Roll Flutter from 4faa4a415ec9 to add7e81f4f5c (55 revisions) flutter/packages#7933

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

8a47108

…tter#152813)

engine-flutter-autoroll mentioned this pull request Oct 25, 2024

Roll Flutter from 4faa4a415ec9 to 6337eb1a3925 (56 revisions) flutter/packages#7934

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 25, 2024

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

8425885

…tter#152813)

Piinks mentioned this pull request Oct 25, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll mentioned this pull request Oct 26, 2024

Roll Flutter from 4faa4a415ec9 to 9327c24d8086 (66 revisions) flutter/packages#7936

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 26, 2024

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

116e52c

…tter#152813)

engine-flutter-autoroll mentioned this pull request Oct 26, 2024

Roll Flutter from 4faa4a415ec9 to 5a11904383d1 (67 revisions) flutter/packages#7937

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 26, 2024

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

6d92426

…tter#152813)

huycozy deleted the toggle-cupertino-segmentedcontrol-52105 branch February 7, 2025 09:19

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

727ddc4

…tter#152813)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

c90222c

…tter#152813)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

8f10245

…tter#152813)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

e7050c9

…tter#152813)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

fa52543 Add ability to disable CupertinoSegmentedControl (flutter/flu…

00d32c3

…tter#152813)

Conversation

huycozy commented Aug 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Demo

Related issue

Pre-launch Checklist

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

huycozy commented Aug 27, 2024

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

QuncCccccc Sep 5, 2024

Choose a reason for hiding this comment

Uh oh!

huycozy Sep 24, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huycozy commented Sep 24, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

huycozy commented Aug 3, 2024 •

edited

Loading