[CP-stable]Add xcresulttool --legacy flag for deprecated usage#153117
Merged
auto-submit[bot] merged 1 commit intoflutter:flutter-3.24-candidate.0from Aug 13, 2024
Conversation
Workaround to add the `--legacy` flag until flutter#151502 can adopt the non-deprecated usage. This will allow Xcode errors to be parseable again. Fixes flutter#152989
Author
|
@jmagman please fill out the PR description above, afterwards the release team will review this request. |
hellohuanlin
approved these changes
Aug 12, 2024
| ...xcode.xcrunCommand(), | ||
| 'xcresulttool', | ||
| 'get', | ||
| // See https://github.com/flutter/flutter/issues/151502 |
Contributor
There was a problem hiding this comment.
can you briefly describe it in comment why this is added? so that future readers don't have to click on the link to know what this does.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Link:
#152989
Changelog Description:
On Xcode 16 beta, compilation errors are not displayed in the output of
flutter run.Impact Description:
If there are compilation errors
flutter build ios/runwill fail, but displays the last x lines out the Xcode output instead of a nicely formatted description of the error.Workaround:
Use Xcode 15.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
Run the following steps with both Xcode 15 and Xcode 16 installed (should behave the same):
Add code that would cause a compilation issue:
Output should be: