Fix broken text field with set hint and min and max lines(#153183) by zeqinjie · Pull Request #153235 · flutter/flutter

zeqinjie · 2024-08-11T04:23:06Z

Fix #153183
Fix #52008

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

)

LongCatIsLooong

Looks like the feature is achievable without any flutter code changes. You can set the hintText to null when the text field becomes non-empty. Also having long hint text usually isn't great UX since it goes away as soon as you start typing.

packages/flutter/lib/src/material/text_form_field.dart

zeqinjie · 2024-08-26T11:29:37Z

Looks like the feature is achievable without any flutter code changes. You can set the hintText to null when the text field becomes non-empty. Also having long hint text usually isn't great UX since it goes away as soon as you start typing.

@LongCatIsLooong Thank you for your review, yes, but we need additional logic to update textField, so I added a variable to control it for the convenience of users.

packages/flutter/lib/src/material/input_decorator.dart

LongCatIsLooong

LGTM. Thanks for bearing with me!

packages/flutter/lib/src/material/input_decorator.dart

dkwingsmt · 2024-09-17T20:19:02Z

packages/flutter/test/material/input_decorator_test.dart

      expect(hintTextWidget.style!.overflow, decoration.hintStyle!.overflow);
    });
+
+    testWidgets('hint should be ignore its height when input text', (WidgetTester tester) async {


Suggested change

testWidgets('hint should be ignore its height when input text', (WidgetTester tester) async {

testWidgets('Ignore hint height on non-empty text', (WidgetTester tester) async {

@dkwingsmt thank you, i update my test

packages/flutter/test/material/input_decorator_test.dart

dkwingsmt · 2024-09-17T20:24:26Z

packages/flutter/lib/src/material/input_decorator.dart

+        duration: decoration.hintFadeDuration ?? _kHintFadeTransitionDuration,
+        curve: _kTransitionCurve,
+        child: hintTextWidget,
+      ) : AnimatedSwitcher(


The animation logic seems complicated. I don't know what the expectation is here, but we probably want to test any non-trivial behavior. (Consider AnimationSheetBuilder)

@dkwingsmt Sorry, I don't know much about the AnimationSheetBuilder component, so I refer to testWidgets('InputDecoration.collapsed accepts hintFadeDuration') to write tests

…3183) (flutter/flutter#153235)

Manual roll requested by [email protected] flutter/flutter@fa402c8...ead6b0d 2024-09-27 [email protected] Remove left-over traces of "link-dry-run" - which isn't used anywhere in flutter (flutter/flutter#155820) 2024-09-27 [email protected] Roll Flutter Engine from e57b440ec4ee to 7c603de2dca7 (5 revisions) (flutter/flutter#155811) 2024-09-27 [email protected] Fix DropdownMenu rendered behind AppBar (flutter/flutter#155539) 2024-09-27 [email protected] Roll Flutter Engine from 53517772a5b0 to e57b440ec4ee (8 revisions) (flutter/flutter#155799) 2024-09-27 [email protected] Throw StateError when implicitView is null on `wrapWithDefaultView`. (flutter/flutter#155734) 2024-09-27 [email protected] Roll packages manually (flutter/flutter#155786) 2024-09-27 [email protected] fix: SelectableText should handle focus changes (flutter/flutter#155771) 2024-09-27 [email protected] Use flutter from in same repo (not path) in `generate_gradle_lockfiles.dart` (again) (flutter/flutter#155794) 2024-09-26 [email protected] Use flutter from in same repo (not path) in `generate_gradle_lockfiles.dart` (flutter/flutter#155790) 2024-09-26 [email protected] `RenderParagraph` should invalidate its `_SelectableFragment`s cached rects on window size updates (flutter/flutter#155719) 2024-09-26 [email protected] Fix broken text field with set hint and min and max lines(#153183) (flutter/flutter#153235) 2024-09-26 [email protected] Roll Flutter Engine from 9e6133e8d906 to 53517772a5b0 (1 revision) (flutter/flutter#155772) 2024-09-26 [email protected] Fix line-wrapping in `flutter create` error message. (flutter/flutter#150325) 2024-09-26 [email protected] remove fujino from CODEOWNERS (flutter/flutter#155369) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…3183) (flutter/flutter#153235)

Fix broken text field with set hint and min and max lines(flutter#153183

ce9530b

)

github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 11, 2024

Piinks added the team-text-input Owned by Text Input team label Aug 14, 2024

justinmc requested a review from LongCatIsLooong August 15, 2024 21:59

LongCatIsLooong reviewed Aug 23, 2024

View reviewed changes

packages/flutter/lib/src/material/text_form_field.dart Outdated Show resolved Hide resolved

update variable name

a260c80

github-actions bot removed the a: text input Entering text in a text field or keyboard related problems label Aug 26, 2024

update test

c2eba8f

LongCatIsLooong reviewed Aug 28, 2024

View reviewed changes

packages/flutter/lib/src/material/input_decorator.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/input_decorator.dart Outdated Show resolved Hide resolved

zeqinjie added 4 commits August 29, 2024 23:34

update description

85142d4

update

e7510e8

update

b8b2e32

Merge branch 'master' into fix_153183

4b758d2

zeqinjie requested a review from LongCatIsLooong September 6, 2024 01:58

LongCatIsLooong reviewed Sep 6, 2024

View reviewed changes

packages/flutter/lib/src/material/input_decorator.dart Outdated Show resolved Hide resolved

update curve

65e5e6f

zeqinjie requested a review from LongCatIsLooong September 7, 2024 08:55

update size

4b66cc5

LongCatIsLooong reviewed Sep 12, 2024

View reviewed changes

packages/flutter/lib/src/material/input_decorator.dart Show resolved Hide resolved

packages/flutter/lib/src/material/input_decorator.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/input_decorator.dart Show resolved Hide resolved

zeqinjie added 3 commits September 13, 2024 10:48

update maintainHintHeight and defaults to true

7e13d06

update des

aa4c25e

update

5380404

LongCatIsLooong approved these changes Sep 13, 2024

View reviewed changes

dkwingsmt reviewed Sep 17, 2024

View reviewed changes

packages/flutter/lib/src/material/input_decorator.dart Show resolved Hide resolved

dkwingsmt reviewed Sep 17, 2024

View reviewed changes

update test

d5f0fe1

zeqinjie requested a review from dkwingsmt September 18, 2024 10:32

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

1faec23

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

02db993

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

a905844

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

f964b9e

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 1, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

497ea5c

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

7ea9428

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

0096244

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

b0b975f

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

a5cc2cc

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

bc69967

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 2, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

b065104

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

853f604

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

bfa6412

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

e5a65ba

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

47f89fb

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

4b70b80

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 3, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

c74f086

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

79e1bdf

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

70a3321

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 4, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

efb02b8

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

7e981cf

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 5, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

1efefee

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 6, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

6de9304

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 6, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

3118431

…3183) (flutter/flutter#153235)

engine-flutter-autoroll mentioned this pull request Oct 7, 2024

Manual roll Flutter from fa402c8057a1 to ead6b0d17c89 (14 revisions) flutter/packages#7806

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 7, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

0da6674

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

1712eb2

…3183) (flutter/flutter#153235)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

7f663fc Fix broken text field with set hint and min and max lines(#15…

62cd56d

…3183) (flutter/flutter#153235)

zeqinjie deleted the fix_153183 branch January 4, 2025 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix broken text field with set hint and min and max lines(#153183)#153235

Fix broken text field with set hint and min and max lines(#153183)#153235
auto-submit[bot] merged 14 commits intoflutter:masterfrom
zeqinjie:fix_153183

zeqinjie commented Aug 11, 2024 •

edited

Loading

Uh oh!

LongCatIsLooong left a comment

Uh oh!

Uh oh!

zeqinjie commented Aug 26, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LongCatIsLooong left a comment

Uh oh!

Uh oh!

dkwingsmt Sep 17, 2024

Uh oh!

zeqinjie Sep 18, 2024

Uh oh!

Uh oh!

Uh oh!

dkwingsmt Sep 17, 2024

Uh oh!

zeqinjie Sep 18, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	testWidgets('hint should be ignore its height when input text', (WidgetTester tester) async {
	testWidgets('Ignore hint height on non-empty text', (WidgetTester tester) async {

Conversation

zeqinjie commented Aug 11, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zeqinjie commented Aug 26, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dkwingsmt Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

zeqinjie Sep 18, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dkwingsmt Sep 17, 2024

Choose a reason for hiding this comment

Uh oh!

zeqinjie Sep 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

zeqinjie commented Aug 11, 2024 •

edited

Loading

zeqinjie Sep 18, 2024 •

edited

Loading