added enabled to search anchor by Macacoazul01 · Pull Request #153256 · flutter/flutter

Macacoazul01 · 2024-08-12T01:06:12Z

Added the same parameter from #137388 to the SearchAnchor

This PR will fix: #150331

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

QuncCccccc

LGTM:) Thanks for the contribution!

packages/flutter/test/material/search_anchor_test.dart

packages/flutter/lib/src/material/search_anchor.dart

Renzo-Olivares

LGTM, w/ small nit. Thanks for the contribution!

justinmc

Maybe it's kind of not ideal that you'll have to pass enabled: false to both SearchBar and SearchAnchor, but I guess that's the best we can do with that builder approach. So I think this approach looks good, just some small code and docs comments. Thanks for the PR!

packages/flutter/lib/src/material/search_anchor.dart

packages/flutter/test/material/search_anchor_test.dart

Co-authored-by: Qun Cheng <[email protected]>

change docs

packages/flutter/test/material/search_anchor_test.dart

packages/flutter/lib/src/material/search_anchor.dart

Macacoazul01 · 2024-08-30T22:53:31Z

@justinmc the only viable option that i found was with

expect(searchBarFinder.hitTestable().tryEvaluate(), false);

When enabled: false, searchBarFinder.hitTestable().tryEvaluate() returns false

When enabled: true, searchBarFinder.hitTestable().tryEvaluate() returns true

justinmc

LGTM 👍

Take a look at getOpacity though, I think it can be private.

packages/flutter/lib/src/material/search_anchor.dart

packages/flutter/test/material/search_anchor_test.dart

added enabled to search anchor

d6cb1ea

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 12, 2024

add tap failed test

1939693

Piinks requested a review from QuncCccccc August 14, 2024 18:30

Merge branch 'master' into origem

98996c6

QuncCccccc approved these changes Aug 21, 2024

View reviewed changes

Renzo-Olivares reviewed Aug 21, 2024

View reviewed changes

packages/flutter/lib/src/material/search_anchor.dart Outdated Show resolved Hide resolved

Renzo-Olivares approved these changes Aug 21, 2024

View reviewed changes

justinmc reviewed Aug 21, 2024

View reviewed changes

packages/flutter/lib/src/material/search_anchor.dart Outdated Show resolved Hide resolved

packages/flutter/lib/src/material/search_anchor.dart Show resolved Hide resolved

packages/flutter/test/material/search_anchor_test.dart Outdated Show resolved Hide resolved

Macacoazul01 and others added 5 commits August 28, 2024 12:28

Update packages/flutter/test/material/search_anchor_test.dart

f193e5f

Co-authored-by: Qun Cheng <[email protected]>

Update packages/flutter/test/material/search_anchor_test.dart

1304dce

Co-authored-by: Qun Cheng <[email protected]>

Merge branch 'master' into origem

c62818e

Update search_anchor.dart

ef41788

change docs

Update search_anchor_test.dart

b4277e7

justinmc reviewed Aug 29, 2024

View reviewed changes

packages/flutter/test/material/search_anchor_test.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/search_anchor_test.dart Outdated Show resolved Hide resolved

justinmc reviewed Aug 29, 2024

View reviewed changes

packages/flutter/lib/src/material/search_anchor.dart Show resolved Hide resolved

Macacoazul01 added 5 commits August 30, 2024 19:09

add docs

c6b02c1

fix opacity

3bda52d

Update search_anchor.dart

80112dc

fix test

898f79c

Merge branch 'master' into origem

8845199

Merge branch 'master' into origem

a0dad6c

justinmc approved these changes Sep 3, 2024

View reviewed changes

packages/flutter/lib/src/material/search_anchor.dart Outdated Show resolved Hide resolved

packages/flutter/test/material/search_anchor_test.dart Show resolved Hide resolved

Update search_anchor.dart

79b1695

Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 4, 2024

auto-submit bot merged commit ce15e3b into flutter:master Sep 4, 2024

engine-flutter-autoroll mentioned this pull request Sep 4, 2024

Roll Flutter from b8f89f70bf4e to 4e8df8be3148 (192 revisions) flutter/packages#7582

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024

ce15e3b added enabled to search anchor (flutter/flutter#153256)

e226ef9

engine-flutter-autoroll mentioned this pull request Sep 5, 2024

Roll Flutter from b8f89f70bf4e to a7cd788d80cc (201 revisions) flutter/packages#7584

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

ce15e3b added enabled to search anchor (flutter/flutter#153256)

79e6277

engine-flutter-autoroll mentioned this pull request Sep 5, 2024

Roll Flutter from b8f89f70bf4e to 45ef8f36ff41 (202 revisions) flutter/packages#7585

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

ce15e3b added enabled to search anchor (flutter/flutter#153256)

d22fbe0

engine-flutter-autoroll mentioned this pull request Sep 5, 2024

Roll Flutter from b8f89f70bf4e to a3301cecae28 (203 revisions) flutter/packages#7588

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

ce15e3b added enabled to search anchor (flutter/flutter#153256)

63b3c26

engine-flutter-autoroll mentioned this pull request Sep 5, 2024

Roll Flutter from b8f89f70bf4e to 834566f05d36 (204 revisions) flutter/packages#7589

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

ce15e3b added enabled to search anchor (flutter/flutter#153256)

0fa9b6a

engine-flutter-autoroll mentioned this pull request Sep 5, 2024

Roll Flutter from b8f89f70bf4e to fea5d1ec0394 (205 revisions) flutter/packages#7590

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024

ce15e3b added enabled to search anchor (flutter/flutter#153256)

eb399b4

bleroux mentioned this pull request Sep 6, 2024

Would like a way to disable SearchAnchor #154700

Closed

Piinks mentioned this pull request Sep 6, 2024

Flutter Framework Team: Notable Commits #121415

Closed

danagbemava-nc mentioned this pull request Oct 2, 2024

Clicking a disabled SearchBar opens the search view #156077

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

ce15e3b added enabled to search anchor (flutter/flutter#153256)

0ccc46e

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

ce15e3b added enabled to search anchor (flutter/flutter#153256)

ecec9cb

Macacoazul01 deleted the origem branch December 27, 2024 00:19

Macacoazul01 mentioned this pull request Jan 2, 2025

Add enabled property to searchanchor.bar #161063

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added enabled to search anchor#153256

added enabled to search anchor#153256
auto-submit[bot] merged 15 commits intoflutter:masterfrom
Macacoazul01:origem

Macacoazul01 commented Aug 12, 2024

Uh oh!

QuncCccccc left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Renzo-Olivares left a comment •

edited

Loading

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Macacoazul01 commented Aug 30, 2024

Uh oh!

justinmc left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Macacoazul01 commented Aug 12, 2024

Pre-launch Checklist

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Renzo-Olivares left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Macacoazul01 commented Aug 30, 2024

Uh oh!

justinmc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Renzo-Olivares left a comment •

edited

Loading