Improve asserts on Element.mount#153477
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Aug 15, 2024
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
the
framework
nate-thegrate
approved these changes
Aug 15, 2024
Contributor
nate-thegrate
left a comment
nate-thegrate
left a comment
There was a problem hiding this comment.
LGTM, with optional whitespace nit.
Thank you!
Contributor
|
test-exempt: Updating assert messages (debug only). |
Fixing whitespace. Co-authored-by: Nate Wilson <[email protected]>
gspencergoog
added
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/153477, due to - The status or check suite Windows build_tests_1_7 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
bot
removed
the
autosubmit
gspencergoog
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 16, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 16, 2024
Manual roll requested by [email protected] flutter/flutter@99f00a1...bced008 2024-08-16 [email protected] Roll Flutter Engine from 68938abd03b9 to a8fefc81188e (1 revision) (flutter/flutter#153537) 2024-08-16 [email protected] [interactive_media_ads] Adds missing IMA plugin to issue template (flutter/flutter#153510) 2024-08-16 [email protected] Roll Flutter Engine from 65fd6ca194c1 to 68938abd03b9 (1 revision) (flutter/flutter#153533) 2024-08-16 [email protected] Roll Flutter Engine from 8f3f80ec1225 to 65fd6ca194c1 (1 revision) (flutter/flutter#153529) 2024-08-15 [email protected] Manual roll Flutter Engine from 971ddd9fe1bf to 8f3f80ec1225 (5 revisions) (flutter/flutter#153525) 2024-08-15 [email protected] Add `TextHeightBehavior` argument for `DefaultTextStyle.merge` (flutter/flutter#153178) 2024-08-15 [email protected] Update TextTheme with the M3 Typography tokens (flutter/flutter#153131) 2024-08-15 [email protected] Design-Documents.md incorrect link (flutter/flutter#153509) 2024-08-15 [email protected] Roll `avd_cipd_verison` to latest to use the `crashreport` tool. (flutter/flutter#153520) 2024-08-15 [email protected] Improve asserts on Element.mount (flutter/flutter#153477) 2024-08-15 [email protected] Fix anti-aliasing when painting borders with solid colors. (flutter/flutter#153365) 2024-08-15 [email protected] Roll pub packages (flutter/flutter#153479) 2024-08-15 [email protected] Roll Packages from e4f2247 to 86d15a6 (7 revisions) (flutter/flutter#153499) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
## Description In debugging an issue with mount, I hit one of these asserts, and I thought it would be a much better assert with some context. ## Tests - No test changes because the change is only to the output string of an assert.
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
## Description In debugging an issue with mount, I hit one of these asserts, and I thought it would be a much better assert with some context. ## Tests - No test changes because the change is only to the output string of an assert.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In debugging an issue with mount, I hit one of these asserts, and I thought it would be a much better assert with some context.
Tests