Add missing tests for requestFocus routes parameter in Material and Cupertino libraries#154005
Merged
auto-submit[bot] merged 2 commits intoflutter:masterfrom Aug 28, 2024
TahaTesser:request_focus_routes_tests
Merged
Add missing tests for requestFocus routes parameter in Material and Cupertino libraries#154005auto-submit[bot] merged 2 commits intoflutter:masterfrom TahaTesser:request_focus_routes_tests
requestFocus routes parameter in Material and Cupertino libraries#154005auto-submit[bot] merged 2 commits intoflutter:masterfrom
TahaTesser:request_focus_routes_tests
Conversation
github-actions
bot
added
framework
9 tasks
… Cupertino libraries
justinmc
approved these changes
Aug 27, 2024
Comment on lines
+2859
to
+2860
| await tester.pump(); | ||
| await tester.pump(const Duration(milliseconds: 100)); |
Contributor
Author
There was a problem hiding this comment.
This advances the route transition animation by updating the frames and then advancing the animation by 100ms.
Another way to achieve this is to use pumpAndSettle. In some reviews, Hixie preferred this style we know how many frames are pushed to get the results.
Contributor
There was a problem hiding this comment.
I've discussed that with Hixie as well and I agree with this way over pumpAndSettle 👍 . Thanks for the explanation!
Contributor
Author
There was a problem hiding this comment.
Thanks @justinmc. Apologies if i merged it before your reply.
| expect(simpleDialog.insetPadding, isNull); | ||
| }); | ||
|
|
||
| // This is a regression test for https://github.com/flutter/flutter/issues/153983. |
Contributor
There was a problem hiding this comment.
Did you just remember this?
Contributor
Author
There was a problem hiding this comment.
Added comment for a test added in #154173 when resolving git conflicts.
TahaTesser
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 28, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 29, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 29, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 29, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 29, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 29, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 29, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 29, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 30, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 31, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 31, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 1, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
… Cupertino libraries (flutter#154005) Fixes [Add missing tests for `requestFocus` routes parameter](flutter#153999)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
…rial and Cupertino libraries (flutter/flutter#154005)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Add missing tests for
requestFocusroutes parameterPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.