Skip to content

Add verbose logging for customer testing shard#154356

Merged
Piinks merged 1 commit intoflutter:masterfrom
Piinks:verboseLogging
Aug 29, 2024
Merged

Add verbose logging for customer testing shard#154356
Piinks merged 1 commit intoflutter:masterfrom
Piinks:verboseLogging

Conversation

@Piinks
Copy link
Contributor

@Piinks Piinks commented Aug 29, 2024

Related to #154251

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 29, 2024

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

christopherfujino
christopherfujino approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks Piinks merged commit 1c6defc into flutter:master Aug 29, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
6d48195 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 29, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 29, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
e55a48a 
…er#154356)
Piinks added a commit that referenced this pull request Aug 29, 2024
@Piinks
Revert "Add verbose logging for customer testing shard (#154356)"
960c5af 
This reverts commit 1c6defc.
@Piinks Piinks mentioned this pull request Aug 29, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
435e010 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
46c0dfd 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
72904ea 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
eec611a 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
aa3cdc9 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
763b7ef 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
2f78e18 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 30, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 30, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
be07742 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
297e55b 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 31, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 31, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
310033c 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 1, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 1, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
93ac958 
…er#154356)
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@Piinks @Buchimi
Add verbose logging for customer testing shard (flutter#154356)
f1a3ca8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
607e0a4 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
7a35fd1 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
a23d35f 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
3055f97 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
7f9bedb 
…er#154356)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 3, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 3, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
22acc5d 
…er#154356)
@Piinks Piinks mentioned this pull request Sep 3, 2024
Merged
9 tasks
auto-submit bot pushed a commit that referenced this pull request Sep 3, 2024
@Piinks
Update customer test logging (#154577)
72ebfc7 
Reverts #154356, and updates logging so that the test suite's name and runtime is always logged, not just on failure.

The issue is resolved in flutter/tests#406 
Related to #154251
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
8fb1448 
…er#154356)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
ea88899 
…er#154356)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
cc48ce0 
…er#154356)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
35f1918 
…er#154356)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
87deec5 
…er#154356)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 4, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
f5080dc 
…er#154356)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
d8023aa 
…er#154356)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
76ca5ea 
…er#154356)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
b0622ff 
…er#154356)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
dc24d1b 
…er#154356)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 5, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
01bd93e 
…er#154356)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
8e9ee89 
…er#154356)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
1c6defc Add verbose logging for customer testing shard (flutter/flutt…
2d96f69 
…er#154356)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Piinks @christopherfujino