Merged
Conversation
yjbanov
reviewed
Mar 12, 2018
| new PluginTest('ios', <String>['-i', 'objc']), | ||
| new PluginTest('ios', <String>['-i', 'swift']), | ||
| // TODO(mravn): Re-enable this once CocoaPods is upgraded on device lab. | ||
| // new PluginTest('ios', <String>['-i', 'swift']), |
Contributor
There was a problem hiding this comment.
Alternatively you could mark the test as flaky until it becomes green with Swift support.
Contributor
Author
There was a problem hiding this comment.
Right. But it isn't flaky. It'll fail consistently...
Contributor
There was a problem hiding this comment.
We also use the flaky flag when debugging new tests or big changes to tests when we're not sure that they will pass. If they look green after a few commits, we flip the flag.
Contributor
Author
There was a problem hiding this comment.
OK. Test marked flaky instead.
yjbanov
approved these changes
Mar 12, 2018
Contributor
|
|
Contributor
|
Force-submitting this to unbreak the build. AppVeyor and Travis don't do anything useful with the changed file anyway. |
Contributor
Author
|
Thanks, @yjbanov |
DaveShuckerow
pushed a commit
to DaveShuckerow/flutter
that referenced
this pull request
May 14, 2018
* Silence broken test * Mark test as flaky instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CocoaPods needs upgrading on the device lab before the Swift plugin test can run.