Fix Material 3 AppBar.leading action IconButtons#154512
Fix Material 3 AppBar.leading action IconButtons#154512auto-submit[bot] merged 2 commits intoflutter:masterfrom TahaTesser:fix_m3_app_bar_leading_size
AppBar.leading action IconButtons#154512Conversation
| final bool isIconButton = leading is IconButton | ||
| || leading is CloseButton | ||
| || leading is BackButton | ||
| || leading is DrawerButton; |
There was a problem hiding this comment.
Is there a better way to detect these additional buttons use IconButton underneath?
There was a problem hiding this comment.
Can we refactor _ActionButton to extends IconButton? Seems _ActionButton just returns a IconButton
There was a problem hiding this comment.
While exploring this suggestion I realized i also missed EndDrawerButton in this check. This really goes to show this type of fix is not very robust.
There was a problem hiding this comment.
Refactored the _ActionButton to extend IconButton and reverted the updated check
| final bool isIconButton = leading is IconButton | ||
| || leading is CloseButton | ||
| || leading is BackButton | ||
| || leading is DrawerButton; |
There was a problem hiding this comment.
Can we refactor _ActionButton to extends IconButton? Seems _ActionButton just returns a IconButton
|
@QuncCccccc this seems to be failing Google testing |
I'm working on it!😎 Update: sent cl/671169268 and cl/671527109 for review |
|
@QuncCccccc thanks for helping! |
Fixes
AppBarback button focus/hover circle should not fill up whole heightFixes [Material 3] Date Range Picker close button has incorrect shape
This updates the leading condition added in #110722
Code sample
expand to view the code sample
Before
After
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.