Move FlutterLogo out of Material library#154711
Move FlutterLogo out of Material library#154711SohanRaidev wants to merge 5 commits intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
github-actions
bot
added
a: text input
There was a problem hiding this comment.
To verify that the new import works, this needs a test. However, we already have a test for FlutterLogo at
https://github.com/flutter/flutter/blob/master/packages/flutter/test/material/flutter_logo_test.dart
Could you move flutter_logo_test.dart to test/widgets/flutter_logo_test.dart (so essentially also moving the test file)
and update the import in that file to point to the widgets library? That would be sufficient as a test for this.
(updating the import statement is the new test)
There was a problem hiding this comment.
Thanks for the feedback, Sir! I'll make the changes and update the test file as soon as I can. I'll notify you once it's done.
There was a problem hiding this comment.
Hi @navaronbracke , I’ve made the requested changes. I’ve moved flutter_logo_test.dart to the widgets directory and updated the import to point to the widgets library. Please review when you have time. Thank you!
There was a problem hiding this comment.
Test file is still under material directory.
|
This still has an analysis failure: If you run |
|
Thanks for pointing that out! I'll fix it as soon as possible and update the PR. |
|
@SohanRaidev there are still some failing checks here, can you take a look? |
|
Closing as #155864 fixes the accompanying issue. |
The PR is moving FlutterLogo from `lib/src/material` to `lib/src/widgets` because it has no dependency on Material. Issue: flutter#154448 PS: There is [older PR](flutter#154711) for this issue and I don't know the policy on conflicting PRs. Let me know if I need to drop mine.
6 participants
Fixes #154448
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.