Reverts "Support custom transition duration for DialogRoute, CupertinoDialogRoute and show dialog methods. (#154048)"#154743
Merged
auto-submit[bot] merged 1 commit intomasterfrom Sep 6, 2024
Conversation
auto-submit
bot
added
the
revert of
github-actions
bot
added
framework
fluttergithubbot
approved these changes
Sep 6, 2024
auto-submit
bot
deleted the
revert_0eaeb0d1c5dc8b6d705828e7eebe0fc16b47419b
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 7, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 7, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 8, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 8, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 9, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 9, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 9, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 9, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 10, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 10, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 10, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 10, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 10, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 10, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 11, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 11, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 11, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 11, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 11, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 11, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 11, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 12, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 12, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 12, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 12, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
…, `CupertinoDialogRoute` and show dialog methods. (#154048)" (flutter/flutter#154743)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts: #154048
Initiated by: nate-thegrate
Reason for reverting: using
AnimationStyleinstead would allow for complete animation duration and curve customization.Original PR Author: nploi
Reviewed By: {piedcipher, nate-thegrate}
This change reverts the following previous change:
Currently we don't support custom transition duration for
DialogRoute,CupertinoDialogRouteand show dialog methods , This PR will to support that.Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.