Skip to content

Improve tracing and fix packages_autoroller#154841

Merged
auto-submit[bot] merged 8 commits intomasterfrom
revert-154555-revert-154441-add-logging-to-packages-autoroller
Sep 9, 2024
Merged

Improve tracing and fix packages_autoroller#154841
auto-submit[bot] merged 8 commits intomasterfrom
revert-154555-revert-154441-add-logging-to-packages-autoroller

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Sep 9, 2024 •
edited
Loading

Reverts #154555
Re-lands of #154441 and #154369

New changes in this PR:

  1. extend timeout of the Linux packages_autoroller shard (see step 14 in this example LED build)
  2. use the managed framework repo as the working directory in the framework.streamDart() helper function--we were generating gradle lockfiles in the wrong directory

A LED build with this code generated the following gradle lockfile update: d939981

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 9, 2024
@christopherfujino
Copy link
Contributor Author

christopherfujino commented Sep 9, 2024

A LED test of this PR is this build: https://ci.chromium.org/ui/p/flutter/builders/prod.shadow/Linux%20packages_autoroller/6/infra

(which says No diff after calling generate_gradle_lockfiles.dart, which seems impossible)

Which opened this PR: https://github.com/flutter/flutter/pull/154852/files

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Sep 9, 2024

Ok, one more fix commit, and another LED build: https://ci.chromium.org/ui/p/flutter/builders/prod.shadow/Linux%20packages_autoroller/7/infra

@christopherfujino
Copy link
Contributor Author

christopherfujino commented Sep 9, 2024

Ok, one more fix commit, and another LED build: https://ci.chromium.org/ui/p/flutter/builders/prod.shadow/Linux%20packages_autoroller/7/infra

This succeeded, and successfully created a roll with gradle lockfiles: #154859 (it also has all the code changes from this PR, so I will not merge it).

@christopherfujino christopherfujino marked this pull request as ready for review September 9, 2024 21:56
@christopherfujino christopherfujino changed the title Re-land "improve trace logging in packages autoroller" Improve tracing and fix packages_autoroller Sep 9, 2024
goderbauer
goderbauer approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 9, 2024
@auto-submit auto-submit bot merged commit 92697d3 into master Sep 9, 2024
@auto-submit auto-submit bot deleted the revert-154555-revert-154441-add-logging-to-packages-autoroller branch September 9, 2024 23:31
This was referenced Sep 9, 2024
Closed
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
bf988df 
…154841)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
e54bafe 
…154841)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
7e65610 
…154841)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
1a8d18e 
…154841)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
35cf5f9 
…154841)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 10, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 10, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
6737013 
…154841)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
047bfb3 
…154841)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
fef4312 
…154841)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
5bb7148 
…154841)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
4e8abd7 
…154841)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
d135a79 
…154841)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
73d540b 
…154841)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 11, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
ae2bb04 
…154841)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
19c6b3a 
…154841)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
7fa33e6 
…154841)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
3ec543b 
…154841)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
ddc6d3a 
…154841)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
6eaad17 
…154841)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
92697d3 Improve tracing and fix packages_autoroller (flutter/flutter#…
6d2ff97 
…154841)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

@gmackall gmackall Awaiting requested review from gmackall

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@christopherfujino @goderbauer