Migrate Color.toString() test, improves `equalsIgnoringHashCodes` by gaaclarke · Pull Request #154934 · flutter/flutter

gaaclarke · 2024-09-10T17:23:40Z

This migrates the last failing test for flutter/engine#54981. In order to effectively resolve that test I had to make equalsIgnoringHashCodes more usable by printing out the line that differs instead of just a huge blob of "expected" vs "actual.

example

Here's the output after the change.

test

  test('equalsIgnoringHashCodes - wrong line', () {
    expect(
      '1\n2\n3\n4\n5\n6\n7\n8\n9\n10',
      equalsIgnoringHashCodes('1\n2\n3\n4\n5\n6\na\n8\n9\n10'),
    );
  });

output

Expected: normalized value matches
          '1\n'
            '2\n'
            '3\n'
            '4\n'
            '5\n'
            '6\n'
            'a\n'
            '8\n'
            '9\n'
            '10'
  Actual: '1\n'
            '2\n'
            '3\n'
            '4\n'
            '5\n'
            '6\n'
            '7\n'
            '8\n'
            '9\n'
            '10'
   Which: Lines 7 differed, expected: 
          'a'
          but got
          '7'

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

goderbauer · 2024-09-10T22:47:57Z

Looks like some checks are unhappy on this one.

…oString() test

gaaclarke · 2024-09-10T22:51:10Z

Looks like some checks are unhappy on this one.

@goderbauer It was a bad rebase, it missed my last PR that landed somehow. It should be good now.

goderbauer

LGTM, but can you add a test to test the new matcher output?

gaaclarke · 2024-09-10T23:36:12Z

LGTM, but can you add a test to test the new matcher output?

None of the output for matchers are tested because there's no way to grab the text. I think we'd have to make the Matcher exported in order to be able to test the output text. I figured that was by design. Let me know if there is another way.

gaaclarke · 2024-09-11T16:57:18Z

LGTM, but can you add a test to test the new matcher output?

I found a way to do it by catching the exception, done.

jonahwilliams · 2024-09-11T16:59:58Z

packages/flutter_test/test/matchers_test.dart

+  test('equalsIgnoringHashCodes - wrong line', () {
+    TestFailure? failure;
+    try {
+      expect(
+        '1\n2\n3\n4\n5\n6\n7\n8\n9\n10',
+        equalsIgnoringHashCodes('1\n2\n3\n4\n5\n6\na\n8\n9\n10'),
+      );
+    } on TestFailure catch (e) {
+      failure = e;
+    }
+
+    expect(failure, isNotNull);
+    if (failure != null) {
+      final String? message = failure.message;
+      expect(message, contains('Lines 7 differed'));
+      expect(message, contains("'a'"));
+      expect(message, contains("'7'"));
+    }
+  });


there is also a way to do this with test matchers FYI

expect(() => methodThatThrows()), throwsA<TestFailure>() .having(..put prop checks here..)

jonahwilliams

LGTM

…des` (flutter/flutter#154934)

Roll Flutter from 2e221e7 to 303f222 (77 revisions) flutter/flutter@2e221e7...303f222 2024-09-12 [email protected] Manual roll to 48ddaf578fb0c8326d5b4b680b0f49ea72e33216 (flutter/flutter#155070) 2024-09-12 [email protected] Externalize and update onboarding instructions (flutter/flutter#154730) 2024-09-12 [email protected] when setting up the log reader for a device during `flutter run`, discard any `RPCError` thrown due to the device being disconnected (flutter/flutter#155049) 2024-09-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "iOS: update provisioning profile for 2024-2025 cert (#155052)" (flutter/flutter#155059) 2024-09-12 [email protected] iOS: update provisioning profile for 2024-2025 cert (flutter/flutter#155052) 2024-09-11 [email protected] Factor out `Container` objects (flutter/flutter#153619) 2024-09-11 [email protected] Move (`dev/tools`), complete v0 of `native_driver` (Android) (flutter/flutter#154843) 2024-09-11 [email protected] Roll Flutter Engine from ade8ef293bc6 to ee5adf6d2ee1 (2 revisions) (flutter/flutter#155046) 2024-09-11 [email protected] Fix `flutter run` on Mac x64 hosts if Swift Package Manager is enabled (flutter/flutter#154645) 2024-09-11 [email protected] Roll Packages from bb53e5d to 4c18648 (1 revision) (flutter/flutter#155033) 2024-09-11 [email protected] Roll Flutter Engine from 4eb729b7a5c4 to ade8ef293bc6 (3 revisions) (flutter/flutter#155031) 2024-09-11 [email protected] fix: Dropdown menu trying to access highlight element which doesn't exist when search and filters both are enabled (flutter/flutter#151969) 2024-09-11 [email protected] Marks Linux build_tests_3_5 to be unflaky (flutter/flutter#154993) 2024-09-11 [email protected] Add 'direction' allow to 'SegmentedButton' oriented vertically (flutter/flutter#150903) 2024-09-11 [email protected] Marks Linux build_tests_5_5 to be unflaky (flutter/flutter#154995) 2024-09-11 [email protected] Update the signature of DDS launcher callback. (flutter/flutter#154949) 2024-09-11 [email protected] Migrate Color.toString() test, improves `equalsIgnoringHashCodes` (flutter/flutter#154934) 2024-09-11 [email protected] Update material and cupertino localizations (flutter/flutter#154959) 2024-09-11 [email protected] Marks Linux build_tests_1_5 to be unflaky (flutter/flutter#154991) 2024-09-11 [email protected] Marks Linux build_tests_2_5 to be unflaky (flutter/flutter#154992) 2024-09-11 [email protected] Fix `flutter create` warning regarding Java compatibility (flutter/flutter#152836) 2024-09-11 [email protected] Roll Flutter Engine from 54757dab9462 to 4eb729b7a5c4 (1 revision) (flutter/flutter#155022) 2024-09-11 [email protected] Fix java version used by `build_aar_module_test` (flutter/flutter#154967) 2024-09-11 [email protected] Roll Flutter Engine from 0a14c519ea4f to 54757dab9462 (1 revision) (flutter/flutter#155015) 2024-09-11 [email protected] Roll Flutter Engine from 35a3171b72c5 to 0a14c519ea4f (1 revision) (flutter/flutter#154984) 2024-09-11 [email protected] Roll Flutter Engine from b9c0b96c3316 to 35a3171b72c5 (1 revision) (flutter/flutter#154980) 2024-09-11 [email protected] Roll Flutter Engine from 52eeea075767 to b9c0b96c3316 (1 revision) (flutter/flutter#154976) 2024-09-11 [email protected] Roll Flutter Engine from a26075f9b1e6 to 52eeea075767 (1 revision) (flutter/flutter#154973) 2024-09-11 [email protected] Roll Flutter Engine from 60c15bc0f40e to a26075f9b1e6 (6 revisions) (flutter/flutter#154969) 2024-09-11 [email protected] Migrate `apple-mobile-web-*` to `mobile-web-*`. (flutter/flutter#154964) 2024-09-11 [email protected] Roll Flutter Engine from 8a038a6f7099 to 60c15bc0f40e (15 revisions) (flutter/flutter#154960) 2024-09-10 [email protected] Adds dart fixes for Color opacity functions (flutter/flutter#154953) 2024-09-10 [email protected] Missing benchmarks for `foundation/all_elements_bench.dart` (flutter/flutter#154954) 2024-09-10 [email protected] Update color assertions (flutter/flutter#154752) 2024-09-10 [email protected] handle EAGAIN (macOS) in ErrorHandlingProcessManager (flutter/flutter#154306) 2024-09-10 [email protected] fix unpack freezing app with animation duration zero (flutter/flutter#153890) 2024-09-10 [email protected] Remove last `--disable-dart-dev` in `flutter/flutter`. (flutter/flutter#154948) 2024-09-10 [email protected] Remove scheduler: luci from new `build_aar_module_test` (flutter/flutter#154945) 2024-09-10 [email protected] Roll pub packages (flutter/flutter#154939) 2024-09-10 [email protected] `CupertinoSlidingSegmentedControl` update (flutter/flutter#152976) 2024-09-10 [email protected] Roll pub packages (flutter/flutter#154933) 2024-09-10 [email protected] fix test `chrome.close can recover if getTab throws a StateError` (flutter/flutter#154889) 2024-09-10 [email protected] SearchBar context menu (flutter/flutter#154833) 2024-09-10 [email protected] Fix `flutter build aar` for modules that use a plugin (flutter/flutter#154757) 2024-09-10 [email protected] Roll Packages from b4e0fc1 to bb53e5d (4 revisions) (flutter/flutter#154926) 2024-09-10 [email protected] Clean up `SnackBar` inherit theme data test (flutter/flutter#154921) ...

…des` (flutter/flutter#154934)

gaaclarke force-pushed the better-string-matcher branch from 3c396b8 to 20a1409 Compare September 10, 2024 22:37

gaaclarke changed the title ~~Better string matcher~~ Migrate Color.toString() test, improves equalsIgnoringHashCodes Sep 10, 2024

gaaclarke requested a review from goderbauer September 10, 2024 22:39

gaaclarke marked this pull request as ready for review September 10, 2024 22:39

Improves equalsIgnoringHashCodes error messages, migrates one Color.t…

f60fd2d

…oString() test

gaaclarke force-pushed the better-string-matcher branch from 20a1409 to f60fd2d Compare September 10, 2024 22:50

goderbauer reviewed Sep 10, 2024

View reviewed changes

gaaclarke requested review from gspencergoog and removed request for gspencergoog September 11, 2024 15:14

added test for matcher output

4175edb

gaaclarke requested a review from goderbauer September 11, 2024 16:57

jonahwilliams reviewed Sep 11, 2024

View reviewed changes

jonahwilliams approved these changes Sep 11, 2024

View reviewed changes

gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 11, 2024

auto-submit bot merged commit b5ce70a into flutter:master Sep 11, 2024

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to 6e46ee8d6d6f (63 revisions) flutter/packages#7629

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

b5ce70a Migrate Color.toString() test, improves `equalsIgnoringHashCo…

e3c6ea5

…des` (flutter/flutter#154934)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to 04e1b174ea6d (66 revisions) flutter/packages#7630

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

b5ce70a Migrate Color.toString() test, improves `equalsIgnoringHashCo…

31737b6

…des` (flutter/flutter#154934)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to 50a190caec0c (74 revisions) flutter/packages#7634

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

b5ce70a Migrate Color.toString() test, improves `equalsIgnoringHashCo…

7412289

…des` (flutter/flutter#154934)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to d8f8613a5b94 (75 revisions) flutter/packages#7635

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

b5ce70a Migrate Color.toString() test, improves `equalsIgnoringHashCo…

a0540f8

…des` (flutter/flutter#154934)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to 90aa59f6c32f (76 revisions) flutter/packages#7637

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

b5ce70a Migrate Color.toString() test, improves `equalsIgnoringHashCo…

007c058

…des` (flutter/flutter#154934)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to 303f222e17e3 (77 revisions) flutter/packages#7638

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

b5ce70a Migrate Color.toString() test, improves `equalsIgnoringHashCo…

b51c71c

…des` (flutter/flutter#154934)

Piinks mentioned this pull request Sep 14, 2024

Flutter Framework Team: Notable Commits #121415

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

b5ce70a Migrate Color.toString() test, improves `equalsIgnoringHashCo…

8a9ed52

…des` (flutter/flutter#154934)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

b5ce70a Migrate Color.toString() test, improves `equalsIgnoringHashCo…

fa7a6ab

…des` (flutter/flutter#154934)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate Color.toString() test, improves `equalsIgnoringHashCodes`#154934

Migrate Color.toString() test, improves `equalsIgnoringHashCodes`#154934
auto-submit[bot] merged 2 commits intoflutter:masterfrom
gaaclarke:better-string-matcher

gaaclarke commented Sep 10, 2024 •

edited

Loading

Uh oh!

goderbauer commented Sep 10, 2024

Uh oh!

gaaclarke commented Sep 10, 2024

Uh oh!

goderbauer left a comment

Uh oh!

gaaclarke commented Sep 10, 2024

Uh oh!

gaaclarke commented Sep 11, 2024

Uh oh!

jonahwilliams Sep 11, 2024

Uh oh!

jonahwilliams left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

gaaclarke commented Sep 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

example

test

output

Pre-launch Checklist

Uh oh!

goderbauer commented Sep 10, 2024

Uh oh!

gaaclarke commented Sep 10, 2024

Uh oh!

goderbauer left a comment

Choose a reason for hiding this comment

Uh oh!

gaaclarke commented Sep 10, 2024

Uh oh!

gaaclarke commented Sep 11, 2024

Uh oh!

jonahwilliams Sep 11, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gaaclarke commented Sep 10, 2024 •

edited

Loading