[CP-stable] Cherry pick "Fix flutter build aar for modules that use a plugin"#154944
Merged
auto-submit[bot] merged 4 commits intoflutter:flutter-3.24-candidate.0from Sep 11, 2024
Merged
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
github-actions
bot
added
the
tool
gmackall
changed the title
flutter build aar for modules that use a plugin"
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
itsjustkevin
added
the
autosubmit
This was referenced Sep 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 12, 2024
…that use a plugin" (flutter/flutter#154944)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 13, 2024
…that use a plugin" (flutter/flutter#154944)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 13, 2024
…that use a plugin" (flutter/flutter#154944)
ghost
mentioned this pull request
9 tasks
AhmedMagdy-10
pushed a commit
to AhmedMagdy-10/flutter
that referenced
this pull request
Oct 6, 2024
nxjdrk
pushed a commit
to nxjdrk/flutter
that referenced
this pull request
Oct 9, 2024
Gustl22
pushed a commit
to Gustl22/flutter
that referenced
this pull request
Nov 13, 2024
…er#155044) # Flutter stable 3.24.3 Framework ## Scheduled Cherrypicks - flutter#154380 - flutter#154720 - flutter#154944
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sum of changes is:
cherry pick of #154757
Merge
manual application of of #154945
manual application of #154967
Copied form below from automatic label (this is a cherry pick of #154757).
Issue Link:
What is the link to the issue this cherry-pick is addressing?
Fixes #154371.
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
Fixes a crash when building Flutter modules for android with
flutter build aar, when using Android Gradle Plugin 8.0+.Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
Fixes the mentioned crash when building a module as an aar with Android Gradle Plugin 8.0+.
Workaround:
Is there a workaround for this issue?
No.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
Build a module:
flutter create foobar --template=modulecd foobar.android/build.gradleto use AGP 8.1.flutter run/flutter build aarPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.