Please let me know if these tests are sufficient. I encountered some unexpected behaviors during the test, so I decided not to test behaviors for now.

Different occurrences

I tried:

testWidgets('raw occurrences', (WidgetTester tester) async {
    await tester.pumpWidget(const example.GlowingOverscrollIndicatorExampleApp());
    final Finder goiFinder = find.byType(GlowingOverscrollIndicator);
    print(goiFinder);
});

and when testing glowing_overscroll_indicator.0.dart the output returns one widget which is expected, but when testing glowing_overscroll_indicator.1.dart the output returns two widgets which is a bit confusing to me. In the second case, the widget tree structure is:

- GlowingOverscrollIdicatorExampleApp
  - MaterialApp
    - Scaffold
      - GlowingOverscrollIdicatorExample
        - NestedScrollView
          - GlowingOverscrollIdicator
            - SliverAppBar
              - Text
            - CustomScrollView
              - GlowingOverscrollIdicator
                - ...
                  - ...

First I thought it was a result of using NestedScrollView, but I guess it's not.

Dragging and calculating the position

I tried to test both examples using await tester.drag() and tester.getBottomLeft(goiFinder).dy to check behaviors and calculate positions, but in both cases (glowing_overscroll_indicator.0.dart and glowing_overscroll_indicator.1.dart) I got inconsistent and incomprehensible results.

So, I hope that the visibility tests will be sufficient.

in both cases (glowing_overscroll_indicator.0.dart and glowing_overscroll_indicator.1.dart) I got inconsistent and incomprehensible results.

After looking it over again, I think that was my fault 😅
I copy-pasted the glowing_overscroll_indicator.0.dart changes into glowing_overscroll_indicator.1.dart, not realizing that it was adding an extra AppBar that shouldn't have been there.

I'll go ahead and push the fix (and restore the tests you added previously); if everything passes then I think we'll be good to merge!

Hi guys. Should we do something more with this PR?

Generally we give code reviewers 2 weeks before pinging them, since they often have busy lives with many responsibilities. 🙂

(more info here)

auto label is removed for flutter/flutter/155203, due to - The status or check suite Windows tool_integration_tests_2_9 has failed. Please fix the issues identified (or deflake) before re-applying this label.