Allow customizing entry mode icons in TimePicker by syedaniq · Pull Request #157151 · flutter/flutter

syedaniq · 2024-10-18T08:03:00Z

This PR adds two new properties to the Material Design TimePicker: switchToInputEntryModeIcon and switchToTimerEntryModeIcon. These allow developers to customize the icons for toggling between dial and input modes, with default icons (Icons.keyboard_outlined and Icons.access_time) used if none are provided.

Fixes #156942

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

packages/flutter/lib/src/material/time_picker.dart

packages/flutter/test/material/time_picker_test.dart

navaronbracke

This looks good to me. The failing CI task seems unrelated to your PR, though.

Seems like it is also failing for other PR's.

syedaniq · 2024-10-19T17:38:01Z

Thanks for your time and the helpful suggestions @navaronbracke, really appreciate it.
The checks were all sucessfull this time 🥳

…m/syedaniq/flutter into fix156942-timepicker-custom-icons

nate-thegrate

LGTM

Thanks for the contribution!

nate-thegrate · 2024-10-23T21:10:26Z

packages/flutter/lib/src/material/time_picker.dart

+  /// {@macro flutter.material.time_picker.switchToInputEntryModeIcon}
+  final Icon switchToInputEntryModeIcon;
+
+  /// {@macro flutter.material.time_picker.switchToTimerEntryModeIcon}
+  final Icon switchToTimerEntryModeIcon;


I was going to leave a suggestion here, but since this is set up to mirror the date picker, it's probably best to leave as-is for consistency.

packages/flutter/lib/src/material/time_picker.dart

TahaTesser

Almost there!

packages/flutter/test/material/time_picker_test.dart

Co-authored-by: Taha Tesser <[email protected]>

TahaTesser

LGTM

…tter#157151)

flutter/flutter@3fb95c7...42132e8 2024-10-29 [email protected] Reland "Upgrade tests to AGP 8.7/Gradle 8.10.2/Kotlin 1.8.10" (flutter/flutter#157617) 2024-10-29 [email protected] [impeller] re-enable impeller shard. (flutter/flutter#157806) 2024-10-29 [email protected] Roll Flutter Engine from 4cb4478016b5 to 725c8e4bc379 (1 revision) (flutter/flutter#157808) 2024-10-29 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Avoid labeling 'context' PRs as 'text-input' (#157650)" (flutter/flutter#157812) 2024-10-29 [email protected] Roll Flutter Engine from b95da8106b98 to 4cb4478016b5 (1 revision) (flutter/flutter#157792) 2024-10-29 [email protected] Remove unused import from kt plugin template (flutter/flutter#157220) 2024-10-29 [email protected] Roll Flutter Engine from 5fa7a123b14a to b95da8106b98 (1 revision) (flutter/flutter#157787) 2024-10-29 [email protected] Fix `TabBar` tab icons not respecting custom `IconTheme` (flutter/flutter#157724) 2024-10-29 [email protected] Roll Flutter Engine from 0c8f0bf4d740 to 5fa7a123b14a (1 revision) (flutter/flutter#157780) 2024-10-29 [email protected] Allow customizing entry mode icons in TimePicker (flutter/flutter#157151) 2024-10-29 [email protected] Add test for `focus_scope.0.dart` (flutter/flutter#157772) 2024-10-29 [email protected] Add test for `page_storage.0.dart` (flutter/flutter#157770) 2024-10-29 [email protected] Roll Flutter Engine from c05af6f939fc to 0c8f0bf4d740 (1 revision) (flutter/flutter#157774) 2024-10-29 [email protected] Roll Flutter Engine from b394e0c98fa0 to c05af6f939fc (1 revision) (flutter/flutter#157767) 2024-10-29 [email protected] Add test for `nested_scroll_view_state.0.dart` (flutter/flutter#157714) 2024-10-29 [email protected] Pin Mac tool_integration_test shards to arm64 (flutter/flutter#157760) 2024-10-29 [email protected] Roll Flutter Engine from ed587dcf61fd to b394e0c98fa0 (4 revisions) (flutter/flutter#157766) 2024-10-28 [email protected] Roll Flutter Engine from 70671baabbba to ed587dcf61fd (10 revisions) (flutter/flutter#157751) 2024-10-28 [email protected] Roll Flutter Engine from 23b2c6d3b3b1 to 70671baabbba (1 revision) (flutter/flutter#157740) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

MichalNemec · 2024-12-18T19:10:35Z

when this will get on stable? waiting for it since 3.19.5 (March 28, 2024)

nate-thegrate · 2024-12-18T20:14:23Z

It looks like the issue was filed on October 16 and then this contribution was merged on October 29.
The current stable branch contains all contributions prior to October 9, so this change missed the cutoff by a few weeks.

Feel free to check out https://docs.flutter.dev/release/archive to get an idea of how often stable releases generally take place. The next one will likely be in about 3 months from now.

…tter#157151)

Allow customizing entry mode icons in TimePicker

7316c4f

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Oct 18, 2024

syedaniq mentioned this pull request Oct 18, 2024

TimePicker: Allow customizing entry mode icons #156942

Closed

Use const constructors for icons

5a09275

navaronbracke reviewed Oct 18, 2024

View reviewed changes

syedaniq added 4 commits October 19, 2024 10:12

Add default icons for TimePicker mode switching

0e02efb

Reformatted the test to fix indentation

06086e3

Reformatted ternary operator because indentation

d94ac38

Update docs following the suggestions

4e52838

syedaniq requested a review from navaronbracke October 19, 2024 09:21

navaronbracke reviewed Oct 19, 2024

View reviewed changes

Merge branch 'master' into fix156942-timepicker-custom-icons

28e7a6b

syedaniq requested a review from navaronbracke October 19, 2024 17:44

syedaniq added 6 commits October 21, 2024 16:30

Allow customizing entry mode icons in TimePicker

be2fe54

Use const constructors for icons

5be22ee

Add default icons for TimePicker mode switching

6d10f4f

Reformatted the test to fix indentation

2ab6b6a

Reformatted ternary operator because indentation

133f52b

Update docs following the suggestions

8015fa2

syedaniq force-pushed the fix156942-timepicker-custom-icons branch from 28e7a6b to 8015fa2 Compare October 21, 2024 14:31

syedaniq and others added 2 commits October 21, 2024 17:52

Merge branch 'master' into fix156942-timepicker-custom-icons

598ec67

Merge branch 'fix156942-timepicker-custom-icons' of https://github.co…

696e133

…m/syedaniq/flutter into fix156942-timepicker-custom-icons

Piinks requested review from nate-thegrate and removed request for navaronbracke October 23, 2024 18:12

nate-thegrate approved these changes Oct 23, 2024

View reviewed changes

Merge branch 'master' into fix156942-timepicker-custom-icons

efcc568

TahaTesser suggested changes Oct 26, 2024

View reviewed changes

packages/flutter/lib/src/material/time_picker.dart Outdated Show resolved Hide resolved

Make icons nullable as in DatePicker

946e187

syedaniq requested a review from TahaTesser October 28, 2024 16:20

TahaTesser suggested changes Oct 29, 2024

View reviewed changes

Apply suggested reformatting to the test

5199901

Co-authored-by: Taha Tesser <[email protected]>

github-actions bot added the a: text input Entering text in a text field or keyboard related problems label Oct 29, 2024

TahaTesser removed the a: text input Entering text in a text field or keyboard related problems label Oct 29, 2024

TahaTesser approved these changes Oct 29, 2024

View reviewed changes

TahaTesser added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 29, 2024

auto-submit bot merged commit c83cf96 into flutter:master Oct 29, 2024

engine-flutter-autoroll mentioned this pull request Oct 29, 2024

Roll Flutter from 3fb95c7dd21d to f935e5358714 (13 revisions) flutter/packages#7952

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 29, 2024

c83cf96 Allow customizing entry mode icons in TimePicker (flutter/flu…

0ddc7a3

…tter#157151)

engine-flutter-autoroll mentioned this pull request Oct 29, 2024

Roll Flutter from 3fb95c7dd21d to ebc80f01645d (15 revisions) flutter/packages#7954

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 29, 2024

c83cf96 Allow customizing entry mode icons in TimePicker (flutter/flu…

b8f8df8

…tter#157151)

engine-flutter-autoroll mentioned this pull request Oct 29, 2024

Roll Flutter from 3fb95c7dd21d to 64e0f6a57bc3 (16 revisions) flutter/packages#7957

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 29, 2024

c83cf96 Allow customizing entry mode icons in TimePicker (flutter/flu…

e0f5018

…tter#157151)

engine-flutter-autoroll mentioned this pull request Oct 29, 2024

Roll Flutter from 3fb95c7dd21d to 42132e879b42 (19 revisions) flutter/packages#7958

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 29, 2024

c83cf96 Allow customizing entry mode icons in TimePicker (flutter/flu…

d5db85f

…tter#157151)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

c83cf96 Allow customizing entry mode icons in TimePicker (flutter/flu…

13da5e4

…tter#157151)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

c83cf96 Allow customizing entry mode icons in TimePicker (flutter/flu…

8ebd1ad

…tter#157151)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

c83cf96 Allow customizing entry mode icons in TimePicker (flutter/flu…

261a598

…tter#157151)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

c83cf96 Allow customizing entry mode icons in TimePicker (flutter/flu…

2e72733

…tter#157151)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

c83cf96 Allow customizing entry mode icons in TimePicker (flutter/flu…

56d7e49

…tter#157151)

Conversation

syedaniq commented Oct 18, 2024

Pre-launch Checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

navaronbracke left a comment

Choose a reason for hiding this comment

Uh oh!

syedaniq commented Oct 19, 2024

Uh oh!

nate-thegrate left a comment

Choose a reason for hiding this comment

Uh oh!

nate-thegrate Oct 23, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

TahaTesser left a comment

Choose a reason for hiding this comment

Uh oh!

MichalNemec commented Dec 18, 2024

Uh oh!

nate-thegrate commented Dec 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants