Upgrade templates to AGP 8.7/Gradle 8.10.2 by gmackall · Pull Request #157872 · flutter/flutter

gmackall · 2024-10-30T17:28:19Z

These are the versions we use in test, as of #157617.

Motivated by noticing a warning with the old template version:

This Android Gradle plugin (8.1.0) was tested up to compileSdk = 33 (and compileSdkPreview = "UpsideDownCakePrivacySandbox").
You are strongly encouraged to update your project to use a newer
Android Gradle plugin that has been tested with compileSdk = 35.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

reidbaker · 2024-10-30T18:33:22Z

packages/flutter_tools/test/general.shard/android/gradle_errors_test.dart

          "│     + classpath 'com.android.tools.build:gradle:$templateAndroidGradlePluginVersion'                           │\n"
          '│ /android/gradle/wrapper/gradle-wrapper.properties:                               │\n'
          '│     - https://services.gradle.org/distributions/gradle-<current-version>-all.zip │\n'
-          '│     + https://services.gradle.org/distributions/gradle-$templateDefaultGradleVersion-all.zip               │\n'


Did you mean to remove this space?

Yes, the old Gradle version was shorter, so the message structure is changed slightly by a couple of spaces (which is to say, it is a bit of a change detector test)

I dislike when we detect character output in tests like this but it is out of scope for this pr.

Yeah, I feel similarly and had sort of hoped I had fixed this in a previous PR by making the test a function of the value itself, i.e.

https://services.gradle.org/distributions/gradle-$templateDefaultGradleVersion-all.zip

instead of what it was before iirc, a hardcoded

https://services.gradle.org/distributions/gradle-8.3-all.zip

that will always need to be updated

But I forgot to consider that the test will fail when the length of templateDefaultGradleVersion changes because it consumes space that would otherwise be spaces 😢

…57872)

Manual roll requested by [email protected] flutter/flutter@fe71cad...0fe6153 2024-10-31 [email protected] Roll Flutter Engine from c40b0b602822 to f2154ef3e31c (8 revisions) (flutter/flutter#157926) 2024-10-31 [email protected] Hides added routes before top-most route finishes pushing (flutter/flutter#156104) 2024-10-31 [email protected] Fix cursor on hover expand/collapse icon (#155207) (flutter/flutter#155209) 2024-10-31 [email protected] Add test for `media_query_data.system_gesture_insets.0.dart` (flutter/flutter#157854) 2024-10-31 [email protected] Add and plumb `useImplicitPubspecResolution` across `flutter_tools`. (flutter/flutter#157879) 2024-10-31 [email protected] Roll Flutter Engine from 090c33aeae83 to c40b0b602822 (1 revision) (flutter/flutter#157896) 2024-10-31 [email protected] Roll Flutter Engine from 9295eeb6d3ce to 090c33aeae83 (4 revisions) (flutter/flutter#157893) 2024-10-30 [email protected] Roll Flutter Engine from 2bd854e23b61 to 9295eeb6d3ce (5 revisions) (flutter/flutter#157882) 2024-10-30 [email protected] Adds a new helpful tool exit message for SocketExceptions thrown during mdns discovery (flutter/flutter#157638) 2024-10-30 [email protected] Fix `GlowingOverscrollIndicator` examples (flutter/flutter#155203) 2024-10-30 [email protected] Roll Flutter Engine from 906a7ad88052 to 2bd854e23b61 (1 revision) (flutter/flutter#157878) 2024-10-30 [email protected] Upgrade templates to AGP 8.7/Gradle 8.10.2 (flutter/flutter#157872) 2024-10-30 [email protected] Roll Flutter Engine from 57ed5d338e7e to 906a7ad88052 (13 revisions) (flutter/flutter#157875) 2024-10-30 [email protected] Update Material 3 `LinearProgressIndicator` for new visual style (flutter/flutter#154817) 2024-10-30 [email protected] Roll Flutter Engine from 999797a2f690 to 57ed5d338e7e (5 revisions) (flutter/flutter#157833) 2024-10-30 [email protected] Add hidden `--no-implicit-pubspec-resolution` flag for one stable release. (flutter/flutter#157635) 2024-10-30 [email protected] Roll Packages from 028027e to 7cc1caa (5 revisions) (flutter/flutter#157864) 2024-10-30 [email protected] Mention partial PRs in the contributing docs (flutter/flutter#157863) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…57872)

Gray Mackall added 2 commits October 30, 2024 10:27

lets see what breaks, I always forget

f408607

patch version

b40a4a5

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 30, 2024

Gray Mackall added 2 commits October 30, 2024 10:35

undo patch version

abffde7

fix gradle_errors_test.dart

f9bba22

gmackall marked this pull request as ready for review October 30, 2024 18:27

gmackall requested a review from a team October 30, 2024 18:27

reidbaker reviewed Oct 30, 2024

View reviewed changes

reidbaker approved these changes Oct 30, 2024

View reviewed changes

gmackall changed the title ~~[wip] Upgrade templates to AGP 8.7/Gradle 8.10.2~~ Upgrade templates to AGP 8.7/Gradle 8.10.2 Oct 30, 2024

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 30, 2024

auto-submit bot merged commit 55c026a into flutter:master Oct 30, 2024

engine-flutter-autoroll mentioned this pull request Oct 31, 2024

Roll Flutter from fe71cadf1959 to 16622e67a051 (15 revisions) flutter/packages#7971

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 31, 2024

55c026a Upgrade templates to AGP 8.7/Gradle 8.10.2 (flutter/flutter#1…

c1e8d29

…57872)

engine-flutter-autoroll mentioned this pull request Oct 31, 2024

Roll Flutter from fe71cadf1959 to b01558c1cd70 (16 revisions) flutter/packages#7972

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 31, 2024

55c026a Upgrade templates to AGP 8.7/Gradle 8.10.2 (flutter/flutter#1…

7b2a238

…57872)

engine-flutter-autoroll mentioned this pull request Oct 31, 2024

Roll Flutter from fe71cadf1959 to 0fe615343bd9 (18 revisions) flutter/packages#7973

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 31, 2024

55c026a Upgrade templates to AGP 8.7/Gradle 8.10.2 (flutter/flutter#1…

ef31caa

…57872)

engine-flutter-autoroll mentioned this pull request Oct 31, 2024

Manual roll Flutter from fe71cadf1959 to 0fe615343bd9 (18 revisions) flutter/packages#7989

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Oct 31, 2024

55c026a Upgrade templates to AGP 8.7/Gradle 8.10.2 (flutter/flutter#1…

6266e50

…57872)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

55c026a Upgrade templates to AGP 8.7/Gradle 8.10.2 (flutter/flutter#1…

d4363bb

…57872)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

55c026a Upgrade templates to AGP 8.7/Gradle 8.10.2 (flutter/flutter#1…

8d46f93

…57872)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

55c026a Upgrade templates to AGP 8.7/Gradle 8.10.2 (flutter/flutter#1…

a5b7b81

…57872)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

55c026a Upgrade templates to AGP 8.7/Gradle 8.10.2 (flutter/flutter#1…

2bcb0e9

…57872)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

55c026a Upgrade templates to AGP 8.7/Gradle 8.10.2 (flutter/flutter#1…

9e50b68

…57872)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade templates to AGP 8.7/Gradle 8.10.2#157872

Upgrade templates to AGP 8.7/Gradle 8.10.2#157872
auto-submit[bot] merged 4 commits intoflutter:masterfrom
gmackall:tmpl_agp_87

gmackall commented Oct 30, 2024 •

edited

Loading

Uh oh!

reidbaker Oct 30, 2024

Uh oh!

gmackall Oct 30, 2024

Uh oh!

reidbaker Oct 30, 2024

Uh oh!

gmackall Oct 30, 2024 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gmackall commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

reidbaker Oct 30, 2024

Choose a reason for hiding this comment

Uh oh!

gmackall Oct 30, 2024

Choose a reason for hiding this comment

Uh oh!

reidbaker Oct 30, 2024

Choose a reason for hiding this comment

Uh oh!

gmackall Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gmackall commented Oct 30, 2024 •

edited

Loading

gmackall Oct 30, 2024 •

edited

Loading