Implicitly @protected Navigator#157874
Closed
nate-thegrate wants to merge 2 commits intoflutter:masterfrom
Closed
Conversation
github-actions
bot
added
framework
nate-thegrate
added
the
refactor
justinmc
reviewed
Nov 1, 2024
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
This implies that we should probably do a similar thing for all public State instances in the framework, and because that would be such a big departure from the spirit of the styleguide's advice on extension, I think we should go with the explicit @protected solution #157313 instead.
Contributor
Author
|
Closing this one in favor of #157313. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request allows
NavigatorStatemethods to benefit from@protected, without needing to add@protectedanywhere!mini-design doc: flutter.dev/go/implicitly-protected
Before
After
(the result after this PR and #157873 are merged)
This is possible thanks to Dart's extension types feature.
NavigatorState(originally spanning over 2,000 lines of code) has been split into an "internal" and "external" type.The extension type wrapper exposes
State<Navigator>instead of the concrete implementation. Static analysis is now performed against the baseStateclass, so whether the overridden methods are@protecteddoesn't matter!