[flutter_driver] use mostly public screenshot API. by jonahwilliams · Pull Request #157888 · flutter/flutter

jonahwilliams · 2024-10-30T23:01:57Z

Instead of completely private. This has been broken for Impeller for years, which shows how much this method is getting used.

Fixes #130461

zanderso · 2024-10-30T23:37:43Z

Nice. Is it possible to test this on CI?

zanderso · 2024-10-31T15:15:07Z

packages/flutter_driver/test_driver/screenshot_test.dart

+
+    // Check PNG header.
+    expect(bytes.sublist(0, 8), <int>[137, 80, 78, 71, 13, 10, 26, 10]);
+  });


Does this also need Timeout.none?

I'm currently investigating this, but it looks like none of these driver tests are running anywhere.

zanderso · 2024-10-31T15:15:39Z

dev/integration_tests/ui/test_driver/solid_color_test.dart

+    final Uint8List data = (await driver.screenshot(format: ScreenshotFormat.rawStraightRgba)) as Uint8List;
+
+    expect(data[0] << 24 | data[1] << 16 | data[2] << 8 | data[3], 0xFF0000FF);
+  }, timeout: Timeout.none);


A comment about why Timeout.none is needed here will probably be helpful to future readers.

Its only needed to satisfy a lint check :)

matanlurey · 2024-10-31T16:39:52Z

packages/flutter_driver/lib/src/driver/web_driver.dart

  @override
-  Future<List<int>> screenshot() async {
+  Future<List<int>> screenshot({ScreenshotFormat format = ScreenshotFormat.png}) async {
+    assert(format == ScreenshotFormat.png, 'Web Driver only supports PNG screenshot format');


I would make this an ArgumentError (yeah all tests use assertions but driver can be used outside of tests).

matanlurey · 2024-10-31T19:37:44Z

packages/flutter_driver/lib/src/driver/web_driver.dart

  Future<List<int>> screenshot({ScreenshotFormat format = ScreenshotFormat.png}) async {
-    assert(format == ScreenshotFormat.png, 'Web Driver only supports PNG screenshot format');
+    if (format != ScreenshotFormat.png) {
+      throw ArgumentError('Web Driver only supports PNG screenshot format');


Use ArgumentError.value so the user sees what format was providwed.

auto-submit · 2024-10-31T20:14:08Z

auto label is removed for flutter/flutter/157888, due to - The status or check suite Mac_x64 plugin_lint_mac has failed. Please fix the issues identified (or deflake) before re-applying this label.

Fixes flutter/flutter#143387 Will be tested in flutter/flutter#157888

…lutter#157888)

flutter/flutter@0fe6153...f86b777 2024-11-01 [email protected] Roll Packages from 7cc1caa to 796afa3 (15 revisions) (flutter/flutter#158003) 2024-11-01 [email protected] Marks Linux_pixel_7pro service_extensions_test to be flaky (flutter/flutter#157853) 2024-11-01 [email protected] Roll Flutter Engine from 0a0d5c9be6ff to 3a090b46dd35 (1 revision) (flutter/flutter#157994) 2024-11-01 [email protected] Roll Flutter Engine from bacc5e1e73b7 to 0a0d5c9be6ff (3 revisions) (flutter/flutter#157991) 2024-11-01 [email protected] Add test for `interactive_viewer.transformation_controller.0.dart` (flutter/flutter#157986) 2024-11-01 [email protected] Roll Flutter Engine from d7e928911ac2 to bacc5e1e73b7 (1 revision) (flutter/flutter#157982) 2024-11-01 [email protected] Add test for `notification.0.dart` (flutter/flutter#157909) 2024-11-01 [email protected] performance: Override .elementAt in CachingIterable (flutter/flutter#152477) 2024-11-01 [email protected] Roll Flutter Engine from cd46383cd55e to d7e928911ac2 (4 revisions) (flutter/flutter#157978) 2024-11-01 [email protected] Roll Flutter Engine from bb77cf867aef to cd46383cd55e (11 revisions) (flutter/flutter#157972) 2024-11-01 [email protected] Add a warning/additional handlers for parsing`synthetic-package`. (flutter/flutter#157934) 2024-10-31 [email protected] Roll Flutter Engine from f2154ef3e31c to bb77cf867aef (6 revisions) (flutter/flutter#157960) 2024-10-31 [email protected] Renames `injectBuildTimePluginFilesForWebPlatform` and removes unused named parameter. (flutter/flutter#157944) 2024-10-31 [email protected] [flutter_driver] use mostly public screenshot API. (flutter/flutter#157888) 2024-10-31 [email protected] Made insetPadding configurable for Date Picker Dialog (flutter/flutter#155651) 2024-10-31 [email protected] Fix showSnackBar can't access useMaterial3 from the theme (flutter/flutter#157707) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Fixes flutter#143387 Will be tested in flutter#157888

…lutter#157888)

Add public screenshot APi to flutter driver.

4c22695

github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Oct 30, 2024

++

85cf147

jonahwilliams added 7 commits October 30, 2024 17:07

++

c3ba907

remove unused import.

17be76e

integration testing....

55c0254

remove usage of package image, allow configuring format.

3863a7d

++

12f777e

analysis fixes.

a561470

Remove timeout.

213d216

zanderso reviewed Oct 31, 2024

View reviewed changes

add linux shard.

ff8f42d

jonahwilliams marked this pull request as ready for review October 31, 2024 16:32

jonahwilliams requested a review from matanlurey as a code owner October 31, 2024 16:32

matanlurey approved these changes Oct 31, 2024

View reviewed changes

jonahwilliams mentioned this pull request Oct 31, 2024

[Impeller] make desktop GL render. flutter/engine#56274

Merged

use argument error.

12c2904

matanlurey approved these changes Oct 31, 2024

View reviewed changes

++

391b51d

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2024

jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2024

auto-submit bot merged commit 1050959 into flutter:master Oct 31, 2024

jonahwilliams deleted the use_public_api branch October 31, 2024 21:32

auto-submit bot pushed a commit to flutter/engine that referenced this pull request Oct 31, 2024

[Impeller] make desktop GL render. (#56274)

ab00d95

Fixes flutter/flutter#143387 Will be tested in flutter/flutter#157888

engine-flutter-autoroll mentioned this pull request Nov 1, 2024

Roll Flutter from 0fe615343bd9 to 2da2332ad1be (14 revisions) flutter/packages#7996

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 1, 2024

1050959 [flutter_driver] use mostly public screenshot API. (flutter/f…

de046b5

…lutter#157888)

engine-flutter-autoroll mentioned this pull request Nov 1, 2024

Roll Flutter from 0fe615343bd9 to f15913654977 (15 revisions) flutter/packages#7999

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 1, 2024

1050959 [flutter_driver] use mostly public screenshot API. (flutter/f…

1b8a6e4

…lutter#157888)

engine-flutter-autoroll mentioned this pull request Nov 1, 2024

Roll Flutter from 0fe615343bd9 to f86b77721524 (16 revisions) flutter/packages#8000

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 1, 2024

1050959 [flutter_driver] use mostly public screenshot API. (flutter/f…

7a64bc2

…lutter#157888)

nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024

[Impeller] make desktop GL render. (flutter/engine#56274)

14df054

Fixes flutter#143387 Will be tested in flutter#157888

reidbaker mentioned this pull request Feb 3, 2025

Display rotation test is not being run in ci #162615

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

1050959 [flutter_driver] use mostly public screenshot API. (flutter/f…

58ec051

…lutter#157888)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

1050959 [flutter_driver] use mostly public screenshot API. (flutter/f…

eaac37b

…lutter#157888)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

1050959 [flutter_driver] use mostly public screenshot API. (flutter/f…

32f6000

…lutter#157888)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

1050959 [flutter_driver] use mostly public screenshot API. (flutter/f…

2ae1c54

…lutter#157888)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

1050959 [flutter_driver] use mostly public screenshot API. (flutter/f…

a498733

…lutter#157888)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[flutter_driver] use mostly public screenshot API.#157888

[flutter_driver] use mostly public screenshot API.#157888
auto-submit[bot] merged 12 commits intoflutter:masterfrom
jonahwilliams:use_public_api

jonahwilliams commented Oct 30, 2024 •

edited

Loading

Uh oh!

zanderso commented Oct 30, 2024

Uh oh!

zanderso Oct 31, 2024

Uh oh!

jonahwilliams Oct 31, 2024

Uh oh!

zanderso Oct 31, 2024

Uh oh!

jonahwilliams Oct 31, 2024

Uh oh!

matanlurey Oct 31, 2024

Uh oh!

matanlurey Oct 31, 2024

Uh oh!

jonahwilliams Oct 31, 2024

Uh oh!

auto-submit bot commented Oct 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

jonahwilliams commented Oct 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zanderso commented Oct 30, 2024

Uh oh!

zanderso Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

zanderso Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

matanlurey Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

matanlurey Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

jonahwilliams Oct 31, 2024

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Oct 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jonahwilliams commented Oct 30, 2024 •

edited

Loading