Skip to content

add test for raw_scrollbar_desktop api example#158101

Closed
IldySilva wants to merge 4 commits intoflutter:masterfrom
IldySilva:add-missings-tests-for-apis-examples
Closed

add test for raw_scrollbar_desktop api example#158101
IldySilva wants to merge 4 commits intoflutter:masterfrom
IldySilva:add-missings-tests-for-apis-examples

Conversation

@IldySilva
Copy link
Contributor

@IldySilva IldySilva commented Nov 4, 2024 •
edited
Loading

Contributes to #130459

It adds a test for

examples/api/lib/widgets/scrollbar/raw_scrollbar.desktop.0.dart

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Nov 4, 2024
@chunhtai chunhtai requested a review from Piinks November 5, 2024 23:07
@chunhtai
Copy link
Contributor

chunhtai commented Nov 5, 2024

Hi @Piinks can you take a look at this pr? feel free to reassign.

@ValentinVignal ValentinVignal mentioned this pull request Nov 6, 2024
Merged
@bleroux
Copy link
Contributor

bleroux commented Nov 6, 2024

@IldySilva Thanks for the contribution 🙏

In #158237, I did some clean up and activated the existing test which was misnamed.
The existing test file was named "examples/api/test/widgets/scrollbar/raw_scrollbar.desktop.0.dart" without the _test suffix.

The existing test was somewhat succinct and might be improved. So feel free to continue with this PR.
The main purpose for this particular example is to showcase a behavior specific to desktop so this should be reflected in the test (for the moment I see that your test does not run on Desktop so it can not check the expected behavior).

@IldySilva
Copy link
Contributor Author

IldySilva commented Nov 6, 2024

@bleroux, understood ,i think this can be closed , since #158237 is taking care of

@IldySilva IldySilva closed this Nov 6, 2024
@IldySilva IldySilva deleted the add-missings-tests-for-apis-examples branch November 6, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Piinks Piinks Awaiting requested review from Piinks

Assignees

No one assigned

Labels

d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@IldySilva @chunhtai @bleroux