Add test for `dynamic_content_color.0.dart` by ValentinVignal · Pull Request #158309 · flutter/flutter

ValentinVignal · 2024-11-07T07:20:12Z

Fixes #130459

It adds a test for

examples/api/lib/material/color_scheme/dynamic_content_color.0.dart

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

bleroux

Congratulations for finishing this missing example tests task 🙏

bleroux · 2024-11-12T07:28:03Z

examples/api/test/material/color_scheme/dynamic_content_color.0_test.dart

+        expect(find.byType(Switch), findsOne);
+        expect(find.byIcon(Icons.light_mode), findsOne);
+
+        // Loads the images.


Suggested change

// Loads the images.

// Loads the images.

// Using runAsync forces the streams to complete. This is needed because loading the fake image

// is a real async task.

Here is a proposed comment to give a clue about why the runAsync are needed.

Nice, I've updated it in format: Add better comment for the runAsyncs and better formatting 😊

bleroux · 2024-11-12T07:28:15Z

examples/api/test/material/color_scheme/dynamic_content_color.0_test.dart

+  StreamSubscription<List<int>> listen(void Function(List<int> event)? onData,
+      {Function? onError, void Function()? onDone, bool? cancelOnError}) {
+          return Stream<List<int>>.value(_blueSquarePng).listen(
+            onData,
+            onDone: onDone,
+            onError: onError,
+            cancelOnError: cancelOnError,
+          );
+
+  }


Suggested change

StreamSubscription<List<int>> listen(void Function(List<int> event)? onData,

{Function? onError, void Function()? onDone, bool? cancelOnError}) {

return Stream<List<int>>.value(_blueSquarePng).listen(

onData,

onDone: onDone,

onError: onError,

cancelOnError: cancelOnError,

);

}

StreamSubscription<List<int>> listen(

void Function(List<int> event)? onData, {

Function? onError,

void Function()? onDone,

bool? cancelOnError,

}) {

return Stream<List<int>>.value(_blueSquarePng).listen(

onData,

onDone: onDone,

onError: onError,

cancelOnError: cancelOnError,

);

}

That's way better, I changed it in format: Add better comment for the runAsyncs and better formatting

…158309)

TahaTesser · 2024-11-12T15:54:12Z

@bleroux @ValentinVignal
This is breaking the tree
https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8731474074401633873/+/u/run_test.dart_for_framework_tests_shard_and_subshard_misc/stdout

TahaTesser · 2024-11-12T15:54:57Z

This is the error thrown

04:38 +712 ~2: /b/s/w/ir/x/w/flutter/examples/api/test/material/color_scheme/dynamic_content_color.0_test.dart: The theme colors are created dynamically from the first image
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following TestFailure was thrown running a test:
Expected: exactly 6 matching candidates
  Actual: _TypeWidgetFinder:<Found 0 widgets with type "Image": []>
   Which: means none were found but some were expected

bleroux · 2024-11-12T16:01:19Z

Reverting while we will try to figure out a fix.

auto-submit · 2024-11-12T16:02:10Z

A reason for requesting a revert of flutter/flutter/158309 could
not be found or the reason was not properly formatted. Begin a comment with 'Reason for revert:' to tell the bot why
this issue is being reverted.

bleroux · 2024-11-12T16:03:05Z

Reason for revert: added test is failing on CI

This reverts commit 95a9b97.

) Reverts: #158309 Initiated by: bleroux Reason for reverting: added test is failing on CI Original PR Author: ValentinVignal Reviewed By: {bleroux} This change reverts the following previous change: Fixes #130459 It adds a test for - `examples/api/lib/material/color_scheme/dynamic_content_color.0.dart`

…158309)

Roll Flutter from c8510f2 to ed553d1 (48 revisions) flutter/flutter@c8510f2...ed553d1 2024-11-13 [email protected] Avoid using platform `ProcessInfo.maxRss` in test. (flutter/flutter#158526) 2024-11-13 [email protected] Roll Packages from 72356fd to 26e123a (19 revisions) (flutter/flutter#158626) 2024-11-13 [email protected] Move `dart pub deps` call to `<Pub>.deps` and use it accordingly (flutter/flutter#158524) 2024-11-13 [email protected] Roll Flutter Engine from 05c14d8b4cd7 to db3e5af2ca22 (1 revision) (flutter/flutter#158553) 2024-11-13 [email protected] Roll Flutter Engine from ef760d6e1f13 to 05c14d8b4cd7 (3 revisions) (flutter/flutter#158551) 2024-11-13 [email protected] Roll Flutter Engine from 08348c9eebcc to ef760d6e1f13 (1 revision) (flutter/flutter#158545) 2024-11-13 [email protected] Marks Mac_arm64_ios hot_mode_dev_cycle_ios__benchmark to be flaky (flutter/flutter#158242) 2024-11-13 [email protected] Roll Flutter Engine from 877abb9ad6ff to 08348c9eebcc (8 revisions) (flutter/flutter#158541) 2024-11-13 [email protected] Allow `devDependencies` to be omitted and not cause a tool crash. (flutter/flutter#158518) 2024-11-13 [email protected] Explain how to use `flutter channel`. (flutter/flutter#158533) 2024-11-13 [email protected] Clean up dependabot config, add github-action group (flutter/flutter#158408) 2024-11-12 [email protected] Update test to include more complete instructions for how to run tests locally, add example to andoid 11 tests as well (flutter/flutter#158528) 2024-11-12 [email protected] force Linux plugin_test to run on Ubuntu 20.04 (flutter/flutter#158529) 2024-11-12 [email protected] Support materialTapTargetSize in PopupMenuButton (flutter/flutter#158357) 2024-11-12 [email protected] [SwiftPM] Update .flutter-plugin-dependencies format (flutter/flutter#158138) 2024-11-12 [email protected] add filesystem error handling to `systemTempDirectory` (flutter/flutter#158481) 2024-11-12 [email protected] Made Cupertino dialog more like a native dialog in dark mode (flutter/flutter#157218) 2024-11-12 [email protected] Roll Flutter Engine from b0a4ca92c49e to 877abb9ad6ff (2 revisions) (flutter/flutter#158506) 2024-11-12 [email protected] Fix `NavigationBar` label style customization on the widget level (flutter/flutter#158510) 2024-11-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add test for `dynamic_content_color.0.dart` (#158309)" (flutter/flutter#158511) 2024-11-12 [email protected] Add test for `dynamic_content_color.0.dart` (flutter/flutter#158309) 2024-11-12 [email protected] Roll Flutter Engine from a672f971c659 to b0a4ca92c49e (2 revisions) (flutter/flutter#158488) 2024-11-12 [email protected] Roll Flutter Engine from 35041f118744 to a672f971c659 (1 revision) (flutter/flutter#158487) 2024-11-12 [email protected] Roll Flutter Engine from 7b3eacd20eb6 to 35041f118744 (9 revisions) (flutter/flutter#158485) 2024-11-11 [email protected] [SwiftPM] Simplify logic that determines if CocoaPods is used (flutter/flutter#158409) 2024-11-11 [email protected] Fix Chip draws `InkWell.hoverColor` is drawn on top of the provided background color with `hovered` state (flutter/flutter#158454) 2024-11-11 [email protected] Roll Flutter Engine from 3cb6f4de89b6 to 7b3eacd20eb6 (1 revision) (flutter/flutter#158464) 2024-11-11 [email protected] Roll Packages from bb5a258 to 72356fd (8 revisions) (flutter/flutter#158378) 2024-11-11 [email protected] Roll Flutter Engine from e9a44820f302 to 3cb6f4de89b6 (3 revisions) (flutter/flutter#158456) 2024-11-11 [email protected] Replace custom `RPCErrorCodes` with `RPCErrorKind` from `package:vm_service` (flutter/flutter#158379) 2024-11-11 [email protected] Roll Flutter Engine from d90e9f4718b8 to e9a44820f302 (1 revision) (flutter/flutter#158453) 2024-11-11 [email protected] Roll Flutter Engine from 01c76e42c20f to d90e9f4718b8 (1 revision) (flutter/flutter#158443) 2024-11-11 [email protected] Roll Flutter Engine from 9b4c3b3d5518 to 01c76e42c20f (3 revisions) (flutter/flutter#158438) 2024-11-11 [email protected] Remove block and line comments when detecting '.flutter-plugins' in settings.gradle(.kts) (flutter/flutter#155488) 2024-11-11 [email protected] Add `SafeArea` DartPad sample (flutter/flutter#158019) 2024-11-10 [email protected] Marks Linux analyzer_benchmark to be flaky (flutter/flutter#158244) 2024-11-10 [email protected] remove `bringup` status for recently re-subsharded targets (flutter/flutter#158217) 2024-11-09 [email protected] Roll Flutter Engine from 690cdfd09beb to 9b4c3b3d5518 (1 revision) (flutter/flutter#158418) 2024-11-09 [email protected] Marks Mac_benchmark complex_layout_scroll_perf_macos__timeline_summary to be flaky (flutter/flutter#158252) 2024-11-09 [email protected] Roll Flutter Engine from ca6f5110d9d3 to 690cdfd09beb (1 revision) (flutter/flutter#158414) 2024-11-09 [email protected] Roll Flutter Engine from 2f097cfd3d2d to ca6f5110d9d3 (3 revisions) (flutter/flutter#158411) 2024-11-09 [email protected] Roll Flutter Engine from 54df0b8a4784 to 2f097cfd3d2d (1 revision) (flutter/flutter#158407) 2024-11-08 [email protected] Roll Flutter Engine from b7134d373ef8 to 54df0b8a4784 (2 revisions) (flutter/flutter#158405) 2024-11-08 [email protected] Roll Flutter Engine from 6b77347edfc5 to b7134d373ef8 (3 revisions) (flutter/flutter#158402) 2024-11-08 [email protected] Roll Flutter Engine from 1b567e80386e to 6b77347edfc5 (4 revisions) (flutter/flutter#158398) 2024-11-08 [email protected] Roll Flutter Engine from a08bd5a07c2a to 1b567e80386e (1 revision) (flutter/flutter#158393) ...

Fixes #130459 Follow up of the reverted #158309 It adds a test for - `examples/api/lib/material/color_scheme/dynamic_content_color.0.dart`

…158309)

test: Add test for dynamic_content_color.0.dart

ffc4b93

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Nov 7, 2024

ValentinVignal requested a review from bleroux November 7, 2024 07:20

bleroux mentioned this pull request Nov 11, 2024

Test of DynamicColorExample (dynamic_content_color.0_test.dart) #158434

Closed

9 tasks

ValentinVignal marked this pull request as ready for review November 12, 2024 02:11

test: More complete test

ef04b57

ValentinVignal force-pushed the Add-test-for-dynamic-color-content branch from bdd14a2 to ef04b57 Compare November 12, 2024 02:12

bleroux approved these changes Nov 12, 2024

View reviewed changes

format: Add better comment for the runAsyncs and better formatting

90d2831

ValentinVignal added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 12, 2024

auto-submit bot merged commit 95a9b97 into flutter:master Nov 12, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Nov 12, 2024

engine-flutter-autoroll mentioned this pull request Nov 12, 2024

Roll Flutter from c8510f29ccc2 to 95a9b97f88a8 (28 revisions) flutter/packages#8060

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2024

95a9b97 Add test for dynamic_content_color.0.dart (flutter/flutter#…

46c369a

…158309)

bleroux added the revert Autorevert PR (with "Reason for revert:" comment) label Nov 12, 2024

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Nov 12, 2024

bleroux added the revert Autorevert PR (with "Reason for revert:" comment) label Nov 12, 2024

auto-submit bot pushed a commit that referenced this pull request Nov 12, 2024

Revert "Add test for dynamic_content_color.0.dart (#158309)"

67995af

This reverts commit 95a9b97.

auto-submit bot mentioned this pull request Nov 12, 2024

Reverts "Add test for dynamic_content_color.0.dart (#158309)" #158511

Merged

9 tasks

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Nov 12, 2024

engine-flutter-autoroll mentioned this pull request Nov 12, 2024

Roll Flutter from c8510f29ccc2 to 423aa2ac7476 (29 revisions) flutter/packages#8063

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2024

95a9b97 Add test for dynamic_content_color.0.dart (flutter/flutter#…

0adc021

…158309)

engine-flutter-autoroll mentioned this pull request Nov 12, 2024

Roll Flutter from c8510f29ccc2 to 19411b638b2e (31 revisions) flutter/packages#8064

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2024

95a9b97 Add test for dynamic_content_color.0.dart (flutter/flutter#…

0cc422d

…158309)

engine-flutter-autoroll mentioned this pull request Nov 12, 2024

Roll Flutter from c8510f29ccc2 to 9a2e249025ea (32 revisions) flutter/packages#8066

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2024

95a9b97 Add test for dynamic_content_color.0.dart (flutter/flutter#…

fc6fd8e

…158309)

engine-flutter-autoroll mentioned this pull request Nov 12, 2024

Roll Flutter from c8510f29ccc2 to 37d80ce25f68 (33 revisions) flutter/packages#8067

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 12, 2024

95a9b97 Add test for dynamic_content_color.0.dart (flutter/flutter#…

d7e1daa

…158309)

ValentinVignal mentioned this pull request Nov 13, 2024

Reland Add test for dynamic_content_color.0.dart #158547

Merged

9 tasks

engine-flutter-autoroll mentioned this pull request Nov 13, 2024

Roll Flutter from c8510f29ccc2 to 4de32b870212 (45 revisions) flutter/packages#8073

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2024

95a9b97 Add test for dynamic_content_color.0.dart (flutter/flutter#…

e33ddb0

…158309)

engine-flutter-autoroll mentioned this pull request Nov 13, 2024

Roll Flutter from c8510f29ccc2 to 4de32b870212 (45 revisions) flutter/packages#8075

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2024

95a9b97 Add test for dynamic_content_color.0.dart (flutter/flutter#…

8d2d818

…158309)

engine-flutter-autoroll mentioned this pull request Nov 13, 2024

Roll Flutter from c8510f29ccc2 to ed553d10cf63 (48 revisions) flutter/packages#8076

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Nov 13, 2024

95a9b97 Add test for dynamic_content_color.0.dart (flutter/flutter#…

7d2065b

…158309)

auto-submit bot pushed a commit that referenced this pull request Nov 14, 2024

Reland Add test for dynamic_content_color.0.dart (#158547)

c1ee381

Fixes #130459 Follow up of the reverted #158309 It adds a test for - `examples/api/lib/material/color_scheme/dynamic_content_color.0.dart`

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

95a9b97 Add test for dynamic_content_color.0.dart (flutter/flutter#…

3aee503

…158309)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

95a9b97 Add test for dynamic_content_color.0.dart (flutter/flutter#…

b8f0868

…158309)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

95a9b97 Add test for dynamic_content_color.0.dart (flutter/flutter#…

0ed6dcd

…158309)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

95a9b97 Add test for dynamic_content_color.0.dart (flutter/flutter#…

413a3f2

…158309)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

95a9b97 Add test for dynamic_content_color.0.dart (flutter/flutter#…

5e6e67b

…158309)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test for `dynamic_content_color.0.dart`#158309

Add test for `dynamic_content_color.0.dart`#158309
auto-submit[bot] merged 3 commits intoflutter:masterfrom
ValentinVignal:Add-test-for-dynamic-color-content

ValentinVignal commented Nov 7, 2024 •

edited

Loading

Uh oh!

bleroux left a comment

Uh oh!

bleroux Nov 12, 2024

Uh oh!

ValentinVignal Nov 12, 2024

Uh oh!

bleroux Nov 12, 2024

Uh oh!

ValentinVignal Nov 12, 2024

Uh oh!

TahaTesser commented Nov 12, 2024

Uh oh!

TahaTesser commented Nov 12, 2024

Uh oh!

bleroux commented Nov 12, 2024

Uh oh!

auto-submit bot commented Nov 12, 2024

Uh oh!

bleroux commented Nov 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ValentinVignal commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

bleroux left a comment

Choose a reason for hiding this comment

Uh oh!

bleroux Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

ValentinVignal Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

bleroux Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

ValentinVignal Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

TahaTesser commented Nov 12, 2024

Uh oh!

TahaTesser commented Nov 12, 2024

Uh oh!

bleroux commented Nov 12, 2024

Uh oh!

auto-submit bot commented Nov 12, 2024

Uh oh!

bleroux commented Nov 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ValentinVignal commented Nov 7, 2024 •

edited

Loading