[SwiftPM] Add separate feature flag for the app migration by loic-sharma · Pull Request #158897 · flutter/flutter

loic-sharma · 2024-11-14T00:28:29Z

Overview

This splits the Swift Package Manager feature in two:

SwiftPM feature: This builds plugins using SwiftPM (if the app supports it), and, uses the new app & plugin templates that support SwiftPM
SwiftPM app migration feature: this updates an existing Flutter iOS or macOS app to support Swift Package Manager. This feature requires the SwiftPM feature - if SwiftPM is off, the app migration is also off.

For now, both features are off by default. We plan to turn on the first feature in the next stable release. The app migration feature will be stay off by default until we have higher confidence in the migration.

See this mini design doc: #151567 (comment)

Here's the PR that updates the SwiftPM docs: flutter/website#11495

Part of #151567

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

andrewkolos

LGTM with nits. If you end up needing another review after monorepo/formatting merges, just let me know.

packages/flutter_tools/test/general.shard/features_test.dart

andrewkolos · 2024-12-17T11:52:32Z

...er_tools/test/general.shard/migrations/swift_package_manager_integration_migration_test.dart

        plistParser: FakePlistParser(),
-        features: TestFeatureFlags(),
+        features: TestFeatureFlags(
+          isSwiftPackageManagerMigrationEnabled: true,


should we explicitly disable SPM here for the sake of clarity?

I would prefer to as well. However, that results in a warning that tells you not to provide an argument if the value is the default value. I'm not a huge fan of this warning 😦

packages/flutter_tools/test/general.shard/xcode_project_test.dart

jmagman

LGTM once testWith/WithoutContext is used in tests.

Co-authored-by: Andrew Kolos <[email protected]>

…utter/flutter#158897)

loic-sharma · 2025-01-08T23:06:18Z

Reason for revert: This PR should be in the same release as #161275. However, #161275 had to be reverted and won't be relanded until after the release cutoff. Hence, I'm reverting this as well.

auto-submit · 2025-01-08T23:06:30Z

Time to revert pull request flutter/flutter/158897 has elapsed.
You need to open the revert manually and process as a regular pull request.

…utter#158897)" This reverts commit e7a1b68.

…58897)" (#161342) This reverts #158897 (commit e7a1b68) as it is intended to be in the same release as #161275. However, #161275 had to be reverted and won't be relanded until after the release cutoff. Hence, I'm reverting this as well.

…utter/flutter#158897)

github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. a: desktop Running on desktop labels Nov 14, 2024

loic-sharma force-pushed the spm_migration_flag branch from 448a661 to 8050706 Compare November 19, 2024 02:10

github-actions bot removed the platform-ios iOS applications specifically label Nov 19, 2024

loic-sharma force-pushed the spm_migration_flag branch 7 times, most recently from d5acab3 to 282b63a Compare November 21, 2024 22:40

loic-sharma mentioned this pull request Nov 22, 2024

[SwiftPM] Turn on by default #159309

Closed

9 tasks

loic-sharma force-pushed the spm_migration_flag branch 3 times, most recently from 739706c to e73825a Compare December 12, 2024 23:31

loic-sharma marked this pull request as ready for review December 13, 2024 23:25

loic-sharma requested review from andrewkolos and jmagman December 13, 2024 23:25

loic-sharma mentioned this pull request Dec 14, 2024

[SwiftPM] Prepare guides for next stable release flutter/website#11495

Closed

4 tasks

andrewkolos approved these changes Dec 17, 2024

View reviewed changes

jmagman approved these changes Dec 17, 2024

View reviewed changes

loic-sharma force-pushed the spm_migration_flag branch 2 times, most recently from 9457216 to 0c7c5b1 Compare January 4, 2025 01:34

loic-sharma and others added 4 commits January 6, 2025 14:08

[SwiftPM] Add separate feature flag for the app migration

5c23163

Update xcode_project_test.dart

81f103e

Co-authored-by: Andrew Kolos <[email protected]>

Address feedback

c1c4e94

Format

d531af0

loic-sharma force-pushed the spm_migration_flag branch from 0c7c5b1 to d531af0 Compare January 6, 2025 22:08

loic-sharma requested a review from vashworth January 6, 2025 22:08

vashworth approved these changes Jan 7, 2025

View reviewed changes

loic-sharma added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2025

auto-submit bot added this pull request to the merge queue Jan 7, 2025

Merged via the queue into flutter:master with commit e7a1b68 Jan 7, 2025

flutter-dashboard bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 7, 2025

engine-flutter-autoroll mentioned this pull request Jan 7, 2025

Manual roll Flutter from 29a6c648ca4d to 9467677fef47 (159 revisions) flutter/packages#8389

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 7, 2025

e7a1b68 [SwiftPM] Add separate feature flag for the app migration (fl…

6bd06ea

…utter/flutter#158897)

engine-flutter-autoroll mentioned this pull request Jan 8, 2025

Roll Flutter from 29a6c648ca4d to b5df29072de2 (167 revisions) flutter/packages#8392

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025

e7a1b68 [SwiftPM] Add separate feature flag for the app migration (fl…

54e2d44

…utter/flutter#158897)

engine-flutter-autoroll mentioned this pull request Jan 8, 2025

Roll Flutter from 29a6c648ca4d to b5df29072de2 (167 revisions) flutter/packages#8393

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025

e7a1b68 [SwiftPM] Add separate feature flag for the app migration (fl…

0725375

…utter/flutter#158897)

engine-flutter-autoroll mentioned this pull request Jan 8, 2025

Roll Flutter from 29a6c648ca4d to 2b51318302c4 (168 revisions) flutter/packages#8394

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025

e7a1b68 [SwiftPM] Add separate feature flag for the app migration (fl…

7982708

…utter/flutter#158897)

engine-flutter-autoroll mentioned this pull request Jan 8, 2025

Roll Flutter from 29a6c648ca4d to 9d7f6cc43bd1 (169 revisions) flutter/packages#8395

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jan 8, 2025

e7a1b68 [SwiftPM] Add separate feature flag for the app migration (fl…

61bfe55

…utter/flutter#158897)

loic-sharma added the revert Autorevert PR (with "Reason for revert:" comment) label Jan 8, 2025

auto-submit bot removed the revert Autorevert PR (with "Reason for revert:" comment) label Jan 8, 2025

loic-sharma added a commit to loic-sharma/flutter that referenced this pull request Jan 8, 2025

Revert "[SwiftPM] Add separate feature flag for the app migration (fl…

47369c0

…utter#158897)" This reverts commit e7a1b68.

loic-sharma mentioned this pull request Jan 8, 2025

Revert "[SwiftPM] Add separate feature flag for the app migration (#158897)" #161342

Merged

loic-sharma added a commit to loic-sharma/flutter that referenced this pull request Jan 8, 2025

Revert "[SwiftPM] Add separate feature flag for the app migration (fl…

1efd381

…utter#158897)" This reverts commit e7a1b68.

loic-sharma mentioned this pull request Jan 17, 2025

[SwiftPM] Add separate feature flag for the app migration #161832

Closed

9 tasks

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 12, 2025

e7a1b68 [SwiftPM] Add separate feature flag for the app migration (fl…

8fc7cfa

…utter/flutter#158897)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

e7a1b68 [SwiftPM] Add separate feature flag for the app migration (fl…

7b908ce

…utter/flutter#158897)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 13, 2025

e7a1b68 [SwiftPM] Add separate feature flag for the app migration (fl…

dfc1e5f

…utter/flutter#158897)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 6, 2025

e7a1b68 [SwiftPM] Add separate feature flag for the app migration (fl…

eafb556

…utter/flutter#158897)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 7, 2025

e7a1b68 [SwiftPM] Add separate feature flag for the app migration (fl…

d3c6706

…utter/flutter#158897)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[SwiftPM] Add separate feature flag for the app migration#158897

[SwiftPM] Add separate feature flag for the app migration#158897
auto-submit[bot] merged 4 commits intoflutter:masterfrom
loic-sharma:spm_migration_flag

loic-sharma commented Nov 14, 2024 •

edited

Loading

Uh oh!

andrewkolos left a comment

Uh oh!

Uh oh!

andrewkolos Dec 17, 2024

Uh oh!

loic-sharma Dec 17, 2024

Uh oh!

Uh oh!

jmagman left a comment

Uh oh!

loic-sharma commented Jan 8, 2025

Uh oh!

auto-submit bot commented Jan 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

loic-sharma commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Pre-launch Checklist

Uh oh!

andrewkolos left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andrewkolos Dec 17, 2024

Choose a reason for hiding this comment

Uh oh!

loic-sharma Dec 17, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jmagman left a comment

Choose a reason for hiding this comment

Uh oh!

loic-sharma commented Jan 8, 2025

Uh oh!

auto-submit bot commented Jan 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

loic-sharma commented Nov 14, 2024 •

edited

Loading